Skip to content

Commit b96542b

Browse files
tlilmeta-codesync[bot]
authored andcommitted
update vulnerable node packages + fix sdoc publishing
Summary: ### Update Packages Update lock file to address Dependabot-reported vulnerabilities: - Pin `diff` to v5.2.2; T252137568 - Pin `lodash`/`lodash-es` to v4.17.23; T252303828, T252303820 ### Fix Internal Publishing Use `warn`-flag to circumvent the link-checker getting confused by double `/hack`-prefix on internally hosted static docs; e.g.: - Docusaurus [reports](https://www.internalfb.com/sandcastle/job/27021600194364056/artifact/actionlog.27021624813170696.log?selectedLines=55-56-1-1) `/hack/asynchronous-operations/introduction/` as broken due to flattening of `/docs/hack/*` to `/hack/*` in D90993327. - Public doc site, [docs.hhvm.com](https://docs.hhvm.com/hack/asynchronous-operations/introduction/), has been published with these landing and works as expected. - However, on Static Docs, the URL changes from: - From `(...)/intern/staticdocs/hack/docs/hack/asynchronous-operations/introduction/` - To: `(...)/intern/staticdocs/hack/hack/asynchronous-operations/introduction/` - ... and Docusaurus barks at the `/hack/hack` part. Temporarily trying to fix internal publishing pipeline in prep for a more permanent resolution. Reviewed By: francesco-zappa-nardelli Differential Revision: D91219608 fbshipit-source-id: dd6312e8bd651f65738966cba72712d20dc5be9f
1 parent 3224e3f commit b96542b

3 files changed

Lines changed: 19 additions & 13 deletions

File tree

hphp/hack/website/docusaurus.config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ const darkCodeTheme = require('prism-react-renderer').themes.vsDark;
1313
tagline: 'Moving fast with high-performance Hack, a programming language for building reliable websites at epic scale',
1414
url: 'https://docs.hhvm.com',
1515
baseUrl: process.env.DOCUSAURUS_BASE_URL || '/',
16-
onBrokenLinks: 'throw',
16+
// temp: use 'warn' to circumvent link-checker getting confused by double `/hack`-prefix on internally hosted static docs
17+
onBrokenLinks: 'warn',
1718
trailingSlash: true,
1819
favicon: 'img/favicon.ico',
1920
organizationName: 'facebook',

hphp/hack/website/package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@
2424
"react": "^18.3.1",
2525
"react-dom": "^18.3.1"
2626
},
27+
"resolutions": {
28+
"diff": "5.2.2",
29+
"lodash": "4.17.23",
30+
"lodash-es": "4.17.23"
31+
},
2732
"browserslist": {
2833
"production": [
2934
">0.5%",

hphp/hack/website/yarn.lock

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4932,10 +4932,10 @@ devlop@^1.0.0, devlop@^1.1.0:
49324932
dependencies:
49334933
dequal "^2.0.0"
49344934

4935-
diff@^5.0.0:
4936-
version "5.2.0"
4937-
resolved "https://registry.yarnpkg.com/diff/-/diff-5.2.0.tgz#26ded047cd1179b78b9537d5ef725503ce1ae531"
4938-
integrity sha512-uIFDxqpRZGZ6ThOk84hEfqWoHx2devRFvpTZcTHur85vImfaxUbTW9Ryh4CpCuDnToOP1CEtXKIgytHBPVff5A==
4935+
diff@5.2.2, diff@^5.0.0:
4936+
version "5.2.2"
4937+
resolved "https://registry.yarnpkg.com/diff/-/diff-5.2.2.tgz#0a4742797281d09cfa699b79ea32d27723623bad"
4938+
integrity sha512-vtcDfH3TOjP8UekytvnHH1o1P4FcUdt4eQ1Y+Abap1tk/OB2MWQvcwS2ClCd1zuIhc3JKOx6p3kod8Vfys3E+A==
49394939

49404940
dir-glob@^3.0.1:
49414941
version "3.0.1"
@@ -6947,10 +6947,10 @@ locate-path@^7.1.0:
69476947
dependencies:
69486948
p-locate "^6.0.0"
69496949

6950-
lodash-es@4.17.21, lodash-es@^4.17.21:
6951-
version "4.17.21"
6952-
resolved "https://registry.yarnpkg.com/lodash-es/-/lodash-es-4.17.21.tgz#43e626c46e6591b7750beb2b50117390c609e3ee"
6953-
integrity sha512-mKnC+QJ9pWVzv+C4/U3rRsHapFfHvQFoFB92e52xeyGMcX6/OlIl78je1u8vePzYZSkkogMPJ2yjxxsb89cxyw==
6950+
lodash-es@4.17.21, lodash-es@4.17.23, lodash-es@^4.17.21:
6951+
version "4.17.23"
6952+
resolved "https://registry.yarnpkg.com/lodash-es/-/lodash-es-4.17.23.tgz#58c4360fd1b5d33afc6c0bbd3d1149349b1138e0"
6953+
integrity sha512-kVI48u3PZr38HdYz98UmfPnXl2DXrpdctLrFLCd3kOx1xUkOmpFPx7gCWWM5MPkL/fD8zb+Ph0QzjGFs4+hHWg==
69546954

69556955
lodash.debounce@^4.0.8:
69566956
version "4.0.8"
@@ -6972,10 +6972,10 @@ lodash.uniq@^4.5.0:
69726972
resolved "https://registry.yarnpkg.com/lodash.uniq/-/lodash.uniq-4.5.0.tgz#d0225373aeb652adc1bc82e4945339a842754773"
69736973
integrity sha512-xfBaXQd9ryd9dlSDvnvI0lvxfLJlYAZzXomUYzLKtUeOQvOP5piqAWuGtrhWeqaXK9hhoM/iyJc5AV+XfsX3HQ==
69746974

6975-
lodash@^4.17.20, lodash@^4.17.21:
6976-
version "4.17.21"
6977-
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c"
6978-
integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==
6975+
lodash@4.17.23, lodash@^4.17.20, lodash@^4.17.21:
6976+
version "4.17.23"
6977+
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.23.tgz#f113b0378386103be4f6893388c73d0bde7f2c5a"
6978+
integrity sha512-LgVTMpQtIopCi79SJeDiP0TfWi5CNEc/L/aRdTh3yIvmZXTnheWpKjSZhnvMl8iXbC1tFg9gdHHDMLoV7CnG+w==
69796979

69806980
longest-streak@^3.0.0:
69816981
version "3.1.0"

0 commit comments

Comments
 (0)