address violations of warning unreachable-code-return

Summary: TSIA.

Reviewed By: kwaugh

Differential Revision: D95684729

fbshipit-source-id: 192164ea98c7d44eb0ffdcdffd0d7e2c2fec9adb

Author: yfeldblum

third-party/proxygen/src/proxygen/lib/http/codec/DefaultHTTPCodecFactory.cpp

@@ -60,7 +60,5 @@ std::unique_ptr<HTTPCodec> DefaultHTTPCodecFactory::getCodec(
       // default
       return nullptr;
   }
-  // unreachable
-  return nullptr;
 }
 } // namespace proxygen

third-party/proxygen/src/proxygen/lib/http/coro/filters/test/TransformFilterTest.cpp

@@ -132,10 +132,9 @@ CO_TEST_F_X(TransformFilterTest, InvokeOnError) {
         return std::move(headerEvent);
       };
   TransformFilter::BodyTransformFn bodyHook =
-      [](folly::Try<HTTPBodyEvent>&& bodyEvent) {
-        LOG(FATAL) << "unreachable";
-        return folly::Try<HTTPBodyEvent>();
-      };
+      [](folly::Try<HTTPBodyEvent>&& bodyEvent) -> folly::Try<HTTPBodyEvent> {
+    LOG(FATAL) << "unreachable";
+  };
 
   auto* transformSource = new TransformFilter(
       respSource, std::move(headerHook), std::move(bodyHook));
@@ -170,9 +169,8 @@ CO_TEST_F_X(TransformFilterTest, TransformBodyToError) {
 
   HTTPSourceReader reader(transformSource);
 
-  reader.onBody([](BufQueue body, bool /*eom*/) {
+  reader.onBody([](BufQueue body, bool /*eom*/) -> bool {
     LOG(FATAL) << "shouldn't happen";
-    return HTTPSourceReader::Continue;
   });
 
   // read response

third-party/proxygen/src/proxygen/lib/http/coro/server/test/HTTPServerTest.cpp

@@ -356,10 +356,9 @@ TEST_P(HTTPServerTests, TestFilterFailException) {
          const folly::AsyncTransportCertificate* /*peerCert*/,
          const std::string& /* nextProtocolName */,
          SecureTransportType /* secureTransportType */,
-         const wangle::TransportInfo& /* tinfo */) {
-        throw std::runtime_error("filter failed this connection");
-        return true;
-      };
+         const wangle::TransportInfo& /* tinfo */) -> bool {
+    throw std::runtime_error("filter failed this connection");
+  };
   startServer(nullptr, /*expectRequest=*/false);
   initClient();
 

third-party/proxygen/src/proxygen/lib/http/test/HTTPMessageTest.cpp

@@ -861,9 +861,8 @@ TEST(HTTPHeaders, MoveFromTest) {
   HTTPHeaders h1;
   HTTPHeaders h2(std::move(h1));
   EXPECT_FALSE(h1.exists(HTTP_HEADER_CONNECTION));
-  h1.forEachValueOfHeader(HTTP_HEADER_HOST, [](const std::string&) {
+  h1.forEachValueOfHeader(HTTP_HEADER_HOST, [](const std::string&) -> bool {
     CHECK(false) << "Unreachable";
-    return false;
   });
   h1.add(HTTP_HEADER_CONNECTION, "close");
 

third-party/proxygen/src/proxygen/lib/utils/ZlibStreamCompressor.cpp

@@ -123,7 +123,7 @@ std::unique_ptr<IOBuf> ZlibStreamCompressor::compress(const IOBuf* in,
       while (zlibStream_.avail_in != 0) {
         status_ = deflateHelper(&zlibStream_, out.get(), Z_NO_FLUSH);
         if (status_ != Z_OK) {
-          DLOG(FATAL) << "Deflate failed: " << zlibStream_.msg;
+          LOG(DFATAL) << "Deflate failed: " << zlibStream_.msg;
           return nullptr;
         }
       }
@@ -136,7 +136,7 @@ std::unique_ptr<IOBuf> ZlibStreamCompressor::compress(const IOBuf* in,
     } while (status_ == Z_OK);
 
     if (status_ != Z_STREAM_END) {
-      DLOG(FATAL) << "Deflate failed: " << zlibStream_.msg;
+      LOG(DFATAL) << "Deflate failed: " << zlibStream_.msg;
       return nullptr;
     }
   } else {
@@ -145,7 +145,7 @@ std::unique_ptr<IOBuf> ZlibStreamCompressor::compress(const IOBuf* in,
     } while (zlibStream_.avail_out == 0);
 
     if (status_ != Z_OK) {
-      DLOG(FATAL) << "Deflate failed: " << zlibStream_.msg;
+      LOG(DFATAL) << "Deflate failed: " << zlibStream_.msg;
       return nullptr;
     }
   }

third-party/proxygen/src/proxygen/lib/utils/perfect_hash_table_template.cpp.gperf

@@ -67,8 +67,7 @@ const std::string* %%name%%::getPointerToTable(
       // Controlled abort here so its clear from a crash stack this method
       // was called with a table type for which there is no current
       // implementation
-      CHECK(false);
-      return nullptr;
+      LOG(FATAL) << "unknown table type";
   }
 }