Commit d84aa7e
Add SQ_INTERNAL_ERROR for reporting internal client errors
Summary:
When the client detects an internal invariant violation -- a state it believes
is unreachable -- it currently aborts the process with a CHECK. That takes down
everything running in the process because of a client-side bug that affects a
single operation.
Add SQ_INTERNAL_ERROR to the SquangleErrno enum so those sites can instead fail
the operation and report an error to the caller. This commit only introduces
the value; converting the individual CHECK sites to use it is separate. The
addition is purely additive -- no existing enumerator is renumbered.
Reviewed By: aditya-jalan
Differential Revision: D116688926
fbshipit-source-id: 233270d720b589c01e25e66576484221305a6d631 parent de0b807 commit d84aa7e
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| 110 | + | |
110 | 111 | | |
111 | 112 | | |
112 | 113 | | |
| |||
0 commit comments