Add --from CLI flag for caller identification logging

Summary:
Add a `--from` CLI flag to hphpd so callers can identify themselves
(e.g., "notebook X" or "script Y") in debugger usage logs.

Reviewed By: mdko

Differential Revision: D95228198

fbshipit-source-id: db465b4b8c00f31f54514b8d1c97e89b22bbde0f

Author: Nikhil Thomas

hphp/runtime/base/program-functions.cpp

@@ -1615,6 +1615,8 @@ static int execute_program_impl(int argc, char** argv) {
     ("debug-sandbox",
      value<std::string>(&po.debugger_options.sandbox)->default_value("default"),
      "initial sandbox to attach to when debugger is started")
+    ("from", value<std::string>(&po.debugger_options.from),
+     "caller identifier for debugger usage logging")
     ("user,u", value<std::string>(&po.user),
      "run server under this user account")
     ("file,f", value<std::string>(&po.file),

hphp/runtime/debugger/debugger_base.h

@@ -39,6 +39,7 @@ struct DebuggerClientOptions {
   std::string user;
   std::string configFName;
   std::string fileName;
+  std::string from;
 };
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -234,6 +235,7 @@ struct DebuggerUsageLogger {
   virtual void clearClientInfo() {}
   virtual void setClientInfo(const std::string& /*username*/, uid_t /*uid*/,
                              pid_t /*clientPid*/) {}
+  virtual void setFrom(const std::string& /*from*/) {}
   virtual void
   log(const std::string& /*clientId*/, const std::string& /*mode*/,
       const std::string& /*sandboxId*/, const std::string& /*cmd*/,

hphp/runtime/debugger/debugger_client.cpp

@@ -761,6 +761,9 @@ void DebuggerClient::init(const DebuggerClientOptions &options) {
     m_options.user = Process::GetCurrentUser();
   }
 
+  auto* logger = Debugger::GetUsageLogger();
+  if (logger) logger->setFrom(options.from);
+
   usageLogEvent("init");
 
   loadConfig();