Skip to content

Commit da7891b

Browse files
Anicet Dushime Wa Mungumeta-codesync[bot]
authored andcommitted
Assign oncall ownership to HHVM-specific runtime/ext extensions
Summary: Assign oncall ownership to 27 HHVM-specific extensions under runtime/ext/ that currently have NO_ONCALL_YET. Each extension was individually researched by analyzing code authors, commit history, domain scope, dependency oncalls, and documentation to determine the correct owner. - mcrouter → "memcache" (thin wrapper around mcrouter_core, domain-owned by memcache team) - 26 remaining extensions → "hphp_hphpi" (core HHVM runtime infrastructure) Extensions covered: - Core: hh, xhp, implicit_context, collections, server, intrinsics, functioncredential - Profiling/Debug: xenon, objprof, heapgraph, vsdebug - HSL native backing: hsl_os, hsl_locale, hsl_str, hsl_random, hsl_regex, hsl_systemlib, hsl_time, hsl_io - Compression: snappy, lz4, scrypt - Utility: fribidi, unitfilecache, xreqsync - Caching: mcrouter Reviewed By: mdko Differential Revision: D95441709 fbshipit-source-id: d5528dc4539ef9e9eab782143ea50d1b3e86819c
1 parent 156a6bb commit da7891b

25 files changed

Lines changed: 26 additions & 26 deletions

hphp/runtime/ext/collections/ext_collections.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ inline size_t getSize(const ObjectData* od) {
6767
/////////////////////////////////////////////////////////////////////////////
6868

6969
struct CollectionsExtension : Extension {
70-
CollectionsExtension(): Extension("collections", NO_EXTENSION_VERSION_YET, NO_ONCALL_YET) {}
70+
CollectionsExtension(): Extension("collections", NO_EXTENSION_VERSION_YET, "hphp_hphpi") {}
7171

7272
void moduleRegisterNative() override {
7373
registerNativePair();

hphp/runtime/ext/fribidi/ext_fribidi.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ static Array HHVM_FUNCTION(
151151
}
152152

153153
struct FribidiExtension final : Extension {
154-
FribidiExtension() : Extension("fribidi", NO_EXTENSION_VERSION_YET, NO_ONCALL_YET) {}
154+
FribidiExtension() : Extension("fribidi", NO_EXTENSION_VERSION_YET, "hphp_hphpi") {}
155155
void moduleRegisterNative() override {
156156
// Charsets
157157
HHVM_RC_INT(FRIBIDI_CHARSET_UTF8, FRIBIDI_CHAR_SET_UTF8);

hphp/runtime/ext/functioncredential/ext_functioncredential.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ void validateCredentialNotExpired(std::int64_t validUntilEpoch) {
350350

351351
struct FunctionCredentialExtension final : Extension {
352352
FunctionCredentialExtension()
353-
: Extension("functioncredential", "1.0", NO_ONCALL_YET) {}
353+
: Extension("functioncredential", "1.0", "authz_scaled_solutions") {}
354354

355355
void moduleLoad(const IniSetting::Map& ini, Hdf hdf) override {
356356
bool testMode =

hphp/runtime/ext/hh/ext_hh.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1627,7 +1627,7 @@ bool HHVM_FUNCTION(legacy_is_truthy, const Variant& v) {
16271627
}
16281628

16291629
static struct HHExtension final : Extension {
1630-
HHExtension(): Extension("hh", NO_EXTENSION_VERSION_YET, NO_ONCALL_YET) { }
1630+
HHExtension(): Extension("hh", NO_EXTENSION_VERSION_YET, "hphp_hphpi") { }
16311631
void moduleRegisterNative() override {
16321632
#define X(nm) HHVM_NAMED_FE(HH\\nm, HHVM_FN(nm))
16331633
X(autoload_is_native);
@@ -1726,7 +1726,7 @@ static struct HHExtension final : Extension {
17261726
} s_hh_extension;
17271727

17281728
static struct XHPExtension final : Extension {
1729-
XHPExtension(): Extension("xhp", NO_EXTENSION_VERSION_YET, NO_ONCALL_YET) { }
1729+
XHPExtension(): Extension("xhp", NO_EXTENSION_VERSION_YET, "hphp_hphpi") { }
17301730
bool moduleEnabled() const override { return Cfg::Eval::EnableXHP; }
17311731

17321732
std::vector<std::string> hackFiles() const override {

hphp/runtime/ext/hh/ext_implicit_context.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ Variant coeffects_call_helper(const Variant& function, const char* name,
341341

342342

343343
static struct HHImplicitContext final : Extension {
344-
HHImplicitContext(): Extension("implicit_context", NO_EXTENSION_VERSION_YET, NO_ONCALL_YET) { }
344+
HHImplicitContext(): Extension("implicit_context", NO_EXTENSION_VERSION_YET, "hphp_hphpi") { }
345345
void moduleRegisterNative() override {
346346
Native::registerNativeDataInfo<ImplicitContext>(
347347
ImplicitContextLoader::className().get());

hphp/runtime/ext/hsl/ext_hsl_io.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ namespace {
7474

7575
struct IOExtension final : Extension {
7676

77-
IOExtension() : Extension("hsl_io", "1.0", NO_ONCALL_YET) {}
77+
IOExtension() : Extension("hsl_io", "1.0", "hphp_hphpi") {}
7878

7979
void moduleRegisterNative() override {
8080
// Clang 15 doesn't like the HHVM_FALIAS macro with \\N

hphp/runtime/ext/hsl/ext_hsl_locale.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ Object HHVM_FUNCTION(newlocale_all,
173173

174174
struct LocaleExtension final : Extension {
175175

176-
LocaleExtension() : Extension("hsl_locale", "0.1", NO_ONCALL_YET) {}
176+
LocaleExtension() : Extension("hsl_locale", "0.1", "hphp_hphpi") {}
177177

178178
void moduleRegisterNative() override {
179179
// Remember to update the HHI :)

hphp/runtime/ext/hsl/ext_hsl_os.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1072,7 +1072,7 @@ int64_t HHVM_FUNCTION(HSL_os_fork_and_execve,
10721072

10731073
struct OSExtension final : Extension {
10741074

1075-
OSExtension() : Extension("hsl_os", "0.1", NO_ONCALL_YET) {}
1075+
OSExtension() : Extension("hsl_os", "0.1", "hphp_hphpi") {}
10761076

10771077
void cliClientInit() override {
10781078
CLI_REGISTER_HANDLER(HSL_os_open);

hphp/runtime/ext/hsl/ext_hsl_random.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ int64_t HHVM_FUNCTION(HH_random_int, int64_t min, int64_t max) {
4949
namespace {
5050

5151
struct RandomExtension final : Extension {
52-
RandomExtension() : Extension("hsl_random", "1.0", NO_ONCALL_YET) {}
52+
RandomExtension() : Extension("hsl_random", "1.0", "hphp_hphpi") {}
5353
void moduleRegisterNative() override {
5454
// Clang 15 doesn't like the HHVM_FALIAS macro with \\N
5555
HHVM_FALIAS_FE_STR(

hphp/runtime/ext/hsl/ext_hsl_regex.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ namespace {
104104
}
105105

106106
struct RegexExtension final : Extension {
107-
RegexExtension() : Extension("hsl_regex", "0.1", NO_ONCALL_YET) {}
107+
RegexExtension() : Extension("hsl_regex", "0.1", "hphp_hphpi") {}
108108

109109
void moduleRegisterNative() override {
110110
HHVM_FALIAS(

0 commit comments

Comments
 (0)