Default polymorphic typing of function pointers to true

Summary: Sets default for the new, polymorphic typing of function pointers to true

Reviewed By: geralt-encore

Differential Revision: D88066832

fbshipit-source-id: e5024a237c826bc1cdaec5f80c1aaa93f916196b

Author: Michael Thomas

hphp/hack/src/options/globalOptions.ml

@@ -327,7 +327,7 @@ let default =
     class_pointer_ban_classname_static_meth = 0;
     class_pointer_ban_classname_class_const = 0;
     class_pointer_ban_class_array_key = false;
-    tco_poly_function_pointers = false;
+    tco_poly_function_pointers = true;
     tco_check_packages = true;
     fanout_strip_class_location = false;
     tco_package_config_disable_transitivity_check = false;

hphp/hack/src/oxidized/manual/global_options_impl.rs

@@ -156,7 +156,7 @@ impl Default for GlobalOptions {
             class_pointer_ban_classname_static_meth: 0,
             class_pointer_ban_classname_class_const: 0,
             class_pointer_ban_class_array_key: false,
-            tco_poly_function_pointers: false,
+            tco_poly_function_pointers: true,
             tco_check_packages: true,
             fanout_strip_class_location: false,
             tco_package_config_disable_transitivity_check: false,

hphp/hack/test/integration_ml/test_funptr.ml

@@ -128,9 +128,6 @@ let identify_tests =
                 Lsp.MarkedString "Defined in `Cardoor`";
                 Lsp.MarkedString "---";
                 Lsp.MarkedCode ("hack", "public static function bar<T>(T $x): T");
-                Lsp.MarkedString "---";
-                Lsp.MarkedString "Instantiation:";
-                Lsp.MarkedCode ("hack", "  T = string;");
               ];
             addendum = [Lsp.MarkedString "bar_docblock"];
             pos = pos_at (20, 17) (20, 19);

hphp/hack/test/typecheck/class_meth_dollarsign.php.exp

@@ -2,7 +2,7 @@ ERROR: File "class_meth_dollarsign.php", line 7, characters 32-37:
 `meth_caller` cannot be called on strings that contain `$` (Parsing[1002])
 ERROR: File "class_meth_dollarsign.php", line 7, characters 32-37:
 No instance method `bar$` in `Foo` (Typing[4053])
-  File "class_meth_dollarsign.php", line 7, characters 8-38:
+  File "class_meth_dollarsign.php", line 7, characters 20-22:
   This is why I think it is an object of type Foo
   File "class_meth_dollarsign.php", line 3, characters 7-9:
   Declaration of `Foo` is here

hphp/hack/test/typecheck/constraints/classmeth_constraints_bad.php.exp

@@ -2,7 +2,5 @@ ERROR: File "classmeth_constraints_bad.php", line 11, characters 6-6:
 Invalid argument (Typing[4110])
   File "classmeth_constraints_bad.php", line 6, characters 39-42:
   Expected `Base`
-  File "classmeth_constraints_bad.php", line 6, characters 46-46:
-    via this generic `T`
   File "classmeth_constraints_bad.php", line 11, characters 6-6:
   But got `int`

hphp/hack/test/typecheck/function_pointer/class_meth_reified.php.exp

@@ -1,8 +1 @@
-ERROR: File "class_meth_reified.php", line 8, characters 3-12:
-All type arguments must be specified because a type parameter is reified (Typing[4303])
-  File "class_meth_reified.php", line 4, characters 36-36:
-  Definition is here
-ERROR: File "class_meth_reified.php", line 10, characters 3-12:
-All type arguments must be specified because a type parameter is reified (Typing[4303])
-  File "class_meth_reified.php", line 4, characters 36-36:
-  Definition is here
+No errors

hphp/hack/test/typecheck/function_pointer/class_meth_reified_self.php.exp

@@ -1,4 +1 @@
-ERROR: File "class_meth_reified_self.php", line 7, characters 5-15:
-All type arguments must be specified because a type parameter is reified (Typing[4303])
-  File "class_meth_reified_self.php", line 4, characters 36-36:
-  Definition is here
+No errors

hphp/hack/test/typecheck/function_pointer/class_meth_reified_static.php.exp

@@ -1,4 +1 @@
-ERROR: File "class_meth_reified_static.php", line 7, characters 5-17:
-All type arguments must be specified because a type parameter is reified (Typing[4303])
-  File "class_meth_reified_static.php", line 4, characters 36-36:
-  Definition is here
+No errors

hphp/hack/test/typecheck/function_pointer/class_meth_reified_targs_missing.php.exp

@@ -1,4 +1 @@
-ERROR: File "class_meth_reified_targs_missing.php", line 8, characters 8-17:
-All type arguments must be specified because a type parameter is reified (Typing[4303])
-  File "class_meth_reified_targs_missing.php", line 4, characters 36-36:
-  Definition is here
+No errors

hphp/hack/test/typecheck/function_pointer/class_meth_reified_trait.php.exp

@@ -6,11 +6,3 @@ WARN: File "class_meth_reified_trait.php", line 10, characters 8-10:
 Static method call on a trait: `Foo::bar` (Warn[12020])
   File "class_meth_reified_trait.php", line 3, characters 7-9:
   `Foo` is defined here
-ERROR: File "class_meth_reified_trait.php", line 8, characters 3-12:
-All type arguments must be specified because a type parameter is reified (Typing[4303])
-  File "class_meth_reified_trait.php", line 4, characters 36-36:
-  Definition is here
-ERROR: File "class_meth_reified_trait.php", line 10, characters 3-12:
-All type arguments must be specified because a type parameter is reified (Typing[4303])
-  File "class_meth_reified_trait.php", line 4, characters 36-36:
-  Definition is here