Skip to content

Commit f697ebe

Browse files
mszabo-wikiameta-codesync[bot]
authored andcommitted
Fix watcher extension (#9663)
Summary: Change the extension name so that it's unique, add missing sources to the CMake manifest and update the count of expected extensions. Pull Request resolved: #9663 Reviewed By: paulbiss Differential Revision: D86868056 fbshipit-source-id: 66d6273be5d0f363ed8f257a3efbc33dec3700ff
1 parent 52ad846 commit f697ebe

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

hphp/runtime/ext/watcher/config.cmake

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
HHVM_DEFINE_EXTENSION("watchman" IMPLICIT
1+
HHVM_DEFINE_EXTENSION("watcher" IMPLICIT
22
SOURCES
33
ext_watcher.cpp
4+
watcher-clock.cpp
5+
watcher-options.cpp
46
SYSTEMLIB
57
ext_watcher.php
68
DEPENDS

hphp/util/hphp-config.h.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ ${HHVM_COMPILES_DEFINE_STRING}
8888
#endif
8989

9090
#ifdef USE_CMAKE
91-
# if ${HHVM_EXTENSION_COUNT} != 99
91+
# if ${HHVM_EXTENSION_COUNT} != 100
9292
# error You need to update the config file for the new builtin extension, and add the define to the FB section
9393
# endif
9494
${HHVM_EXTENSIONS_ENABLED_DEFINE_STRING}

0 commit comments

Comments
 (0)