Remove hh_client --save-state and hh_server --save-state

Summary:
## What
Remove the ability to generate saved states via `hh_client --save-state` and
`hh_server --save-state` command-line options. This includes:
- Removing CLI argument parsing for --save-state and --gen-saved-ignore-type-errors
- Removing the SAVE_STATE RPC command and its handler
- Removing save_state functions from SaveStateService
- Deleting integration tests that exercised this functionality

## Why

Saved state generation in prod is done via hh_distc, so, imo, these old mechanisms for making saved states are pure risk and overhead–I suspect that over time the behavior of unused duplicate APIs diverges, producing footguns.

andrewjkennedy raised the concern that being able to make saved states *only* with hh_distc may tie us to remote execution: iuc this we're safe, since hh_distc can be run locally-only, without remote execution.

## Follow-on

Add more testing for making saved states with hh_distc: D91029946

Reviewed By: madgen

Differential Revision: D91018321

fbshipit-source-id: 6a8618da8e08c741a4ffde8aded80e479807eac6

Author: mheiber

hphp/hack/src/client/clientArgs.ml

@@ -144,7 +144,6 @@ let parse_check_args cmd ~from_default : ClientEnv.client_check_env =
   let from = ref from_default in
   let show_spinner = ref None in
   let show_tast = ref false in
-  let gen_saved_ignore_type_errors = ref false in
   let ignore_hh_version = ref false in
   let save_64bit = ref None in
   let save_human_readable_64bit_dep_map = ref None in
@@ -414,10 +413,6 @@ let parse_check_args cmd ~from_default : ClientEnv.client_check_env =
           end,
         " (mode) for each entry in input list get list of function dependencies [file:line:character list]"
       );
-      ( "--gen-saved-ignore-type-errors",
-        Arg.Set gen_saved_ignore_type_errors,
-        " generate a saved state even if there are type errors (default: false)."
-      );
       ( "--get-method-name",
         Arg.String (fun x -> set_mode (MODE_IDENTIFY_SYMBOL3 x)),
         (* alias for --identify-function *) "" );
@@ -669,10 +664,6 @@ rewrite to the function names to something like `foo_1` and `foo_2`.
         Arg.String (fun x -> set_mode (MODE_SAVE_NAMING x)),
         " (mode) Save the naming table to the given file."
         ^ " Returns the number of files and symbols written to disk." );
-      ( "--save-state",
-        Arg.String (fun x -> set_mode (MODE_SAVE_STATE x)),
-        " (mode) Save a saved state to the given file."
-        ^ " Returns number of edges dumped from memory to the database." );
       ( "--save-64bit",
         Arg.String (fun x -> save_64bit := Some x),
         " save discovered 64-bit to the given directory" );
@@ -899,7 +890,6 @@ rewrite to the function names to something like `foo_1` and `foo_2`.
     force_dormant_start = !force_dormant_start;
     from = !from;
     show_spinner = Option.value ~default:is_interactive !show_spinner;
-    gen_saved_ignore_type_errors = !gen_saved_ignore_type_errors;
     ignore_hh_version = !ignore_hh_version;
     saved_state_ignore_hhconfig = !saved_state_ignore_hhconfig;
     paths;

hphp/hack/src/client/clientCheck.ml

@@ -12,18 +12,6 @@ open Ocaml_overrides
 module SyntaxTree =
   Full_fidelity_syntax_tree.WithSyntax (Full_fidelity_positioned_syntax)
 
-module SaveStateResultPrinter = ClientResultPrinter.Make (struct
-  type t = SaveStateServiceTypes.save_state_result
-
-  let to_string t =
-    Printf.sprintf
-      "Dependency table edges added: %d"
-      t.SaveStateServiceTypes.dep_table_edges_added
-
-  let to_json (t : SaveStateServiceTypes.save_state_result) =
-    Hh_json.JSON_Object (ServerError.get_save_state_result_props_json t)
-end)
-
 module SaveNamingResultPrinter = ClientResultPrinter.Make (struct
   type t = SaveStateServiceTypes.save_naming_result
 
@@ -138,7 +126,6 @@ let connect
     custom_telemetry_data;
     preexisting_warnings;
     error_format = _;
-    gen_saved_ignore_type_errors = _;
     paths = _;
     max_errors = _;
     mode = _;
@@ -822,18 +809,6 @@ let main_internal
     in
     SaveNamingResultPrinter.go result args.output_json;
     Lwt.return (Exit_status.No_error, telemetry)
-  | ClientEnv.MODE_SAVE_STATE path ->
-    let () = Sys_utils.mkdir_p (Filename.dirname path) in
-    (* Convert to real path because Client and Server may have
-     * different cwd and we want to use the client processes' cwd. *)
-    let path = Path.make path in
-    let%lwt (result, telemetry) =
-      rpc args
-      @@ ServerCommandTypes.SAVE_STATE
-           (Path.to_string path, args.gen_saved_ignore_type_errors)
-    in
-    SaveStateResultPrinter.go result args.output_json;
-    Lwt.return (Exit_status.No_error, telemetry)
   | ClientEnv.MODE_SEARCH query ->
     if not (String.equal query "this_is_just_to_check_liveness_of_hh_server")
     then begin

hphp/hack/src/client/clientCheckStatus.ml

@@ -63,7 +63,6 @@ let go status error_format ~is_interactive ~output_json ~max_errors =
         ~output_json
         ~error_format
         ~error_list
-        ~save_state_result:None
         ~recheck_stats:last_recheck_stats;
       0
     ) else

hphp/hack/src/client/clientEnv.ml

@@ -62,7 +62,6 @@ type client_mode =
   | MODE_REWRITE_DECLARATIONS
   | MODE_REWRITE_LAMBDA_PARAMETERS of string list
   | MODE_SAVE_NAMING of string
-  | MODE_SAVE_STATE of string
   | MODE_SEARCH of string
   | MODE_SERVER_RAGE
   | MODE_STATS
@@ -92,7 +91,6 @@ type client_check_env = {
   force_dormant_start: bool;
   from: string;
   show_spinner: bool;
-  gen_saved_ignore_type_errors: bool;
   ignore_hh_version: bool;
   saved_state_ignore_hhconfig: bool;
   paths: string list;

hphp/hack/src/client/clientSavedStateProjectMetadata.ml

@@ -32,7 +32,6 @@ let main (env : ClientEnv.client_check_env) (config : ServerLocalConfig.t) :
     force_dormant_start = _;
     from = _;
     show_spinner = _;
-    gen_saved_ignore_type_errors = _;
     paths = _;
     max_errors = _;
     preexisting_warnings = _;

hphp/hack/src/client_and_server/saveStateService.ml

@@ -101,145 +101,15 @@ let get_hot_classes (filename : string) : SSet.t =
     |> List.map ~f:Hh_json.get_string_exn
     |> SSet.of_list
 
-(** Dumps the naming-table (a saveable form of FileInfo), and errors if any,
-  and hot class decls. *)
-let dump_naming_and_errors
-    (output_filename : string)
-    (naming_table : Naming_table.t)
-    (errors : Errors.t) : unit =
-  let naming_sql_filename = output_filename ^ "_naming.sql" in
-  let (save_result : Naming_sqlite.save_result) =
-    Naming_table.save naming_table naming_sql_filename
-  in
-  Hh_logger.log
-    "Inserted symbols into the naming table:\n%s"
-    (Naming_sqlite.show_save_result save_result);
-  Hh_logger.log
-    "Finished saving naming table with %d errors."
-    (List.length save_result.Naming_sqlite.errors);
-
-  if List.length save_result.Naming_sqlite.errors > 0 then
-    Exit.exit Exit_status.Sql_assertion_failure;
-
-  assert (Sys.file_exists naming_sql_filename);
-  Hh_logger.log "Saved naming table sqlite to '%s'" naming_sql_filename;
-  (* Let's not write empty error files. *)
-  (if Errors.is_empty errors then
-    ()
-  else
-    let error_files : saved_state_errors = Errors.get_failed_files errors in
-    save_contents (get_errors_filename output_filename) error_files);
-  ()
-
-(** Sorts and dumps the error relative paths in JSON format.
- * An empty JSON list will be dumped if there are no errors.*)
-let dump_errors_json (output_filename : string) (errors : Errors.t) : unit =
-  let error_files = Errors.get_failed_files errors in
-  let errors_json =
-    Hh_json.(
-      JSON_Array
-        (List.rev
-           (Relative_path.Set.fold
-              ~init:[]
-              ~f:(fun relative_path acc ->
-                JSON_String (Relative_path.suffix relative_path) :: acc)
-              error_files)))
-  in
-  let chan = Stdlib.open_out (get_errors_filename_json output_filename) in
-  Hh_json.json_to_output chan errors_json;
-  Stdlib.close_out chan
-
 let saved_state_info_file_name ~base_file_name = base_file_name ^ "_info.json"
 
-let saved_state_build_revision_write ~(base_file_name : string) : unit =
-  let info_file = saved_state_info_file_name ~base_file_name in
-  let open Hh_json in
-  Out_channel.with_file info_file ~f:(fun fh ->
-      json_to_output fh
-      @@ JSON_Object [("build_revision", string_ Build_id.build_revision)])
-
 let saved_state_build_revision_read ~(base_file_name : string) : string =
   let info_file = saved_state_info_file_name ~base_file_name in
   let contents = RealDisk.cat info_file in
   let json = Some (Hh_json.json_of_string contents) in
   let build_revision = Hh_json_helpers.Jget.string_exn json "build_revision" in
   build_revision
 
-let dump_dep_graph_64bit ~mode ~db_name ~incremental_info_file =
-  let t = Unix.gettimeofday () in
-  let base_dep_graph =
-    match mode with
-    | Typing_deps_mode.InMemoryMode base_dep_graph -> base_dep_graph
-    | Typing_deps_mode.SaveToDiskMode { graph; _ } -> graph
-  in
-  let () =
-    let open Hh_json in
-    Out_channel.with_file incremental_info_file ~f:(fun fh ->
-        json_to_output fh
-        @@ JSON_Object [("base_dep_graph", string_opt base_dep_graph)])
-  in
-  let dep_table_edges_added =
-    Typing_deps.save_discovered_edges
-      mode
-      ~dest:db_name
-      ~reset_state_after_saving:false
-  in
-  let (_ : float) = Hh_logger.log_duration "Writing discovered edges took" t in
-  { dep_table_edges_added }
-
-(** Saves the saved state to the given path. Returns number of dependency
-* edges dumped into the database. *)
-let save_state (env : ServerEnv.env) (output_filename : string) :
-    save_state_result =
-  let () = Sys_utils.mkdir_p (Filename.dirname output_filename) in
-  let db_name =
-    match env.ServerEnv.deps_mode with
-    | Typing_deps_mode.InMemoryMode _
-    | Typing_deps_mode.SaveToDiskMode _ ->
-      output_filename ^ "_64bit_dep_graph.delta"
-  in
-  let () =
-    if Sys.file_exists output_filename then
-      failwith
-        (Printf.sprintf "Cowardly refusing to overwrite '%s'." output_filename)
-    else
-      ()
-  in
-  let () =
-    if Sys.file_exists db_name then
-      failwith (Printf.sprintf "Cowardly refusing to overwrite '%s'." db_name)
-    else
-      ()
-  in
-  let (_ : float) =
-    let naming_table = env.ServerEnv.naming_table in
-    let errors = env.ServerEnv.errorl in
-    let t = Unix.gettimeofday () in
-    dump_naming_and_errors output_filename naming_table errors;
-    Hh_logger.log_duration "Saving saved-state naming+errors took" t
-  in
-  match env.ServerEnv.deps_mode with
-  | Typing_deps_mode.InMemoryMode _ ->
-    let incremental_info_file = output_filename ^ "_incremental_info.json" in
-    dump_errors_json output_filename env.ServerEnv.errorl;
-    saved_state_build_revision_write ~base_file_name:output_filename;
-    dump_dep_graph_64bit
-      ~mode:env.ServerEnv.deps_mode
-      ~db_name
-      ~incremental_info_file
-  | Typing_deps_mode.SaveToDiskMode
-      { graph = _; new_edges_dir; human_readable_dep_map_dir } ->
-    dump_errors_json output_filename env.ServerEnv.errorl;
-    saved_state_build_revision_write ~base_file_name:output_filename;
-    Hh_logger.warn
-      "saveStateService: not saving 64-bit dep graph edges to disk, because they are already in %s"
-      new_edges_dir;
-    (match human_readable_dep_map_dir with
-    | None -> ()
-    | Some dir ->
-      Hh_logger.warn "saveStateService: human readable dep map dir: %s" dir);
-    { dep_table_edges_added = 0 }
-
 let go_naming (naming_table : Naming_table.t) (output_filename : string) :
     (save_naming_result, string) result =
   Utils.try_with_stack (fun () ->
@@ -257,10 +127,3 @@ let go_naming (naming_table : Naming_table.t) (output_filename : string) :
           nt_symbols_added = save_result.Naming_sqlite.symbols_added;
         })
   |> Result.map_error ~f:(fun e -> Exception.get_ctor_string e)
-
-(* If successful, returns the # of edges from the dependency table that were written. *)
-(* TODO: write some other stats, e.g., the number of names, the number of errors, etc. *)
-let go (env : ServerEnv.env) (output_filename : string) :
-    (save_state_result, string) result =
-  Utils.try_with_stack (fun () -> save_state env output_filename)
-  |> Result.map_error ~f:(fun e -> Exception.get_ctor_string e)