c++|zcrx| add support for src port binding for the fizz client

Summary:
**WHAT**
adding support for the src port binding calculation before connecting the socket for the fizz client.

**WHY**
necessary for zcrx which fizz clients also want.

Reviewed By: spikeh

Differential Revision: D94591933

fbshipit-source-id: 2ab69583b985ec067df4ee32c45e54edd5e19810

Author: jlhe97

third-party/fizz/src/fizz/client/AsyncFizzClient-inl.h

@@ -117,7 +117,7 @@ void AsyncFizzClientT<SM>::connect(
     std::chrono::milliseconds totalTimeout,
     std::chrono::milliseconds socketTimeout,
     const folly::SocketOptionMap& options,
-    const folly::SocketAddress& bindAddr) {
+    const folly::AsyncSocketTransport::BindOptions& bindOptions) {
   DelayedDestruction::DestructorGuard dg(this);
 
   // shouldn't attempt to connect a second time
@@ -141,8 +141,11 @@ void AsyncFizzClientT<SM>::connect(
         connectAddr,
         static_cast<int>(socketTimeout.count()),
         options,
-        bindAddr);
+        bindOptions);
   } else {
+    if (auto* fd = std::get_if<folly::NetworkSocket>(&bindOptions)) {
+      folly::netops::close(*fd);
+    }
     folly::AsyncSocketException ase(
         folly::AsyncSocketException::BAD_ARGS,
         "could not find underlying socket");

third-party/fizz/src/fizz/client/AsyncFizzClient.h

@@ -87,7 +87,8 @@ class AsyncFizzClientT : public AsyncFizzBase,
       std::chrono::milliseconds totalTimeout = std::chrono::milliseconds(0),
       std::chrono::milliseconds socketTimeout = std::chrono::milliseconds(0),
       const folly::SocketOptionMap& options = folly::emptySocketOptionMap,
-      const folly::SocketAddress& bindAddr = folly::AsyncSocket::anyAddress());
+      const folly::AsyncSocketTransport::BindOptions& bindOptions =
+          folly::AsyncSocketTransport::anyAddress());
 
   /**
    * Variant of the TLS handshake connect() API above that uses the default

third-party/thrift/src/thrift/conformance/stresstest/client/ClientFactory.cpp

@@ -344,10 +344,11 @@ folly::AsyncTransport::UniquePtr createIOUringTLS(
 folly::AsyncTransport::UniquePtr createIOUringFizz(
     folly::EventBase* evb, const ClientConnectionConfig& cfg) {
   auto sock = new folly::AsyncIoUringSocket(evb, getIoUringSocketOptions(cfg));
+  folly::AsyncSocketTransport::BindOptions bindOptions =
+      folly::AsyncSocket::anyAddress();
   if (cfg.ioUringZcrx && cfg.ioUringZcrxSocketBind) {
-    // TODO: Fizz connect() does not support a boundFd parameter, so ZC-RX
-    // source port binding is not supported for the Fizz transport yet.
-    LOG(WARNING) << "io_zcrx_socket_bind is not supported with Fizz transport";
+    bindOptions = folly::AsyncIoUringSocketFactory::createBoundSocketForZcRx(
+        evb, cfg.serverHost.getIPAddress(), cfg.serverHost.getPort());
   }
   auto fizzClient = fizz::client::AsyncFizzClient::UniquePtr(
       new fizz::client::AsyncFizzClient(
@@ -360,7 +361,8 @@ folly::AsyncTransport::UniquePtr createIOUringFizz(
       {},
       std::chrono::milliseconds(0),
       std::chrono::milliseconds(0),
-      getSocketOptions(cfg));
+      getSocketOptions(cfg),
+      bindOptions);
   return fizzClient;
 }
 #endif