From 5ca214f7355bacd75aed41fade54badbd7fea705 Mon Sep 17 00:00:00 2001 From: Weibing Wang Date: Sun, 30 Jul 2017 19:52:39 +0800 Subject: [PATCH] optimize File::TranslatePathWithFileCache when FileCache is empty Change-Id: I7c6d98db13ea0dece449597347f31761486f1aa7 --- hphp/runtime/base/file.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hphp/runtime/base/file.cpp b/hphp/runtime/base/file.cpp index fd95126d064f0..60d6df0830720 100644 --- a/hphp/runtime/base/file.cpp +++ b/hphp/runtime/base/file.cpp @@ -124,8 +124,9 @@ String File::TranslatePathWithFileCache(const String& filename) { // canonicalize asserts that we don't have nulls String canonicalized = FileUtil::canonicalize(filename); String translated = TranslatePath(canonicalized); - if (!translated.empty() && access(translated.data(), F_OK) < 0 && - StaticContentCache::TheFileCache) { + if (!translated.empty() && + StaticContentCache::TheFileCache && + access(translated.data(), F_OK) < 0) { if (StaticContentCache::TheFileCache->exists(canonicalized.data(), false)) { // we use file cache's file name to make stat() work