From 10cb8262e1fcb74b23dd7b864c7db5117bd33f90 Mon Sep 17 00:00:00 2001 From: "Yang, Bo" Date: Wed, 5 Oct 2022 11:40:47 -0700 Subject: [PATCH 1/4] Run known failed tests with continue-on-error option --- .github/workflows/nix.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/nix.yml b/.github/workflows/nix.yml index 71b01b8b75bdda..21df1a73c1b700 100644 --- a/.github/workflows/nix.yml +++ b/.github/workflows/nix.yml @@ -144,6 +144,9 @@ jobs: - run: echo "HHVM_BIN=$(command -v hhvm)" >> "$GITHUB_ENV" - run: | "$HHVM_BIN" hphp/test/run.php -x hphp/test/github_excluded_tests all + - run: sed '/^ *#/d;s/#.*//' ./github_excluded_tests | xargs "$HHVM_BIN" ./run.php + working-directory: ./hphp/test + continue-on-error: true upload-deb: if: github.event_name == 'push' && github.ref_type == 'tag' runs-on: ubuntu-latest From 018e04fca5c7b5324759cad585ace61adc619dda Mon Sep 17 00:00:00 2001 From: "Yang, Bo" Date: Wed, 5 Oct 2022 12:11:08 -0700 Subject: [PATCH 2/4] Add write-to-checkout --- .github/workflows/nix.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nix.yml b/.github/workflows/nix.yml index 21df1a73c1b700..b152f22acf2d43 100644 --- a/.github/workflows/nix.yml +++ b/.github/workflows/nix.yml @@ -144,7 +144,7 @@ jobs: - run: echo "HHVM_BIN=$(command -v hhvm)" >> "$GITHUB_ENV" - run: | "$HHVM_BIN" hphp/test/run.php -x hphp/test/github_excluded_tests all - - run: sed '/^ *#/d;s/#.*//' ./github_excluded_tests | xargs "$HHVM_BIN" ./run.php + - run: sed 's/#.*//' ./github_excluded_tests | xargs "$HHVM_BIN" ./run.php --write-to-checkout working-directory: ./hphp/test continue-on-error: true upload-deb: From d4566d8acb53470340503a946c877097241c9df8 Mon Sep 17 00:00:00 2001 From: "Yang, Bo" Date: Wed, 5 Oct 2022 12:46:31 -0700 Subject: [PATCH 3/4] Print actual failed tests among known failed tests --- .github/workflows/nix.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/nix.yml b/.github/workflows/nix.yml index b152f22acf2d43..b3a58babce0bf9 100644 --- a/.github/workflows/nix.yml +++ b/.github/workflows/nix.yml @@ -144,9 +144,14 @@ jobs: - run: echo "HHVM_BIN=$(command -v hhvm)" >> "$GITHUB_ENV" - run: | "$HHVM_BIN" hphp/test/run.php -x hphp/test/github_excluded_tests all - - run: sed 's/#.*//' ./github_excluded_tests | xargs "$HHVM_BIN" ./run.php --write-to-checkout + - run: mkdir ./hphp/test/.known-failed-tests.tmp + - id: known-failed-tests working-directory: ./hphp/test continue-on-error: true + run: | + "$HHVM_BIN" ./run.php --working-dir ./.known-failed-tests.tmp $(sed 's/#.*//' ./github_excluded_tests) + - if: steps.configure-aws-credentials.outcome != 'success' + run: echo ./hphp/test/.known-failed-tests.tmp/hphp-test-*/test-failures upload-deb: if: github.event_name == 'push' && github.ref_type == 'tag' runs-on: ubuntu-latest From d2474ed49f02668cc6df6619c9a923c0c7366340 Mon Sep 17 00:00:00 2001 From: "Yang, Bo" Date: Wed, 5 Oct 2022 18:08:10 -0700 Subject: [PATCH 4/4] Update nix.yml --- .github/workflows/nix.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nix.yml b/.github/workflows/nix.yml index b3a58babce0bf9..08f84d1c8c83d5 100644 --- a/.github/workflows/nix.yml +++ b/.github/workflows/nix.yml @@ -151,7 +151,7 @@ jobs: run: | "$HHVM_BIN" ./run.php --working-dir ./.known-failed-tests.tmp $(sed 's/#.*//' ./github_excluded_tests) - if: steps.configure-aws-credentials.outcome != 'success' - run: echo ./hphp/test/.known-failed-tests.tmp/hphp-test-*/test-failures + run: cat ./hphp/test/.known-failed-tests.tmp/hphp-test-*/test-failures upload-deb: if: github.event_name == 'push' && github.ref_type == 'tag' runs-on: ubuntu-latest