Default operator== for VertexAttribute and VertexInputBinding in VertexInputState

Reviewed By: xiendong, corporateshark

Differential Revision: D93890658

fbshipit-source-id: 9e7d613b007580a9adbc28870c7bd87992f75bc3

Author: Ramesh Viswanathan

src/igl/VertexInputState.cpp

@@ -118,15 +118,6 @@ size_t VertexInputStateDesc::sizeForVertexAttributeFormat(VertexAttributeFormat
   IGL_UNREACHABLE_RETURN(0)
 }
 
-bool VertexInputBinding::operator!=(const VertexInputBinding& other) const {
-  return !(*this == other);
-}
-
-bool VertexInputBinding::operator==(const VertexInputBinding& other) const {
-  return other.sampleRate == sampleRate && other.sampleFunction == sampleFunction &&
-         other.stride == stride;
-}
-
 size_t std::hash<VertexInputBinding>::operator()(const VertexInputBinding& key) const {
   size_t hash = 0;
   hash ^= std::hash<int>()(static_cast<int>(key.sampleRate));
@@ -135,10 +126,6 @@ size_t std::hash<VertexInputBinding>::operator()(const VertexInputBinding& key)
   return hash;
 }
 
-bool VertexAttribute::operator!=(const VertexAttribute& other) const {
-  return !(*this == other);
-}
-
 size_t std::hash<VertexAttribute>::operator()(const VertexAttribute& key) const {
   size_t hash = 0;
   hash ^= std::hash<std::string>()(key.name);
@@ -149,11 +136,6 @@ size_t std::hash<VertexAttribute>::operator()(const VertexAttribute& key) const
   return hash;
 }
 
-bool VertexAttribute::operator==(const VertexAttribute& other) const {
-  return other.name == name && other.location == location && other.bufferIndex == bufferIndex &&
-         other.format == format && other.offset == offset;
-}
-
 bool VertexInputStateDesc::operator==(const VertexInputStateDesc& other) const {
   if (other.numAttributes != numAttributes || other.numInputBindings != numInputBindings) {
     return false;

src/igl/VertexInputState.h

@@ -107,8 +107,8 @@ struct VertexAttribute {
   std::string name; // GLES Only
   int location = -1; // Metal only
 
-  bool operator==(const VertexAttribute& other) const;
-  bool operator!=(const VertexAttribute& other) const;
+  bool operator==(const VertexAttribute& other) const = default;
+  bool operator!=(const VertexAttribute& other) const = default;
 };
 
 /**
@@ -119,8 +119,8 @@ struct VertexInputBinding {
   VertexSampleFunction sampleFunction = VertexSampleFunction::PerVertex;
   size_t sampleRate = 1;
 
-  bool operator==(const VertexInputBinding& other) const;
-  bool operator!=(const VertexInputBinding& other) const;
+  bool operator==(const VertexInputBinding& other) const = default;
+  bool operator!=(const VertexInputBinding& other) const = default;
 };
 
 /**