igl | metal | Prevent C50 HDR import texture-plane crashes

Reviewed By: prashanthsadasivan

Differential Revision: D114933597

fbshipit-source-id: 23603fda42e6ebf6a956455eca57083ead342687

Author: ramisbahi

src/igl/metal/PlatformDevice.mm

@@ -238,22 +238,40 @@ TextureFormat convertToTextureFormat(OSType pixelFormat, size_t planeIndex) {
                                                                       planeIndex,
                                                                       &cvMetalTexture);
     IGL_DEBUG_ASSERT(result == kCVReturnSuccess,
-                     "Failed to created Metal texture from PixelBuffer");
+                     "Failed to create Metal texture from pixel buffer");
 
     if (result != kCVReturnSuccess) {
-      NSLog(@"Failed to created Metal texture from PixelBuffer");
+      Result::setResult(
+          outResult,
+          Result::Code::RuntimeError,
+          "Failed to create Metal texture from pixel buffer: " + std::to_string(result));
       return nullptr;
     }
 
     id<MTLTexture> metalTexture = CVMetalTextureGetTexture(cvMetalTexture);
     CVBufferRelease(cvMetalTexture);
     cvMetalTexture = nullptr;
 
+    if (metalTexture == nil) {
+      Result::setResult(
+          outResult, Result::Code::RuntimeError, "CoreVideo returned an empty Metal texture");
+      return nullptr;
+    }
+
     resultTexture = std::make_unique<Texture>(metalTexture, device_);
     if (auto resourceTracker = device_.getResourceTracker()) {
       resultTexture->initResourceTracker(resourceTracker);
     }
+  } else {
+    Result::setResult(
+        outResult, Result::Code::RuntimeError, "Failed to get the Metal texture cache");
+    return nullptr;
   }
+#else
+  Result::setResult(outResult,
+                    Result::Code::Unsupported,
+                    "Metal pixel-buffer textures are not supported on this target");
+  return nullptr;
 #endif
 
   Result::setOk(outResult);

src/igl/tests/metal/Texture.mm

@@ -381,6 +381,31 @@ void TearDown() override {}
   ASSERT_EQ(result.isOk(), false) << result.message.c_str();
 }
 
+TEST_F(TextureMTLTest, createTextureFromNativePixelBufferWithInvalidPlaneSetsError) {
+  CVPixelBufferRef pixelBuffer = nullptr;
+  NSDictionary* bufferAttributes = @{
+    (NSString*)kCVPixelBufferIOSurfacePropertiesKey : @{},
+    (NSString*)kCVPixelBufferMetalCompatibilityKey : @YES,
+  };
+  const CVReturn pixelBufferResult =
+      CVPixelBufferCreate(kCFAllocatorDefault,
+                          100,
+                          100,
+                          kCVPixelFormatType_32BGRA,
+                          (__bridge CFDictionaryRef)(bufferAttributes),
+                          &pixelBuffer);
+  ASSERT_EQ(pixelBufferResult, kCVReturnSuccess);
+
+  auto* platformDevice = device_->getPlatformDevice<igl::metal::PlatformDevice>();
+  Result result;
+  auto texture = platformDevice->createTextureFromNativePixelBuffer(
+      pixelBuffer, TextureFormat::BGRA_UNorm8, 1, &result);
+  CVPixelBufferRelease(pixelBuffer);
+
+  EXPECT_EQ(texture, nullptr);
+  EXPECT_FALSE(result.isOk());
+}
+
 TEST_F(TextureMTLTest, ConvertTextureFormats) {
   const std::vector<TextureFormat> inputFormats = {
       TextureFormat::A_UNorm8,