igl | Complete the manifest validator against the migrated corpus: coverage, layout and reader-seam gates

Differential Revision: D115582468

fbshipit-source-id: 04930ea2132c2b4c60cb160eab854ce142cc9452

Author: Michael Murray

src/igl/tests/Blending.cpp

@@ -262,6 +262,10 @@ TEST_F(BlendingTest, RGBASrcAndDstAddTest) {
   //----------------------
   // Read back framebuffer
   //----------------------
+  const auto dimensions = framebuffer_->getColorAttachment(0)->getDimensions();
+  ASSERT_EQ(dimensions.width, static_cast<uint32_t>(OFFSCREEN_TEX_WIDTH));
+  ASSERT_EQ(dimensions.height, static_cast<uint32_t>(OFFSCREEN_TEX_HEIGHT));
+
   auto pixels = std::vector<uint32_t>(OFFSCREEN_TEX_WIDTH * OFFSCREEN_TEX_HEIGHT);
 
   framebuffer_->copyBytesColorAttachment(*cmdQueue_, 0, pixels.data(), rangeDesc_);

src/igl/tests/Framebuffer.cpp

@@ -265,6 +265,10 @@ TEST_F(FramebufferTest, Clear) {
   //----------------------
   // Read back framebuffer
   //----------------------
+  const auto dimensions = framebuffer_->getColorAttachment(0)->getDimensions();
+  ASSERT_EQ(dimensions.width, static_cast<uint32_t>(kOffscreenRtWidth));
+  ASSERT_EQ(dimensions.height, static_cast<uint32_t>(kOffscreenRtHeight));
+
   auto pixels = std::vector<uint32_t>(kOffscreenRtWidth * kOffscreenRtWidth);
   auto pixelsDepth = std::vector<float>(kOffscreenRtWidth * kOffscreenRtWidth);
   auto pixelsStencil = std::vector<uint8_t>(kOffscreenRtWidth * kOffscreenRtWidth);
@@ -444,6 +448,14 @@ TEST_F(FramebufferTest, blitFramebufferColor) {
     //----------------------
     // Read back framebuffer
     //----------------------
+    const auto dimensions = framebuffer_->getColorAttachment(0)->getDimensions();
+    ASSERT_EQ(dimensions.width, static_cast<uint32_t>(kOffscreenRtWidth));
+    ASSERT_EQ(dimensions.height, static_cast<uint32_t>(kOffscreenRtHeight));
+
+    const auto dimensions2 = framebuffer2->getColorAttachment(0)->getDimensions();
+    ASSERT_EQ(dimensions2.width, static_cast<uint32_t>(kOffscreenRtWidth));
+    ASSERT_EQ(dimensions2.height, static_cast<uint32_t>(kOffscreenRtHeight));
+
     auto pixels = std::vector<uint32_t>(kOffscreenRtWidth * kOffscreenRtWidth);
 
     framebuffer_->copyBytesColorAttachment(*cmdQueue_, 0, pixels.data(), rangeDesc);
@@ -696,6 +708,10 @@ TEST_F(FramebufferTest, GetColorAttachmentTest) {
   //----------------------
   // Read back framebuffer
   //----------------------
+  const auto dimensions = framebuffer_->getColorAttachment(0)->getDimensions();
+  ASSERT_EQ(dimensions.width, static_cast<uint32_t>(textureWidth));
+  ASSERT_EQ(dimensions.height, static_cast<uint32_t>(textureHeight));
+
   const int outputImageWidth = textureWidth + 2;
   const int outputImageHeight = textureHeight;
   const int outputElementPerRow = outputImageWidth * channelCount;

src/igl/tests/Multiview.cpp

@@ -307,6 +307,10 @@ TEST_F(MultiviewTest, SinglePassStereo) {
   //----------------------
   // Read back framebuffer
   //----------------------
+  const auto dimensions = framebuffer_->getColorAttachment(0)->getDimensions();
+  EXPECT_EQ(dimensions.width, static_cast<uint32_t>(kOffScreenWidth));
+  EXPECT_EQ(dimensions.height, static_cast<uint32_t>(kOffScreenHeight));
+
   auto pixels = std::vector<uint32_t>(kOffScreenWidth * kOffScreenHeight);
   auto rangeDesc = TextureRangeDesc::new2D(0, 0, kOffScreenWidth, kOffScreenHeight);
 

src/igl/tests/RenderCommandEncoder.cpp

@@ -260,6 +260,10 @@ class RenderCommandEncoderTest : public ::testing::Test {
   }
 
   void verifyFrameBuffer(const std::vector<uint32_t>& expectedPixels) {
+    const auto dimensions = framebuffer_->getColorAttachment(0)->getDimensions();
+    ASSERT_EQ(dimensions.width, static_cast<uint32_t>(OFFSCREEN_RT_WIDTH));
+    ASSERT_EQ(dimensions.height, static_cast<uint32_t>(OFFSCREEN_RT_HEIGHT));
+
     auto pixels =
         std::vector<uint32_t>(static_cast<size_t>(OFFSCREEN_RT_WIDTH * OFFSCREEN_RT_WIDTH));
     framebuffer_->copyBytesColorAttachment(

src/igl/tests/Texture.cpp

@@ -369,6 +369,8 @@ constexpr std::array<std::pair<const void*, uint32_t>, 4> kPixelAlignments = {
 TEST_F(TextureTest, RepackData) {
   const auto properties = TextureFormatProperties::fromTextureFormat(TextureFormat::RGBA_UNorm8);
   const auto range = TextureRangeDesc::new2D(0, 0, kAlignedPixelsWidth, kAlignedPixelsHeight);
+  EXPECT_EQ(range.width, kAlignedPixelsWidth);
+  EXPECT_EQ(range.height, kAlignedPixelsHeight);
 
   for (const auto& [data, bytesPerRow] : kPixelAlignments) {
     const size_t alignedSize =

src/igl/tests/iglu/TextureAccessor.cpp

@@ -75,6 +75,10 @@ class TextureAccessorTest : public ::testing::Test {
 // Tests synchronous texture readback
 //
 TEST_F(TextureAccessorTest, testRequestAndGetBytesSync) {
+  const auto dimensions = texture_->getDimensions();
+  ASSERT_EQ(dimensions.width, static_cast<uint32_t>(OFFSCREEN_TEX_WIDTH));
+  ASSERT_EQ(dimensions.height, static_cast<uint32_t>(OFFSCREEN_TEX_HEIGHT));
+
   ASSERT_NO_THROW(textureAccessor_ =
                       iglu::textureaccessor::TextureAccessorFactory::createTextureAccessor(
                           iglDev_->getBackendType(), texture_, *iglDev_));
@@ -102,6 +106,10 @@ TEST_F(TextureAccessorTest, testRequestAndGetBytesSync) {
 }
 
 TEST_F(TextureAccessorTest, reuseTextureAccessor) {
+  const auto dimensions = texture_->getDimensions();
+  ASSERT_EQ(dimensions.width, static_cast<uint32_t>(OFFSCREEN_TEX_WIDTH));
+  ASSERT_EQ(dimensions.height, static_cast<uint32_t>(OFFSCREEN_TEX_HEIGHT));
+
   ASSERT_NO_THROW(textureAccessor_ =
                       iglu::textureaccessor::TextureAccessorFactory::createTextureAccessor(
                           iglDev_->getBackendType(), texture_, *iglDev_));

src/igl/tests/iglu/TextureAccessorDesignatedInit.cpp

@@ -132,6 +132,10 @@ TEST_F(TextureAccessorDesignatedInitTest, DesignatedInitMatchesFieldByField) {
 // verify pixel data matches what was uploaded.
 //
 TEST_F(TextureAccessorDesignatedInitTest, TextureAccessorReadbackWithDesignatedInit) {
+  const auto dimensions = texture_->getDimensions();
+  ASSERT_EQ(dimensions.width, static_cast<uint32_t>(OFFSCREEN_TEX_WIDTH));
+  ASSERT_EQ(dimensions.height, static_cast<uint32_t>(OFFSCREEN_TEX_HEIGHT));
+
   auto textureAccessor = iglu::textureaccessor::TextureAccessorFactory::createTextureAccessor(
       iglDev_->getBackendType(), texture_, *iglDev_);
   ASSERT_TRUE(textureAccessor != nullptr);

src/igl/tests/metal/RenderPass.mm

@@ -175,6 +175,10 @@ void TearDown() override {}
   commandBuffer_->waitUntilCompleted();
 
   // Read back and verify the clear color
+  const auto dimensions = framebuffer->getColorAttachment(0)->getDimensions();
+  ASSERT_EQ(dimensions.width, static_cast<uint32_t>(RP_TEX_WIDTH));
+  ASSERT_EQ(dimensions.height, static_cast<uint32_t>(RP_TEX_HEIGHT));
+
   const size_t bytesPerPixel = 4; // RGBA_UNorm8
   const size_t rowBytes = RP_TEX_WIDTH * bytesPerPixel;
   std::vector<uint8_t> pixels(RP_TEX_WIDTH * RP_TEX_HEIGHT * bytesPerPixel);

src/igl/tests/ogl/UniformBuffer.cpp

@@ -766,6 +766,10 @@ TEST_F(UniformBufferTest, UniformBufferBinding) {
   //----------------------
   // Read back framebuffer
   //----------------------
+  const auto dimensions = framebuffer_->getColorAttachment(0)->getDimensions();
+  ASSERT_EQ(dimensions.width, static_cast<uint32_t>(kOffscreenTexWidth));
+  ASSERT_EQ(dimensions.height, static_cast<uint32_t>(kOffscreenTexHeight));
+
   auto pixels = std::vector<uint32_t>(kOffscreenTexWidth * kOffscreenTexHeight);
 
   framebuffer_->copyBytesColorAttachment(*cmdQueue_, 0, pixels.data(), rangeDesc);
@@ -1168,6 +1172,10 @@ TEST_F(UniformBufferTest, UniformArrayBinding) {
   //----------------------
   // Read back framebuffer
   //----------------------
+  const auto dimensions = framebuffer_->getColorAttachment(0)->getDimensions();
+  ASSERT_EQ(dimensions.width, static_cast<uint32_t>(kOffscreenTexWidth));
+  ASSERT_EQ(dimensions.height, static_cast<uint32_t>(kOffscreenTexHeight));
+
   auto pixels = std::vector<uint32_t>(kOffscreenTexWidth * kOffscreenTexHeight);
 
   framebuffer_->copyBytesColorAttachment(*cmdQueue_, 0, pixels.data(), rangeDesc);