[llvm] fix memory leak in patch

Summary: `llvm_di_subprogram_get_type` allocates and then frees an array of pointers. This array is populated with the return values of `getTypeName`, but these were never freed and leaked.

Reviewed By: dulmarod

Differential Revision: D89554598

fbshipit-source-id: 14864b0b518b15dfca37604a36ec562562248df2

Author: ngorogiannis

dependencies/llvm/opam-repository/packages/conf-llvm/conf-llvm-static.19/opam

@@ -27,8 +27,6 @@ flags: conf
 extra-source "configure.sh" {
   src:
     "https://raw.githubusercontent.com/ocaml/opam-source-archives/refs/heads/main/patches/conf-llvm/configure.sh.18"
-  checksum: [
+  checksum:
     "sha256=3675ad30b93aab67f1d57aa7c700800a3b5954768610ef9ef29bba7483f16936"
-    "md5=409c0a03dcea76a45719b80a06e2bd71"
-  ]
 }

dependencies/llvm/opam-repository/packages/llvm/llvm.19-static-infer/opam

@@ -58,10 +58,8 @@ url {
 extra-source "0_AddOCaml.cmake.patch" {
   src:
     "https://raw.githubusercontent.com/ocaml/opam-source-archives/main/patches/llvm/AddOCaml.cmake.patch.18"
-    checksum: [
-  "sha256=a532adaa6938818fbd7f5a49d4de21c0a2d240ecb91636a76b2f745b4b8cb58f"
-  "md5=432ec376b6ffbac44e640c8fb659a7df"
-]
+  checksum:
+    "sha256=a532adaa6938818fbd7f5a49d4de21c0a2d240ecb91636a76b2f745b4b8cb58f"
 }
 extra-source "2_add-LLVMGetAtomicRMWBinOp.patch" {
   src: "dependencies/llvm/patches/2_add-LLVMGetAtomicRMWBinOp.patch"
@@ -85,6 +83,6 @@ extra-source "5_getAllocatedType.patch" {
 }
 extra-source "6_LLVMExtractDISubprogramType.patch" {
   src: "dependencies/llvm/patches/6_LLVMExtractDISubprogramType.patch"
-  checksum: [ "sha256=87e7376b7907435d69e8192c1cdccacb058e7ea0cf7c597acb1165dad700c937"]
+  checksum: [ "sha256=3590818da43426962c95a86515d7e2e2e78304f4d906c2d096e9892ea0120754"]
 }
 extra-files: ["install.sh" "sha256=9d4a83c6b661ca4a80289d8a5bc0cddd6dd5d7e25ca9d61a8c358d801e2b8cdf"]

dependencies/llvm/patches/6_LLVMExtractDISubprogramType.patch

@@ -102,7 +102,7 @@ index ba4a9cbde37a..95f6c18b4bb0 100644
  }
 
  value llvm_dibuild_create_compile_unit_bytecode(value *argv, int argn) {
-@@ -326,6 +336,19 @@ value llvm_di_location_get_line(value Location) {
+@@ -326,6 +336,20 @@ value llvm_di_location_get_line(value Location) {
    return Val_int(LLVMDILocationGetLine(Metadata_val(Location)));
  }
 
@@ -114,6 +114,7 @@ index ba4a9cbde37a..95f6c18b4bb0 100644
 +  for (unsigned i = 0; i < Length; ++i) {
 +    size_t len = strlen(c_array[i]);
 +    Field(Array, i) = cstr_to_string(c_array[i], len);
++    free(c_array[i]);
 +  }
 +  free(c_array);
 +  return Array;

opam/llvm.opam.locked

@@ -122,7 +122,7 @@ extra-source "6_LLVMExtractDISubprogramType.patch" {
   src:
     "dependencies/llvm/patches/6_LLVMExtractDISubprogramType.patch"
   checksum:
-    "sha256=87e7376b7907435d69e8192c1cdccacb058e7ea0cf7c597acb1165dad700c937"
+    "sha256=3590818da43426962c95a86515d7e2e2e78304f4d906c2d096e9892ea0120754"
 }
 extra-files: [
   "install.sh"
@@ -131,8 +131,6 @@ extra-files: [
 extra-source "0_AddOCaml.cmake.patch" {
   src:
     "https://raw.githubusercontent.com/ocaml/opam-source-archives/main/patches/llvm/AddOCaml.cmake.patch.18"
-  checksum: [
+  checksum:
     "sha256=a532adaa6938818fbd7f5a49d4de21c0a2d240ecb91636a76b2f745b4b8cb58f"
-    "md5=432ec376b6ffbac44e640c8fb659a7df"
-  ]
 }