From b70fe7939855a9b13eced7c62a4beddbe4185cc1 Mon Sep 17 00:00:00 2001 From: James Abels <30417590+abelsj60@users.noreply.github.com> Date: Wed, 1 Feb 2023 19:56:23 -0500 Subject: [PATCH] Fix is selected noop (#3805) --- .../lexical-react/src/useLexicalNodeSelection.ts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/lexical-react/src/useLexicalNodeSelection.ts b/packages/lexical-react/src/useLexicalNodeSelection.ts index fa140d072c6..3da347064d6 100644 --- a/packages/lexical-react/src/useLexicalNodeSelection.ts +++ b/packages/lexical-react/src/useLexicalNodeSelection.ts @@ -40,9 +40,17 @@ export function useLexicalNodeSelection( ); useEffect(() => { - return editor.registerUpdateListener(() => { - setIsSelected(isNodeSelected(editor, key)); + let isMounted = true; + const unregister = editor.registerUpdateListener(() => { + if (isMounted) { + setIsSelected(isNodeSelected(editor, key)); + } }); + + return () => { + isMounted = false; + unregister(); + }; }, [editor, key]); const setSelected = useCallback(