Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pasting inline code blocks #2607

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fix pasting inline code blocks #2607

merged 1 commit into from
Jul 7, 2022

Conversation

fantactuka
Copy link
Contributor

Fixes #2605

@vercel
Copy link

vercel bot commented Jul 6, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Jul 6, 2022 at 11:53PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Jul 6, 2022 at 11:53PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 6, 2022
@acywatson
Copy link
Contributor

Does it also close this: #2187

and fix this: #2049 ?

@fantactuka fantactuka merged commit 85f1067 into main Jul 7, 2022
This was referenced Jul 7, 2022
Closed
Closed
Closed
@caitsithlord
Copy link

This may be a result of a different commit and may be intentional, but pasting things from dark theme gives a dark background to the text now

Screen.Recording.2022-07-07.at.2.47.22.PM.mov

@acywatson
Copy link
Contributor

This may be a result of a different commit and may be intentional, but pasting things from dark theme gives a dark background to the text now

Screen.Recording.2022-07-07.at.2.47.22.PM.mov

Yea, I'm pretty sure this came from a different commit that implemented support for "background-color" inline styles on pasted HTML. Not sure if this is the behavior we want. If so, we should probably at least allow "paste without formatting" or "paste without styles"

@trueadm trueadm deleted the copy-paste-inline-code branch December 18, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acywatson acywatson acywatson approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Copy/Paste Pasting on Linebreak node moves text multiple lines
4 participants
@fantactuka @acywatson @caitsithlord @facebook-github-bot