Bug: Collapsed selections expand to nearest HTML tags on link insertion

[geryogam]

Lexical version: v0.12.4

Steps to reproduce

1. Go to https://playground.lexical.dev/.
2. Click (not select) on the word ‘typing’ (you should see the text cursor blinking, a.k.a. a collapsed selection).
3. Click on the ‘Insert link’ button.

The current behavior

The collapsed selection expands to the nearest HTML tags:

. Try typing in

The expected behavior

The collapsed selection should only expand to the current word:

typing

or (another solution) nothing should happen at all for collapsed selections.

[acywatson]

This is reproducible. I think it's a playground-only issue though.

[geryogam]

It is actually not playground specific, it is a bug in the implementation of the toggleLink function.

[acywatson]

It is actually not playground specific, it is a bug in the implementation of the toggleLink function.

Nice! Since you've identified the source of the bug, a PR would be most welcome :)

[bhavyakaria]

@acywatson would like to work on this.

What should be the expected behaviour here?

1. Select the current word on which the cursor is present. And no selection if cursor doesn't have any text around it.
2. Irrespective of the cursor position, nothing should be selected and converted to link.

[acywatson]

@acywatson would like to work on this.

What should be the expected behaviour here?

1. Select the current word on which the cursor is present. And no selection if cursor doesn't have any text around it.
2. Irrespective of the cursor position, nothing should be selected and converted to link.

Thanks @bhavyakaria!

I think 2 is the right way to go. Trying to find the word boundary within a TextNode is going to involve some heuristics that will probably have edge cases. I prefer ignoring a collapsed selection here, rather than adopting a heuristic that assumes user intent.