You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
During the last QE where I was testing the Primitive scroll someone reported that the scroll is taking too much space.
https://fb.workplace.com/groups/litho.support/permalink/3981699508818054/
After investigating it, what seems to be wrong is again the measuring logic...
We tried to create a copy of [ViewGroup.getChildMeasureSpec](https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/view/ViewGroup.java#7030)
but I didn't include the specMode variants.
Before the change:
**Spec:** widthSpec from spec **[1080, AT_MOST]**
**Primitive:**
- sizeConstraints width mode **AT_MOST** SizeConstraints[**minWidth = 0, maxWidth = 1080**, minHeight = 0, maxHeight = 1647] (what we are getting in LayoutScope.layout)
- childConstraints width **[1080, EXACTLY]** SizeConstraints **[minWidth = 1080, maxWidth = 1080**, minHeight = 0, maxHeight = Infinity] (this is the result of our getChildMeasureSpec primitive call)
I published next diff with force to test and let's see if all of the e2e and tests will pass
<fingers crossed>
Reviewed By: adityasharat
Differential Revision: D68208796
fbshipit-source-id: a3f054da61afaaad451ad7577d5a115fce0fad65
0 commit comments