Enforce consistent-test-it lint rule

Summary:
Enable [jest/consistent-test-it](https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/consistent-test-it.md) rule and align codebase using `eslint --fix`.

Motivation:
- `test` is the [canonically documented](https://jestjs.io/docs/api#testname-fn-timeout) function name in Jest.
- Marginally more self-describing.

Changelog: [Internal]

Reviewed By: vzaidman

Differential Revision: D63384640

fbshipit-source-id: 1b86c275954fe851ca8d6c2197d0a4f47baf5d1e

Author: huntie

packages/buck-worker-tool/src/__tests__/worker-test.js

@@ -51,13 +51,13 @@ describe('Buck worker:', () => {
   });
 
   describe('handshake:', () => {
-    it('responds to a correct handshake', () => {
+    test('responds to a correct handshake', () => {
       inStream.write(handshake());
 
       return end().then(data => expect(data).toEqual([handshake()]));
     });
 
-    it('responds to a handshake with a `protocol_version` different from "0"', () => {
+    test('responds to a handshake with a `protocol_version` different from "0"', () => {
       inStream.write({
         id: 0,
         type: 'handshake',
@@ -76,7 +76,7 @@ describe('Buck worker:', () => {
       );
     });
 
-    it('errors for a second handshake', () => {
+    test('errors for a second handshake', () => {
       inStream.write(handshake());
       inStream.write(handshake(1));
 
@@ -90,7 +90,7 @@ describe('Buck worker:', () => {
     });
   });
 
-  it('errors for unknown message types', () => {
+  test('errors for unknown message types', () => {
     inStream.write(handshake());
     inStream.write({id: 1, type: 'arbitrary'});
     return end().then(([, response]) =>
@@ -165,7 +165,7 @@ describe('Buck worker:', () => {
       return Promise.all(streamClosedPromises);
     });
 
-    it('errors if `args_path` cannot be opened', () => {
+    test('errors if `args_path` cannot be opened', () => {
       mockFiles({some: {'args-path': undefined}});
       inStream.write(command({id: 5, args_path: '/some/args-path'}));
       return end(2).then(([, response]) => {
@@ -177,7 +177,7 @@ describe('Buck worker:', () => {
       });
     });
 
-    it('errors if `stdout_path` cannot be opened', () => {
+    test('errors if `stdout_path` cannot be opened', () => {
       const path = '/does/not/exist';
       inStream.write(command({id: 5, stdout_path: path}));
       return end(2).then(([, response]) => {
@@ -189,7 +189,7 @@ describe('Buck worker:', () => {
       });
     });
 
-    it('errors if `stderr_path` cannot be opened', () => {
+    test('errors if `stderr_path` cannot be opened', () => {
       const path = '/does/not/exist';
       inStream.write(command({id: 5, stderr_path: path}));
       return end(2).then(([, response]) => {
@@ -201,7 +201,7 @@ describe('Buck worker:', () => {
       });
     });
 
-    it('errors for unspecified commands', () => {
+    test('errors for unspecified commands', () => {
       mockFiles({
         arbitrary: {
           file: '--flag-without-preceding-command',
@@ -223,7 +223,7 @@ describe('Buck worker:', () => {
       );
     });
 
-    it('errors for empty commands', () => {
+    test('errors for empty commands', () => {
       mockFiles({
         arbitrary: {
           file: '',
@@ -245,7 +245,7 @@ describe('Buck worker:', () => {
       );
     });
 
-    it('errors for unknown commands', () => {
+    test('errors for unknown commands', () => {
       mockFiles({
         arbitrary: {
           file: 'arbitrary',
@@ -267,7 +267,7 @@ describe('Buck worker:', () => {
       );
     });
 
-    it('errors if no `args_path` is specified', () => {
+    test('errors if no `args_path` is specified', () => {
       inStream.write({
         id: 1,
         type: 'command',
@@ -283,7 +283,7 @@ describe('Buck worker:', () => {
       );
     });
 
-    it('errors if no `stdout_path` is specified', () => {
+    test('errors if no `stdout_path` is specified', () => {
       inStream.write({
         id: 1,
         type: 'command',
@@ -299,7 +299,7 @@ describe('Buck worker:', () => {
       );
     });
 
-    it('errors if no `stderr_path` is specified', () => {
+    test('errors if no `stderr_path` is specified', () => {
       inStream.write({
         id: 1,
         type: 'command',
@@ -315,7 +315,7 @@ describe('Buck worker:', () => {
       );
     });
 
-    it('passes arguments to an existing command', async () => {
+    test('passes arguments to an existing command', async () => {
       commands.transform = jest.fn();
       const args = 'foo  bar baz\tmore';
       mockFiles({
@@ -338,7 +338,7 @@ describe('Buck worker:', () => {
       );
     });
 
-    it('passes JSON/structured arguments to an existing command', async () => {
+    test('passes JSON/structured arguments to an existing command', async () => {
       commands.transform = jest.fn();
       const args = {foo: 'bar', baz: 'glo'};
       mockFiles({
@@ -357,7 +357,7 @@ describe('Buck worker:', () => {
       expect(commands.transform).toBeCalledWith([], args, anything());
     });
 
-    it('passes a console object to the command', () => {
+    test('passes a console object to the command', () => {
       mockFiles({
         args: 'transform',
         stdio: {},
@@ -385,7 +385,7 @@ describe('Buck worker:', () => {
       });
     });
 
-    it('responds with success if the command finishes succesfully', () => {
+    test('responds with success if the command finishes succesfully', () => {
       commands.transform = (args, _) => {};
       mockFiles({path: {to: {args: 'transform'}}});
       inStream.write(
@@ -404,7 +404,7 @@ describe('Buck worker:', () => {
       );
     });
 
-    it('responds with error if the command does not exist', async () => {
+    test('responds with error if the command does not exist', async () => {
       commands.transform = jest.fn(() => Promise.resolve());
       mockFiles({path: {to: {args: 'inexistent_command'}}});
       inStream.write(
@@ -425,7 +425,7 @@ describe('Buck worker:', () => {
       );
     });
 
-    it('responds with error if the command errors asynchronously', () => {
+    test('responds with error if the command errors asynchronously', () => {
       commands.transform = jest.fn((args, _, callback) =>
         Promise.reject(new Error('arbitrary')),
       );
@@ -446,7 +446,7 @@ describe('Buck worker:', () => {
       );
     });
 
-    it('responds with error if the command throws synchronously', () => {
+    test('responds with error if the command throws synchronously', () => {
       commands.transform = (args, _) => {
         throw new Error('arbitrary');
       };

packages/metro-babel-register/src/__tests__/parses-without-transpilation-test.js

@@ -14,7 +14,7 @@
 const {promises: fsPromises} = require('fs');
 const vm = require('vm');
 
-it('can be loaded directly without transpilation', async () => {
+test('can be loaded directly without transpilation', async () => {
   const code = await fsPromises.readFile(
     require.resolve('../babel-register'),
     'utf8',

packages/metro-babel-transformer/src/__tests__/transform-test.js

@@ -15,7 +15,7 @@ const path = require('path');
 
 const PROJECT_ROOT = path.sep === '/' ? '/my/project' : 'C:\\my\\project';
 
-it('exposes the correct absolute path to a source file to plugins', () => {
+test('exposes the correct absolute path to a source file to plugins', () => {
   let visitorFilename;
   let pluginCwd;
   transform({

packages/metro-cache/src/__tests__/Cache-test.js

@@ -47,7 +47,7 @@ describe('Cache', () => {
     jest.resetModules().restoreAllMocks();
   });
 
-  it('returns null when no result is found', async () => {
+  test('returns null when no result is found', async () => {
     const store1 = createStore();
     const store2 = createStore();
     const cache = new Cache([store1, store2]);
@@ -60,7 +60,7 @@ describe('Cache', () => {
     expect(store2.get).toHaveBeenCalledTimes(1);
   });
 
-  it('sequentially searches up until it finds a valid result', async () => {
+  test('sequentially searches up until it finds a valid result', async () => {
     const store1 = createStore();
     const store2 = createStore();
     const store3 = createStore();
@@ -77,7 +77,7 @@ describe('Cache', () => {
     expect(store3.get).not.toHaveBeenCalled();
   });
 
-  it('skips all cache stores when a hit is produced, based on the same key', async () => {
+  test('skips all cache stores when a hit is produced, based on the same key', async () => {
     const store1 = createStore();
     const store2 = createStore();
     const store3 = createStore();
@@ -94,7 +94,7 @@ describe('Cache', () => {
     expect(store3.set).not.toHaveBeenCalled();
   });
 
-  it('awaits for promises on stores, even if they return undefined', async () => {
+  test('awaits for promises on stores, even if they return undefined', async () => {
     let resolve;
 
     const store1 = createStore();
@@ -120,7 +120,7 @@ describe('Cache', () => {
     expect(store2.get).toHaveBeenCalledTimes(1);
   });
 
-  it('throws all errors on a buggy store set', async () => {
+  test('throws all errors on a buggy store set', async () => {
     const goodStore = createStore('GoodStore');
     const badAsyncStore = createStore('BadAsyncStore');
     const badSyncStore = createStore('BadSyncStore');
@@ -150,7 +150,7 @@ describe('Cache', () => {
     expect(error?.errors[1].cause).toEqual(RangeError('foo'));
   });
 
-  it('throws on a buggy store get', async () => {
+  test('throws on a buggy store get', async () => {
     const store1 = createStore();
     const store2 = createStore();
     const cache = new Cache([store1, store2]);
@@ -168,7 +168,7 @@ describe('Cache', () => {
     expect(error).toBeInstanceOf(TypeError);
   });
 
-  it('logs the right messages when getting without errors', async () => {
+  test('logs the right messages when getting without errors', async () => {
     const store1 = createStore('Local');
     const store2 = createStore('Network');
     const cache = new Cache([store1, store2]);
@@ -188,7 +188,7 @@ describe('Cache', () => {
     ]);
   });
 
-  it('logs the right messages when getting with errors', async () => {
+  test('logs the right messages when getting with errors', async () => {
     const store1 = createStore('Local');
     const store2 = createStore('Network');
     const cache = new Cache([store1, store2]);
@@ -212,7 +212,7 @@ describe('Cache', () => {
     ]);
   });
 
-  it('logs the right messages when setting', async () => {
+  test('logs the right messages when setting', async () => {
     const store1 = createStore('Local');
     const store2 = createStore('Network');
     const cache = new Cache([store1, store2]);
@@ -228,7 +228,7 @@ describe('Cache', () => {
   });
 
   describe('disabled cache', () => {
-    it('returns null for reads', async () => {
+    test('returns null for reads', async () => {
       // $FlowFixMe[missing-empty-array-annot]
       const cache = new Cache([]);
 
@@ -237,7 +237,7 @@ describe('Cache', () => {
       expect(result).toBe(null);
     });
 
-    it('ignores writes', async () => {
+    test('ignores writes', async () => {
       // $FlowFixMe[missing-empty-array-annot]
       const cache = new Cache([]);
 
@@ -247,7 +247,7 @@ describe('Cache', () => {
       expect(result).toBe(null);
     });
 
-    it('logs nothing', async () => {
+    test('logs nothing', async () => {
       // $FlowFixMe[missing-empty-array-annot]
       const cache = new Cache([]);
 

packages/metro-cache/src/__tests__/stableHash-test.js

@@ -13,7 +13,7 @@
 const stableHash = require('../stableHash');
 
 describe('stableHash', () => {
-  it('ensures that the hash implementation supports switched order properties', () => {
+  test('ensures that the hash implementation supports switched order properties', () => {
     const sortedHash = stableHash({
       a: 3,
       b: 4,

packages/metro-cache/src/stores/__tests__/AutoCleanFileStore-test.js

@@ -26,7 +26,7 @@ describe('AutoCleanFileStore', () => {
     jest.spyOn(fs, 'unlinkSync');
   });
 
-  it('sets and writes into the cache', async () => {
+  test('sets and writes into the cache', async () => {
     // $FlowFixMe[underconstrained-implicit-instantiation]
     const fileStore = new AutoCleanFileStore({
       root: '/root',
@@ -51,7 +51,7 @@ describe('AutoCleanFileStore', () => {
     expect(await fileStore.get(cache)).toEqual(null);
   });
 
-  it('returns null when reading a non-existing file', async () => {
+  test('returns null when reading a non-existing file', async () => {
     // $FlowFixMe[underconstrained-implicit-instantiation]
     const fileStore = new AutoCleanFileStore({root: '/root'});
     const cache = Buffer.from([0xfa, 0xce, 0xb0, 0x0c]);

packages/metro-cache/src/stores/__tests__/FileStore-test.js

@@ -27,22 +27,22 @@ describe('FileStore', () => {
     jest.spyOn(fs, 'unlinkSync');
   });
 
-  it('sets and writes into the cache', async () => {
+  test('sets and writes into the cache', async () => {
     const fileStore = new FileStore({root: '/root'});
     const cache = Buffer.from([0xfa, 0xce, 0xb0, 0x0c]);
 
     await fileStore.set(cache, {foo: 42});
     expect(await fileStore.get(cache)).toEqual({foo: 42});
   });
 
-  it('returns null when reading a non-existing file', async () => {
+  test('returns null when reading a non-existing file', async () => {
     const fileStore = new FileStore({root: '/root'});
     const cache = Buffer.from([0xfa, 0xce, 0xb0, 0x0c]);
 
     expect(await fileStore.get(cache)).toEqual(null);
   });
 
-  it('returns null when reading a empty file', async () => {
+  test('returns null when reading a empty file', async () => {
     const fileStore = new FileStore({root: '/root'});
     const cache = Buffer.from([0xfa, 0xce, 0xb0, 0x0c]);
     const filePath = fileStore._getFilePath(cache);
@@ -51,7 +51,7 @@ describe('FileStore', () => {
     expect(await fileStore.get(cache)).toEqual(null);
   });
 
-  it('writes into cache if folder is missing', async () => {
+  test('writes into cache if folder is missing', async () => {
     const fileStore = new FileStore({root: '/root'});
     const cache = Buffer.from([0xfa, 0xce, 0xb0, 0x0c]);
     const data = Buffer.from([0xca, 0xc4, 0xe5]);
@@ -61,7 +61,7 @@ describe('FileStore', () => {
     expect(await fileStore.get(cache)).toEqual(data);
   });
 
-  it('reads and writes binary data', async () => {
+  test('reads and writes binary data', async () => {
     const fileStore = new FileStore({root: '/root'});
     const cache = Buffer.from([0xfa, 0xce, 0xb0, 0x0c]);
     const data = Buffer.from([0xca, 0xc4, 0xe5]);