Skip to content

Commit 56b1370

Browse files
HarrisMaungmeta-codesync[bot]
authored andcommitted
add new compataibility mapping for acctonBMC
Summary: This Diff adds a new mapping for the minipack3n and minipack3ba to be compatible with acctonbmc by updating the mapping. Test Plan: Unit test suffices ./build.sh && ./build_dev.sh && go test ./... {F1983231809} Reviewed By: doranand Differential Revision: D86204253 fbshipit-source-id: 6fa2018dc6fc8bf1bb8642bee6e6367667508b8f
1 parent a7589ee commit 56b1370

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

tools/flashy/lib/validate/compatibility.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ var compatibleVersionMapping = map[string]string{
4141
"fby3vboot2": "fby3",
4242
"fbnd": "northdome",
4343
"kodiak": "sandia",
44+
"minipack3n": "acctonbmc",
45+
"minipack3ba": "acctonbmc",
4446
}
4547

4648
var normalizeVersion = func(ver string) string {

tools/flashy/lib/validate/compatibility_test.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,12 @@ func TestGetNormalizedBuildNameFromVersion(t *testing.T) {
155155
want: "fbgp2",
156156
wantErr: nil,
157157
},
158+
{
159+
name: "normalization test (minipack3n)",
160+
ver: "minipack3n-v2019.43.1",
161+
want: "acctonbmc",
162+
wantErr: nil,
163+
},
158164
{
159165
name: "ancient example",
160166
ver: "unknown-v52.4",
@@ -170,7 +176,7 @@ func TestGetNormalizedBuildNameFromVersion(t *testing.T) {
170176
},
171177
}
172178

173-
compatibleVersionMapping = map[string]string{"fby2-gpv2": "fbgp2"}
179+
compatibleVersionMapping = map[string]string{"fby2-gpv2": "fbgp2", "minipack3n": "acctonbmc"}
174180
for _, tc := range cases {
175181
t.Run(tc.name, func(t *testing.T) {
176182
got, err := getNormalizedBuildNameFromVersion(tc.ver)

0 commit comments

Comments
 (0)