Skip to content

Commit 960593a

Browse files
amithashfacebook-github-bot
authored andcommitted
flashy: Add support for 128M fb-meta
Summary: As title. This is to support platforms with larger flashes and images. Fixes oobgrader failure on gtartemis which has started to go beyond the 32M size. Test Plan: oobgrader on gtartemis which is 128M Flash. ``` oobgrader --host gtartemis-test-host -b openbmc.image.gtartemis:v2023.32.0 --flashy-tag 6746cb7 --wait <snip> <snip> c4746030-d209-4d88-b9de-18cee673c8f2 finished WorkflowStatus.FINISHED FinishStatus.SUCCEEDED ``` Workflow ID: c4746030-d209-4d88-b9de-18cee673c8f2 Ensure no regressions are observed in older ones. ``` oobgrader --host fby3-test-host -b openbmc.image.yosemite3:v2023.13.1 --flashy-tag 6746cb7 --wait <snip> <snip> b4524080-d79d-4ef2-a7e8-7fc97b224a0f finished WorkflowStatus.FINISHED FinishStatus.SUCCEEDED ``` Workflow ID: b4524080-d79d-4ef2-a7e8-7fc97b224a0f Reviewed By: cjcon90 Differential Revision: D48207387 fbshipit-source-id: f0f349b9ab237a439c8f0088da573cff141828b9
1 parent 40da76f commit 960593a

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

tools/flashy/lib/validate/partition/config.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,20 @@ type PartitionConfigInfo struct {
6565
// (4) vboot spl+recovery can be treated as UBOOT. It will be ignored if the flash1
6666
// header is RO (e.g. fbtp)
6767
var ImageFormats = []ImageFormat{
68+
{
69+
// covers both vboot-meta and fit-meta
70+
Name: "meta-big",
71+
PartitionConfigs: []PartitionConfigInfo{
72+
{
73+
// pass in the whole image and let MetaImagePartition deal with
74+
// finding the partitionConfigs and checksums
75+
Name: "fbmeta-image-big",
76+
Offset: 0,
77+
Size: 128 * 1024 * 1024,
78+
Type: FBMETA_IMAGE,
79+
},
80+
},
81+
},
6882
{
6983
// covers both vboot-meta and fit-meta
7084
Name: "meta",

0 commit comments

Comments
 (0)