Skip to content

Commit a576777

Browse files
kaanturkmenfacebook-github-bot
authored andcommitted
removing symlink logic and dynamically generating the flash procedures
Summary: This diff refactors the flashy tool's flash procedures by removing many individual platform-specific flash procedure files and dynamically generates the procedures. Test Plan: ``` [[email protected] /data/users/kaant/openbmc/tools/flashy (helium)]$ ./build.sh ; echo $? 0 ``` {P1923389586} Old Version ``` [[email protected] /data/users/kaant/openbmc/tools/flashy (helium)]$ grep step.RegisterStep flash_procedure/* flash_procedure/flash_angelslanding.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_bletchley.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_catalina.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_clearcreek.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_clemente.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_cloudripper.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_cmm.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_elbert.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_emeraldpools.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_fbdarwin.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_fbgp2.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_fbtp.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_fbttn.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_fby2.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_fby35.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_fby3.go: step.RegisterStep(yv3FlashStep) flash_procedure/flash_fuji.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_galaxy100.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_grandcanyon.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_grandteton.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_greatlakes.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_gtartemis.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_halfdome.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_harma.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_inspirationpoint.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_janga.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_javaisland.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_lightning.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_meru.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_minerva.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_minipack3n.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_minipack.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_montblanc.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_morgan800cc.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_northdome.go: step.RegisterStep(flash.FlashCpVboot) flash_procedure/flash_sandia.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_santabarbara.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_sonorapass.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_tahan.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_ventura.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_wedge100.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_wedge400.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_wedge.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_yamp.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_yosemite4.go: step.RegisterStep(flash.FlashCp) flash_procedure/flash_yosemite.go: step.RegisterStep(flash.FlashCp) ``` New Version ``` "angelslanding": flash.FlashCpVboot, "bletchley15": flash.FlashCp, "bletchley": flash.FlashCp, "catalina": flash.FlashCp, "clearcreek": flash.FlashCpVboot, "clemente": flash.FlashCp, "elbert": flash.FlashCp, "emeraldpools": flash.FlashCpVboot, "fbdarwin": flash.FlashCp, "fbgp2": flash.FlashCpVboot, "fbtp": flash.FlashCpVboot, "fbttn": flash.FlashCpVboot, "fby2": flash.FlashCpVboot, "fby35": flash.FlashCpVboot, "fby3": flash.FlashCpVboot, "fuji": flash.FlashCp, "grandcanyon": flash.FlashCpVboot, "grandteton": flash.FlashCpVboot, "greatlakes": flash.FlashCpVboot, "gtartemis": flash.FlashCpVboot, "halfdome": flash.FlashCpVboot, "harma": flash.FlashCp, "inspirationpoint": flash.FlashCpVboot, "janga": flash.FlashCp, "javaisland": flash.FlashCpVboot, "lightning": flash.FlashCp, "meru": flash.FlashCp, "minerva": flash.FlashCp, "minipack3n": flash.FlashCp, "minipack": flash.FlashCp, "montblanc": flash.FlashCp, "morgan800cc": flash.FlashCp, "northdome": flash.FlashCpVboot, "santabarbara": flash.FlashCp, "tahan": flash.FlashCp, "ventura": flash.FlashCp, "wedge100": flash.FlashCp, "wedge400": flash.FlashCp, "yamp": flash.FlashCp, "yosemite4": flash.FlashCp, "yosemite": flash.FlashCp, ``` Functional Tests {P1926900687} {P1926904572} {P1926898122} {P1926898692} Rollback Plan: Reviewed By: malikrafsan Differential Revision: D80937696 fbshipit-source-id: d6722a79ef475a02293b5eddd97f3b8a4227d447
1 parent 13bce2f commit a576777

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+730
-1374
lines changed

tools/flashy/flash_procedure/flash_angelslanding.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

tools/flashy/flash_procedure/flash_bletchley.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

tools/flashy/flash_procedure/flash_catalina.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

tools/flashy/flash_procedure/flash_clearcreek.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

tools/flashy/flash_procedure/flash_clemente.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

tools/flashy/flash_procedure/flash_cloudripper.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

tools/flashy/flash_procedure/flash_cmm.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

tools/flashy/flash_procedure/flash_elbert.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

tools/flashy/flash_procedure/flash_emeraldpools.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

tools/flashy/flash_procedure/flash_fbdarwin.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

0 commit comments

Comments
 (0)