Build fails: xgboost_external-stamp: cannot use 'throw' with exceptions disabled

[smiRaphi]

Describe the bug
Fails to build with:

MSBuild-Version 17.14.23+b0019275e für .NET Framework

  Checking File Globs
  1>Checking Build System
  Creating directories for 'xgboost_external'
  Building Custom Rule E:/Building/openzl/tools/ml_selector/CMakeLists.txt
  Performing download step (git clone) for 'xgboost_external'
  -- xgboost_external download command succeeded.  See also E:/Building/openzl/build/tools/ml_selector/xgboost_external
  -prefix/src/xgboost_external-stamp/xgboost_external-download-*.log
  Performing update step for 'xgboost_external'
  -- Already at requested ref: ccb511768e13d1670c10be07dea89d0edca138f3
  No patch step for 'xgboost_external'
  Performing configure step for 'xgboost_external'
  -- xgboost_external configure command succeeded.  See also E:/Building/openzl/build/tools/ml_selector/xgboost_externa
  l-prefix/src/xgboost_external-stamp/xgboost_external-configure-*.log
  Performing build step for 'xgboost_external'
  CMake Error at E:/Building/openzl/build/tools/ml_selector/xgboost_external-prefix/src/xgboost_external-stamp/xgboost_
  external-build-Release.cmake:49 (message):
    Command failed: 1

     'C:/Program Files/CMake/bin/cmake.exe' '--build' '.' '--config' 'Release'

    See also

      E:/Building/openzl/build/tools/ml_selector/xgboost_external-prefix/src/xgboost_external-stamp/xgboost_external-bu
  ild-*.log


C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(254,5): e
rror MSB8066: Custom build for 'E:\Building\openzl\build\CMakeFiles\2e6e65b425e25a861f262d5614ce312a\xgboost_external-m
kdir.rule;E:\Building\openzl\build\CMakeFiles\2e6e65b425e25a861f262d5614ce312a\xgboost_external-download.rule;E:\Buildi
ng\openzl\build\CMakeFiles\2e6e65b425e25a861f262d5614ce312a\xgboost_external-update.rule;E:\Building\openzl\build\CMake
Files\2e6e65b425e25a861f262d5614ce312a\xgboost_external-patch.rule;E:\Building\openzl\build\CMakeFiles\2e6e65b425e25a86
1f262d5614ce312a\xgboost_external-configure.rule;E:\Building\openzl\build\CMakeFiles\2e6e65b425e25a861f262d5614ce312a\x
gboost_external-build.rule;E:\Building\openzl\build\CMakeFiles\2e6e65b425e25a861f262d5614ce312a\xgboost_external-instal
l.rule;E:\Building\openzl\build\CMakeFiles\5a10c0119ce701c889974c74350770a0\xgboost_external-complete.rule;E:\Building\
openzl\build\CMakeFiles\7b3238e235596189d7dcb8559dd04c7b\xgboost_external.rule;E:\Building\openzl\tools\ml_selector\CMa
keLists.txt' exited with code 1. [E:\Building\openzl\build\tools\ml_selector\xgboost_external.vcxproj]

xgboost_external-build-out.log

To Reproduce
Fresh clone, these commands:

cmake -S . -B build -G "Visual Studio 17 2022" -A x64 -Wno-dev -DCMAKE_BUILD_TYPE=Release -DOPENZL_INSTALL=OFF -DOPENZL_BUILD_EXAMPLES=OFF -T ClangCL
cmake --build build --config Release -j 32

Desktop (please complete the following information):

• OS: Windows x64
• Version: 11 25H2
• Compiler: MSVC clang-cl
• Other relevant hardware specs: 32 core AMDx3D CPU
• Build system: CMake

[zhiningli]

Hey @smiRaphi ! I hit this same issue while working on #414. It seems to me that XGBoost doesn't build with MSVC or clang-cl on Windows.

I work around it by is using MinGW-w64 via MSYS2. In an MSYS2 MinGW64 shell:

pacman -S make diffutils cmake git mingw-w64-x86_64-gcc
LDFLAGS="-static" make -j zli BUILD_TYPE=OPT

[jlee303]

xgboost was added to targets that didn't need it, I added #466 to remove xgboost from libopenzl, this should restrict xgboost to targets that need to use it. It should address the issue you are facing @smiRaphi, let me know if it doesn't :)

[smiRaphi]

The issue still seems to be the exact same (at least the cmd output doesn't have anything new), even with OPENZL_BUILD_TOOLS=OFF

xgboost_external-build-out.log