Re-sync with internal repository (#639)

The internal and external repositories are out of sync. This Pull Request attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.

fbshipit-source-id: c9c298343c75e6ec23f6f2b075fece5d7950a7dd

Co-authored-by: Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com>

Author: meta-codesync[bot]

proxygen/lib/http/codec/compress/QPACKDecoder.cpp

@@ -92,6 +92,11 @@ uint32_t QPACKDecoder::decodePrefix(HPACKDecodeBuffer& dbuf) {
     }
   }
   VLOG(5) << "Decoded requiredInsertCount=" << requiredInsertCount;
+  if (requiredInsertCount > std::numeric_limits<uint32_t>::max()) {
+    LOG(ERROR) << "requiredInsertCount out of range=" << requiredInsertCount;
+    err_ = HPACK::DecodeError::INVALID_INDEX;
+    return 0;
+  }
   uint64_t delta = 0;
   if (dbuf.empty()) {
     LOG(ERROR) << "Invalid prefix, no delta-base";
@@ -112,10 +117,6 @@ uint32_t QPACKDecoder::decodePrefix(HPACKDecodeBuffer& dbuf) {
       err_ = HPACK::DecodeError::INVALID_INDEX;
       return 0;
     }
-    // The largest table we support is 2^32 - 1 / 32 entries, so
-    // requiredInsertCount (less any delta, etc) must be < 2^32.
-    CHECK_LE(requiredInsertCount - delta - 1,
-             std::numeric_limits<uint32_t>::max());
     baseIndex_ = requiredInsertCount - delta - 1;
   } else {
     // base must be < 2^32