Skip to content

Commit 8cc540c

Browse files
David Huynh (Infra)meta-codesync[bot]
authored andcommitted
mcrouter: disable Windows builds via getdeps manifest
Summary: mcrouter is not supported on Windows — its dependencies (folly, fizz, wangle, fbthrift, mvfst) build there but mcrouter itself doesn't. Teach the getdeps manifest to skip the Windows build by selecting the `nop` builder when `os=windows`, matching the pattern used by `proxygen`, `moxygen`, and other manifests that are linux/macOS-only. Without this, getdeps attempts to run cmake on Windows and fails partway through. With this change, mcrouter is treated as a no-op on Windows so dependency walks and CI runs succeed cleanly. Reviewed By: alikhtarov Differential Revision: D105243284 fbshipit-source-id: 0c9b1c4b0e1a370adc50490ded3176786b09dbcb
1 parent 5e691fe commit 8cc540c

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

build/fbcode_builder/manifests/mcrouter

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ fbcode/mcrouter = mcrouter
3232
[build]
3333
builder = cmake
3434

35+
[build.os=windows]
36+
builder = nop
37+
3538
[cmake.defines]
3639
BUILD_SHARED_LIBS=OFF
3740

0 commit comments

Comments
 (0)