add HTTPMessage::isConnectUdpReq

Summary:
adds an HTTPMessage::isConnectUdpReq
* added to consolidate all code that checks if a request is `connect-udp` into the new HTTPMessage::isConnectUdpReq
* prerequisite for removing HTTPMethod::CONNECT_UDP safely (see next diffs)

Reviewed By: lnicco

Differential Revision: D102534951

fbshipit-source-id: 2216991800aeae6464d0317e1a71df18605dce73

Author: hanidamlaj

proxygen/lib/http/HTTPMessage.cpp

@@ -991,6 +991,17 @@ const char* HTTPMessage::getDefaultReason(uint16_t status) {
   return "-";
 }
 
+bool HTTPMessage::isConnectUdpReq() const noexcept {
+  if (!isRequest()) {
+    return false;
+  }
+  const auto* upgradeProto = getUpgradeProtocol();
+  const auto method = getMethod();
+  return method == HTTPMethod::CONNECT_UDP ||
+         (method == HTTPMethod::CONNECT && upgradeProto &&
+          *upgradeProto == headers::kConnectUdp);
+}
+
 ParseURL HTTPMessage::setURLImplInternal(bool unparse, bool strict) {
   auto& req = request();
   auto u = ParseURL::parseURLMaybeInvalid(req.url_, strict);

proxygen/lib/http/HTTPMessage.h

@@ -861,6 +861,9 @@ class HTTPMessage {
     return fields_.which_ == MessageType::RESPONSE;
   }
 
+  // @returns true if this HTTPMessage represents a connect-udp request
+  bool isConnectUdpReq() const noexcept;
+
   /**
    * Assuming input contains
    * <name><valueDelim><value>(<pairDelim><name><valueDelim><value>),

proxygen/lib/http/HeaderConstants.h

@@ -28,5 +28,6 @@ extern const std::string kStatus200;
 
 constexpr std::string_view kWTAvailableProtocols{"wt-available-protocols"};
 constexpr std::string_view kWTProtocol{"wt-protocol"};
+constexpr std::string_view kConnectUdp{"connect-udp"};
 
 } // namespace proxygen::headers

proxygen/lib/http/session/HTTPTransaction.cpp

@@ -47,11 +47,6 @@ inline ErrorCode getDefaultAbortErrorCode(bool isUpstream) {
   return isUpstream ? ErrorCode::CANCEL : ErrorCode::INTERNAL_ERROR;
 }
 
-bool isConnectUdp(const HTTPMessage& msg) noexcept {
-  return msg.getMethod() == HTTPMethod::CONNECT && msg.getUpgradeProtocol() &&
-         *msg.getUpgradeProtocol() == "connect-udp";
-}
-
 } // namespace
 
 #define INVARIANT_RETURN(X, Y)                                            \
@@ -222,7 +217,7 @@ void HTTPTransaction::onIngressHeadersComplete(
     headRequest_ = (method == HTTPMethod::HEAD);
     upgraded_ = (method == HTTPMethod::CONNECT);
     wtConnectStream_ = HTTPWebTransport::isConnectMessage(*msg);
-    connectUdpStream_ = isConnectUdp(*msg);
+    connectUdpStream_ = msg->isConnectUdpReq();
   }
 
   if ((msg->isRequest() && msg->getMethod() != HTTPMethod::CONNECT) ||
@@ -1033,7 +1028,7 @@ void HTTPTransaction::sendHeadersWithOptionalEOM(const HTTPMessage& headers,
   if (headers.isRequest()) {
     headRequest_ = (headers.getMethod() == HTTPMethod::HEAD);
     wtConnectStream_ = HTTPWebTransport::isConnectMessage(headers);
-    connectUdpStream_ = isConnectUdp(headers);
+    connectUdpStream_ = headers.isConnectUdpReq();
   } else {
     has1xxResponse_ = headers.is1xxResponse();
   }