Skip to content

Commit 169525d

Browse files
Nick Lefeverfacebook-github-bot
Nick Lefever
authored andcommitted
Fix nativeID and testID prop diffing for View component (#51312)
Summary: Pull Request resolved: #51312 The nativeID and testID prop mapping on the native Java side use full caps `ID` in the setter mapping. Fixing the props diffing result to use the right key in the result for both. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D74724759 fbshipit-source-id: 4291a72cd3081981f4a25f16f8f2bef17230da54
1 parent 4c0607e commit 169525d

File tree

1 file changed

+2
-2
lines changed
  • packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view

1 file changed

+2
-2
lines changed

packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -583,11 +583,11 @@ folly::dynamic HostPlatformViewProps::getDiffProps(
583583
}
584584

585585
if (nativeId != oldProps->nativeId) {
586-
result["nativeId"] = nativeId;
586+
result["nativeID"] = nativeId;
587587
}
588588

589589
if (testId != oldProps->testId) {
590-
result["testId"] = testId;
590+
result["testID"] = testId;
591591
}
592592

593593
if (accessible != oldProps->accessible) {

0 commit comments

Comments
 (0)