Skip to content

Commit 18992d2

Browse files
mateoguzmanafacebook-github-bot
authored andcommitted
Make ReactPackageLogger internal (#49236)
Summary: As part of the initiative to reduce the public API surface, this class can be internalized. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+com.facebook.react.ReactPackageLogger). ## Changelog: [INTERNAL] - Make com.facebook.react.ReactPackageLogger internal Pull Request resolved: #49236 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: cipolleschi Differential Revision: D69307159 Pulled By: cortinico fbshipit-source-id: 397be796bc9cc7acd633b461d40fcf1989708b4c
1 parent abb9f4f commit 18992d2

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

packages/react-native/ReactAndroid/api/ReactAndroid.api

-5
Original file line numberDiff line numberDiff line change
@@ -349,11 +349,6 @@ public abstract interface class com/facebook/react/ReactPackage {
349349
public fun getModule (Ljava/lang/String;Lcom/facebook/react/bridge/ReactApplicationContext;)Lcom/facebook/react/bridge/NativeModule;
350350
}
351351

352-
public abstract interface class com/facebook/react/ReactPackageLogger {
353-
public abstract fun endProcessPackage ()V
354-
public abstract fun startProcessPackage ()V
355-
}
356-
357352
public abstract class com/facebook/react/ReactPackageTurboModuleManagerDelegate : com/facebook/react/internal/turbomodule/core/TurboModuleManagerDelegate {
358353
protected fun <init> (Lcom/facebook/react/bridge/ReactApplicationContext;Ljava/util/List;)V
359354
protected fun <init> (Lcom/facebook/react/bridge/ReactApplicationContext;Ljava/util/List;Lcom/facebook/jni/HybridData;)V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageLogger.kt

+3-4
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@
88
package com.facebook.react
99

1010
/** Interface for the bridge to call for TTI start and end markers. */
11-
public interface ReactPackageLogger {
11+
internal interface ReactPackageLogger {
12+
fun startProcessPackage(): Unit
1213

13-
public fun startProcessPackage(): Unit
14-
15-
public fun endProcessPackage(): Unit
14+
fun endProcessPackage(): Unit
1615
}

0 commit comments

Comments
 (0)