Skip to content

Commit 54ced39

Browse files
cortinicometa-codesync[bot]
authored andcommitted
Add missing @deprecated annotations to match @deprecated Javadoc tags (#56564)
Summary: Methods in UIImplementation and NativeViewHierarchyManager had deprecated Javadoc tags but were missing the Deprecated annotation, causing 29 dep-ann compiler warnings. ## Changelog: [INTERNAL] - Pull Request resolved: #56564 Test Plan: N/A Reviewed By: christophpurrer Differential Revision: D101984821 Pulled By: cortinico fbshipit-source-id: 9c05393a4406e2e8c55ccf86861c1a7c82bda2d4
1 parent f41364d commit 54ced39

2 files changed

Lines changed: 29 additions & 0 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,45 +31,53 @@ public class NativeViewHierarchyManager {
3131
/**
3232
* @deprecated Use new architecture instead.
3333
*/
34+
@Deprecated
3435
public NativeViewHierarchyManager(ViewManagerRegistry viewManagers) {}
3536

3637
/**
3738
* @deprecated Use new architecture instead.
3839
*/
40+
@Deprecated
3941
public NativeViewHierarchyManager(ViewManagerRegistry viewManagers, RootViewManager manager) {}
4042

4143
/**
4244
* @deprecated Use new architecture instead.
4345
*/
46+
@Deprecated
4447
public final synchronized @Nullable View resolveView(int tag) {
4548
return null;
4649
}
4750

4851
/**
4952
* @deprecated Use new architecture instead.
5053
*/
54+
@Deprecated
5155
public final synchronized @Nullable ViewManager resolveViewManager(int tag) {
5256
return null;
5357
}
5458

5559
/**
5660
* @deprecated Use new architecture instead.
5761
*/
62+
@Deprecated
5863
public void setLayoutAnimationEnabled(boolean enabled) {}
5964

6065
/**
6166
* @deprecated Use new architecture instead.
6267
*/
68+
@Deprecated
6369
public synchronized void updateInstanceHandle(int tag, long instanceHandle) {}
6470

6571
/**
6672
* @deprecated Use new architecture instead.
6773
*/
74+
@Deprecated
6875
public synchronized void updateProperties(int tag, ReactStylesDiffMap props) {}
6976

7077
/**
7178
* @deprecated Use new architecture instead.
7279
*/
80+
@Deprecated
7381
public synchronized void updateViewExtraData(int tag, Object extraData) {}
7482

7583
/**
@@ -82,6 +90,7 @@ public void updateLayout(int tag, int x, int y, int width, int height) {}
8290
/**
8391
* @deprecated Use new architecture instead.
8492
*/
93+
@Deprecated
8594
public synchronized void updateLayout(
8695
int parentTag,
8796
int tag,
@@ -94,13 +103,15 @@ public synchronized void updateLayout(
94103
/**
95104
* @deprecated Use new architecture instead.
96105
*/
106+
@Deprecated
97107
public synchronized long getInstanceHandle(int reactTag) {
98108
return 0;
99109
}
100110

101111
/**
102112
* @deprecated Use new architecture instead.
103113
*/
114+
@Deprecated
104115
public synchronized void createView(
105116
ThemedReactContext themedContext,
106117
int tag,
@@ -110,6 +121,7 @@ public synchronized void createView(
110121
/**
111122
* @deprecated Use new architecture instead.
112123
*/
124+
@Deprecated
113125
public synchronized void manageChildren(
114126
int tag,
115127
@Nullable int[] indicesToRemove,
@@ -119,61 +131,72 @@ public synchronized void manageChildren(
119131
/**
120132
* @deprecated Use new architecture instead.
121133
*/
134+
@Deprecated
122135
public synchronized void setChildren(int tag, ReadableArray childrenTags) {}
123136

124137
/**
125138
* @deprecated Use new architecture instead.
126139
*/
140+
@Deprecated
127141
public synchronized void addRootView(int tag, View view) {}
128142

129143
/**
130144
* @deprecated Use new architecture instead.
131145
*/
146+
@Deprecated
132147
protected final synchronized void addRootViewGroup(int tag, View view) {}
133148

134149
/**
135150
* @deprecated Use new architecture instead.
136151
*/
152+
@Deprecated
137153
protected synchronized void dropView(View view) {}
138154

139155
/**
140156
* @deprecated Use new architecture instead.
141157
*/
158+
@Deprecated
142159
public synchronized void removeRootView(int rootViewTag) {}
143160

144161
/**
145162
* @deprecated Use new architecture instead.
146163
*/
164+
@Deprecated
147165
public synchronized int getRootViewNum() {
148166
return 0;
149167
}
150168

151169
/**
152170
* @deprecated Use new architecture instead.
153171
*/
172+
@Deprecated
154173
public synchronized void measure(int tag, int[] outputBuffer) {}
155174

156175
/**
157176
* @deprecated Use new architecture instead.
158177
*/
178+
@Deprecated
159179
public synchronized void measureInWindow(int tag, int[] outputBuffer) {}
160180

161181
/**
162182
* @deprecated Use new architecture instead.
163183
*/
184+
@Deprecated
164185
public synchronized int findTargetTagForTouch(int reactTag, float touchX, float touchY) {
165186
return 0;
166187
}
167188

168189
/**
169190
* @deprecated Use new architecture instead.
170191
*/
192+
@Deprecated
171193
public synchronized void setJSResponder(
172194
int reactTag, int initialReactTag, boolean blockNativeResponder) {}
173195

174196
/**
175197
* @deprecated Use new architecture instead.
176198
*/
199+
@Deprecated
177200
public synchronized void clearJSResponder() {}
178201

179202
/**
@@ -186,11 +209,13 @@ public synchronized void dispatchCommand(
186209
/**
187210
* @deprecated Use new architecture instead.
188211
*/
212+
@Deprecated
189213
public synchronized void dispatchCommand(
190214
int reactTag, String commandId, @Nullable ReadableArray args) {}
191215

192216
/**
193217
* @deprecated Use new architecture instead.
194218
*/
219+
@Deprecated
195220
public synchronized void sendAccessibilityEvent(int tag, int eventType) {}
196221
}

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIImplementation.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,27 +58,31 @@ protected UIImplementation(
5858
/**
5959
* @deprecated This method is a stub and always returns null.
6060
*/
61+
@Deprecated
6162
protected ReactShadowNode createRootShadowNode() {
6263
return null;
6364
}
6465

6566
/**
6667
* @deprecated This method is a stub and always returns null.
6768
*/
69+
@Deprecated
6870
protected ReactShadowNode createShadowNode(String className) {
6971
return null;
7072
}
7173

7274
/**
7375
* @deprecated This method is a stub and always returns null.
7476
*/
77+
@Deprecated
7578
public final ReactShadowNode resolveShadowNode(int reactTag) {
7679
return null;
7780
}
7881

7982
/**
8083
* @deprecated This method is a stub and always returns null.
8184
*/
85+
@Deprecated
8286
protected final @Nullable ViewManager resolveViewManager(String className) {
8387
return null;
8488
}

0 commit comments

Comments
 (0)