Skip to content

Commit 64d5de7

Browse files
blakeffacebook-github-bot
authored andcommitted
Add Android Helloworld test on PR (#45019)
Summary: Use GHA on PRs: 1. run test_android_helloworld when users create a PR, to provide coverage while we figure out what's going on with our CircleCI tests / deprecate them. 2. fixes uploading the `.apks` that are generated. Changelog: [Internal] Pull Request resolved: #45019 Test Plan: Does GHA run for this PR? Reviewed By: cipolleschi Differential Revision: D58728019 Pulled By: blakef fbshipit-source-id: c6db41d60225702d50343384f103585d83e3528c
1 parent 01f7ab8 commit 64d5de7

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/test-all.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ name: Test All
22

33
on:
44
workflow_dispatch:
5+
pull_request:
56
push:
67
branches:
78
- main
@@ -875,7 +876,7 @@ jobs:
875876
uses: actions/[email protected]
876877
with:
877878
name: template-apk-${{ matrix.flavor }}-${{ matrix.architecture }}-${{ matrix.jsengine }}
878-
path: ./app/build/outputs/apk/
879+
path: packages/helloworld/app/build/outputs/apk/
879880
compression-level: 0
880881

881882
test_ios_helloworld_with_ruby_3_2_0:

0 commit comments

Comments
 (0)