Remove no-op MaintainVisibleScrollPositionHelper#updateScrollPosition() (#56535)

Summary:
Pull Request resolved: #56535

Changelog: [Internal]

Reviewed By: Abbondanzo

Differential Revision: D101331886

fbshipit-source-id: fb655f3edab86ebf0cca5f19663337ab2dee7a9d

Author: javache

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/MaintainVisibleScrollPositionHelper.kt

@@ -82,14 +82,6 @@ internal class MaintainVisibleScrollPositionHelper<ScrollViewT>(
     uIManager.removeUIManagerEventListener(this)
   }
 
-  /**
-   * Update the scroll position of the managed ScrollView. This should be called after layout has
-   * been updated.
-   *
-   * On Fabric this will be called internally in `didMountItems`.
-   */
-  fun updateScrollPosition() = Unit
-
   private fun updateScrollPositionInternal() {
     val config = config ?: return
     val firstVisibleViewRef = firstVisibleViewRef ?: return

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollView.java

@@ -1681,8 +1681,6 @@ public void onLayoutChange(
     // does not work in RTL.
     if (v.getLayoutDirection() == LAYOUT_DIRECTION_RTL) {
       adjustPositionForContentChangeRTL(left, right, oldLeft, oldRight);
-    } else if (mMaintainVisibleContentPositionHelper != null) {
-      mMaintainVisibleContentPositionHelper.updateScrollPosition();
     }
     ReactScrollViewHelper.emitLayoutChangeEvent(this);
   }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactNestedScrollView.java

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<dd8221f4b150b4b3bec3dafd4b745482>>
+ * @generated SignedSource<<74209bb4a44619a1ce16d68cfeeb0653>>
  */
 
 /**
@@ -1466,10 +1466,6 @@ public void onLayoutChange(
       return;
     }
 
-    if (mMaintainVisibleContentPositionHelper != null) {
-      mMaintainVisibleContentPositionHelper.updateScrollPosition();
-    }
-
     if (isShown() && isContentReady()) {
       int currentScrollY = getScrollY();
       int maxScrollY = getMaxScrollY();

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java

@@ -1458,10 +1458,6 @@ public void onLayoutChange(
       return;
     }
 
-    if (mMaintainVisibleContentPositionHelper != null) {
-      mMaintainVisibleContentPositionHelper.updateScrollPosition();
-    }
-
     if (isShown() && isContentReady()) {
       int currentScrollY = getScrollY();
       int maxScrollY = getMaxScrollY();