Fix: move continue-on-error inside reusable workflows

`continue-on-error` is not a supported key for reusable workflow
callers (jobs with `uses`). Move the retry logic inside the reusable
workflows instead:

- Test step uses step-level `continue-on-error: true` so the job
  always succeeds (setup failures still propagate normally)
- Report job checks the test step outcome and exposes it as output
- New `fail-on-error` input: when true, the report job fails if
  tests failed — used by retry_2 to make the workflow go red when
  all 3 attempts fail
- Callers no longer need `continue-on-error`

Author: cipolleschi

.github/workflows/e2e-android-rntester.yml

@@ -5,6 +5,10 @@ permissions:
 
 on:
   workflow_call:
+    inputs:
+      fail-on-error:
+        type: boolean
+        default: false
     outputs:
       status:
         description: "The result of the E2E tests (success or failure)"
@@ -13,6 +17,8 @@ on:
 jobs:
   test:
     runs-on: 4-core-ubuntu
+    outputs:
+      status: ${{ steps.report-status.outputs.status }}
     strategy:
       fail-fast: false
       matrix:
@@ -32,13 +38,19 @@ jobs:
       - name: Print folder structure
         run: ls -lR ./packages/rn-tester/android/app/build/outputs/apk/${{ matrix.flavor }}/
       - name: Run E2E Tests
+        id: run-tests
+        continue-on-error: true
         uses: ./.github/actions/maestro-android
         timeout-minutes: 60
         with:
           app-path: ./packages/rn-tester/android/app/build/outputs/apk/${{ matrix.flavor }}/app-x86-${{ matrix.flavor }}.apk
           app-id: com.facebook.react.uiapp
           maestro-flow: ./packages/rn-tester/.maestro
           flavor: ${{ matrix.flavor }}
+      - name: Report status
+        id: report-status
+        if: ${{ always() && steps.run-tests.outcome == 'failure' }}
+        run: echo "status=failure" >> $GITHUB_OUTPUT
 
   report:
     needs: test
@@ -49,8 +61,11 @@ jobs:
     steps:
       - id: check
         run: |
-          if [[ "${{ needs.test.result }}" == "failure" ]]; then
+          if [[ "${{ needs.test.outputs.status }}" == "failure" ]]; then
             echo "status=failure" >> $GITHUB_OUTPUT
           else
             echo "status=success" >> $GITHUB_OUTPUT
           fi
+      - name: Fail if needed
+        if: ${{ inputs.fail-on-error && steps.check.outputs.status == 'failure' }}
+        run: exit 1

.github/workflows/e2e-android-templateapp.yml

@@ -5,6 +5,10 @@ permissions:
 
 on:
   workflow_call:
+    inputs:
+      fail-on-error:
+        type: boolean
+        default: false
     outputs:
       status:
         description: "The result of the E2E tests (success or failure)"
@@ -13,6 +17,8 @@ on:
 jobs:
   test:
     runs-on: 4-core-ubuntu
+    outputs:
+      status: ${{ steps.report-status.outputs.status }}
     strategy:
       fail-fast: false
       matrix:
@@ -68,6 +74,8 @@ jobs:
           ./gradlew assemble$CAPITALIZED_FLAVOR --no-daemon -PreactNativeArchitectures=x86
 
       - name: Run E2E Tests
+        id: run-tests
+        continue-on-error: true
         uses: ./.github/actions/maestro-android
         timeout-minutes: 60
         with:
@@ -77,6 +85,10 @@ jobs:
           install-java: 'false'
           flavor: ${{ matrix.flavor }}
           working-directory: /tmp/RNTestProject
+      - name: Report status
+        id: report-status
+        if: ${{ always() && steps.run-tests.outcome == 'failure' }}
+        run: echo "status=failure" >> $GITHUB_OUTPUT
 
   report:
     needs: test
@@ -87,8 +99,11 @@ jobs:
     steps:
       - id: check
         run: |
-          if [[ "${{ needs.test.result }}" == "failure" ]]; then
+          if [[ "${{ needs.test.outputs.status }}" == "failure" ]]; then
             echo "status=failure" >> $GITHUB_OUTPUT
           else
             echo "status=success" >> $GITHUB_OUTPUT
           fi
+      - name: Fail if needed
+        if: ${{ inputs.fail-on-error && steps.check.outputs.status == 'failure' }}
+        run: exit 1

.github/workflows/e2e-ios-rntester.yml

@@ -5,6 +5,10 @@ permissions:
 
 on:
   workflow_call:
+    inputs:
+      fail-on-error:
+        type: boolean
+        default: false
     outputs:
       status:
         description: "The result of the E2E tests (success or failure)"
@@ -13,6 +17,8 @@ on:
 jobs:
   test:
     runs-on: macos-15-large
+    outputs:
+      status: ${{ steps.report-status.outputs.status }}
     strategy:
       fail-fast: false
       matrix:
@@ -32,12 +38,18 @@ jobs:
       - name: Setup xcode
         uses: ./.github/actions/setup-xcode
       - name: Run E2E Tests
+        id: run-tests
+        continue-on-error: true
         uses: ./.github/actions/maestro-ios
         with:
           app-path: "/tmp/RNTesterBuild/RNTester.app"
           app-id: com.meta.RNTester.localDevelopment
           maestro-flow: ./packages/rn-tester/.maestro/
           flavor: ${{ matrix.flavor }}
+      - name: Report status
+        id: report-status
+        if: ${{ always() && steps.run-tests.outcome == 'failure' }}
+        run: echo "status=failure" >> $GITHUB_OUTPUT
 
   report:
     needs: test
@@ -48,8 +60,11 @@ jobs:
     steps:
       - id: check
         run: |
-          if [[ "${{ needs.test.result }}" == "failure" ]]; then
+          if [[ "${{ needs.test.outputs.status }}" == "failure" ]]; then
             echo "status=failure" >> $GITHUB_OUTPUT
           else
             echo "status=success" >> $GITHUB_OUTPUT
           fi
+      - name: Fail if needed
+        if: ${{ inputs.fail-on-error && steps.check.outputs.status == 'failure' }}
+        run: exit 1

.github/workflows/e2e-ios-templateapp.yml

@@ -5,6 +5,10 @@ permissions:
 
 on:
   workflow_call:
+    inputs:
+      fail-on-error:
+        type: boolean
+        default: false
     outputs:
       status:
         description: "The result of the E2E tests (success or failure)"
@@ -13,6 +17,8 @@ on:
 jobs:
   test:
     runs-on: macos-15-large
+    outputs:
+      status: ${{ steps.report-status.outputs.status }}
     strategy:
       fail-fast: false
       matrix:
@@ -89,13 +95,19 @@ jobs:
             -destination "generic/platform=iOS Simulator" \
             -derivedDataPath "/tmp/RNTestProject"
       - name: Run E2E Tests
+        id: run-tests
+        continue-on-error: true
         uses: ./.github/actions/maestro-ios
         with:
           app-path: "/tmp/RNTestProject/Build/Products/${{ matrix.flavor }}-iphonesimulator/RNTestProject.app"
           app-id: org.reactjs.native.example.RNTestProject
           maestro-flow: ./scripts/e2e/.maestro/
           flavor: ${{ matrix.flavor }}
           working-directory: /tmp/RNTestProject
+      - name: Report status
+        id: report-status
+        if: ${{ always() && steps.run-tests.outcome == 'failure' }}
+        run: echo "status=failure" >> $GITHUB_OUTPUT
 
   report:
     needs: test
@@ -106,8 +118,11 @@ jobs:
     steps:
       - id: check
         run: |
-          if [[ "${{ needs.test.result }}" == "failure" ]]; then
+          if [[ "${{ needs.test.outputs.status }}" == "failure" ]]; then
             echo "status=failure" >> $GITHUB_OUTPUT
           else
             echo "status=success" >> $GITHUB_OUTPUT
           fi
+      - name: Fail if needed
+        if: ${{ inputs.fail-on-error && steps.check.outputs.status == 'failure' }}
+        run: exit 1

.github/workflows/fantom-tests.yml

@@ -5,6 +5,10 @@ permissions:
 
 on:
   workflow_call:
+    inputs:
+      fail-on-error:
+        type: boolean
+        default: false
     outputs:
       status:
         description: "The result of the Fantom tests (success or failure)"
@@ -13,6 +17,8 @@ on:
 jobs:
   test:
     runs-on: 8-core-ubuntu
+    outputs:
+      status: ${{ steps.report-status.outputs.status }}
     container:
       image: reactnativecommunity/react-native-android:latest
       env:
@@ -21,7 +27,13 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v6
       - name: Run Fantom Tests
+        id: run-tests
+        continue-on-error: true
         uses: ./.github/actions/run-fantom-tests
+      - name: Report status
+        id: report-status
+        if: ${{ always() && steps.run-tests.outcome == 'failure' }}
+        run: echo "status=failure" >> $GITHUB_OUTPUT
 
   report:
     needs: test
@@ -32,8 +44,11 @@ jobs:
     steps:
       - id: check
         run: |
-          if [[ "${{ needs.test.result }}" == "failure" ]]; then
+          if [[ "${{ needs.test.outputs.status }}" == "failure" ]]; then
             echo "status=failure" >> $GITHUB_OUTPUT
           else
             echo "status=success" >> $GITHUB_OUTPUT
           fi
+      - name: Fail if needed
+        if: ${{ inputs.fail-on-error && steps.check.outputs.status == 'failure' }}
+        run: exit 1

.github/workflows/test-all.yml

@@ -159,58 +159,58 @@ jobs:
   test_e2e_ios_rntester:
     needs: test_ios_rntester
     uses: ./.github/workflows/e2e-ios-rntester.yml
-    continue-on-error: true
     secrets: inherit
 
   test_e2e_ios_rntester_retry_1:
     needs: test_e2e_ios_rntester
     if: ${{ always() && needs.test_e2e_ios_rntester.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-ios-rntester.yml
-    continue-on-error: true
     secrets: inherit
 
   test_e2e_ios_rntester_retry_2:
     needs: test_e2e_ios_rntester_retry_1
     if: ${{ always() && needs.test_e2e_ios_rntester_retry_1.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-ios-rntester.yml
+    with:
+      fail-on-error: true
     secrets: inherit
 
   test_e2e_ios_templateapp:
     needs: [build_npm_package, prebuild_apple_dependencies]
     uses: ./.github/workflows/e2e-ios-templateapp.yml
-    continue-on-error: true
     secrets: inherit
 
   test_e2e_ios_templateapp_retry_1:
     needs: test_e2e_ios_templateapp
     if: ${{ always() && needs.test_e2e_ios_templateapp.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-ios-templateapp.yml
-    continue-on-error: true
     secrets: inherit
 
   test_e2e_ios_templateapp_retry_2:
     needs: test_e2e_ios_templateapp_retry_1
     if: ${{ always() && needs.test_e2e_ios_templateapp_retry_1.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-ios-templateapp.yml
+    with:
+      fail-on-error: true
     secrets: inherit
 
   test_e2e_android_templateapp:
     needs: build_npm_package
     uses: ./.github/workflows/e2e-android-templateapp.yml
-    continue-on-error: true
     secrets: inherit
 
   test_e2e_android_templateapp_retry_1:
     needs: test_e2e_android_templateapp
     if: ${{ always() && needs.test_e2e_android_templateapp.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-android-templateapp.yml
-    continue-on-error: true
     secrets: inherit
 
   test_e2e_android_templateapp_retry_2:
     needs: test_e2e_android_templateapp_retry_1
     if: ${{ always() && needs.test_e2e_android_templateapp_retry_1.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-android-templateapp.yml
+    with:
+      fail-on-error: true
     secrets: inherit
 
   build_fantom_runner:
@@ -240,20 +240,20 @@ jobs:
   run_fantom_tests:
     needs: build_fantom_runner
     uses: ./.github/workflows/fantom-tests.yml
-    continue-on-error: true
     secrets: inherit
 
   run_fantom_tests_retry_1:
     needs: run_fantom_tests
     if: ${{ always() && needs.run_fantom_tests.outputs.status == 'failure' }}
     uses: ./.github/workflows/fantom-tests.yml
-    continue-on-error: true
     secrets: inherit
 
   run_fantom_tests_retry_2:
     needs: run_fantom_tests_retry_1
     if: ${{ always() && needs.run_fantom_tests_retry_1.outputs.status == 'failure' }}
     uses: ./.github/workflows/fantom-tests.yml
+    with:
+      fail-on-error: true
     secrets: inherit
 
   build_android:
@@ -285,20 +285,20 @@ jobs:
   test_e2e_android_rntester:
     needs: build_android
     uses: ./.github/workflows/e2e-android-rntester.yml
-    continue-on-error: true
     secrets: inherit
 
   test_e2e_android_rntester_retry_1:
     needs: test_e2e_android_rntester
     if: ${{ always() && needs.test_e2e_android_rntester.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-android-rntester.yml
-    continue-on-error: true
     secrets: inherit
 
   test_e2e_android_rntester_retry_2:
     needs: test_e2e_android_rntester_retry_1
     if: ${{ always() && needs.test_e2e_android_rntester_retry_1.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-android-rntester.yml
+    with:
+      fail-on-error: true
     secrets: inherit
 
   build_npm_package: