Use std::optional instead of stub constexpr value for unset event start (#51252)

Summary:
Pull Request resolved: #51252

# Changelog: [Internal]

Removes usage of `DOM_HIGH_RES_TIME_STAMP_UNSET` stub contstexpr.

Instead, all events that were using it will now declare timestamps as optional. This is the pre-requisite before migrating these raw `double` values to `HighResTimeStamp`.

Reviewed By: javache

Differential Revision: D74248998

fbshipit-source-id: 9ef223420823d036db815f956e91ff3a712c9833

Author: hoxyq

packages/react-native/ReactCommon/react/renderer/core/EventLogger.h

@@ -9,6 +9,8 @@
 
 #include <react/renderer/core/EventTarget.h>
 #include <react/timing/primitives.h>
+
+#include <optional>
 #include <string_view>
 
 namespace facebook::react {
@@ -32,8 +34,8 @@ class EventLogger {
   virtual EventTag onEventStart(
       std::string_view name,
       SharedEventTarget target,
-      DOMHighResTimeStamp eventStartTimeStamp =
-          DOM_HIGH_RES_TIME_STAMP_UNSET) = 0;
+      std::optional<DOMHighResTimeStamp> eventStartTimeStamp =
+          std::nullopt) = 0;
 
   /*
    * Called when event starts getting dispatched (processed by the handlers, if

packages/react-native/ReactCommon/react/renderer/core/RawEvent.h

@@ -8,6 +8,7 @@
 #pragma once
 
 #include <memory>
+#include <optional>
 #include <string>
 
 #include <react/renderer/core/EventLogger.h>
@@ -86,7 +87,7 @@ struct RawEvent {
   // The client may specify a platform-specific timestamp for the event start
   // time, for example when MotionEvent was triggered on the Android native
   // side.
-  DOMHighResTimeStamp eventStartTimeStamp{DOM_HIGH_RES_TIME_STAMP_UNSET};
+  std::optional<DOMHighResTimeStamp> eventStartTimeStamp = std::nullopt;
 };
 
 } // namespace facebook::react

packages/react-native/ReactCommon/react/renderer/core/tests/EventQueueProcessorTest.cpp

@@ -25,7 +25,7 @@ class MockEventLogger : public EventLogger {
   EventTag onEventStart(
       std::string_view /*name*/,
       SharedEventTarget /*target*/,
-      DOMHighResTimeStamp /*eventStartTimeStamp*/) override {
+      std::optional<DOMHighResTimeStamp> /*eventStartTimeStamp*/) override {
     return EMPTY_EVENT_TAG;
   }
   void onEventProcessingStart(EventTag /*tag*/) override {}

packages/react-native/ReactCommon/react/renderer/observers/events/EventPerformanceLogger.cpp

@@ -103,7 +103,7 @@ EventPerformanceLogger::EventPerformanceLogger(
 EventTag EventPerformanceLogger::onEventStart(
     std::string_view name,
     SharedEventTarget target,
-    DOMHighResTimeStamp eventStartTimeStamp) {
+    std::optional<DOMHighResTimeStamp> eventStartTimeStamp) {
   auto performanceEntryReporter = performanceEntryReporter_.lock();
   if (performanceEntryReporter == nullptr) {
     return EMPTY_EVENT_TAG;
@@ -121,9 +121,9 @@ EventTag EventPerformanceLogger::onEventStart(
 
   // The event start timestamp may be provided by the caller in order to
   // specify the platform specific event start time.
-  auto timeStamp = eventStartTimeStamp == DOM_HIGH_RES_TIME_STAMP_UNSET
-      ? performanceEntryReporter->getCurrentTimeStamp()
-      : eventStartTimeStamp;
+  DOMHighResTimeStamp timeStamp = eventStartTimeStamp
+      ? *eventStartTimeStamp
+      : performanceEntryReporter->getCurrentTimeStamp();
   {
     std::lock_guard lock(eventsInFlightMutex_);
     eventsInFlight_.emplace(

packages/react-native/ReactCommon/react/renderer/observers/events/EventPerformanceLogger.h

@@ -13,6 +13,7 @@
 #include <react/renderer/uimanager/UIManagerMountHook.h>
 #include <memory>
 #include <mutex>
+#include <optional>
 #include <string_view>
 #include <unordered_map>
 
@@ -30,8 +31,8 @@ class EventPerformanceLogger : public EventLogger,
   EventTag onEventStart(
       std::string_view name,
       SharedEventTarget target,
-      DOMHighResTimeStamp eventStartTimeStamp =
-          DOM_HIGH_RES_TIME_STAMP_UNSET) override;
+      std::optional<DOMHighResTimeStamp> eventStartTimeStamp =
+          std::nullopt) override;
   void onEventProcessingStart(EventTag tag) override;
   void onEventProcessingEnd(EventTag tag) override;
 

packages/react-native/ReactCommon/react/timing/primitives.h

@@ -17,8 +17,6 @@ namespace facebook::react {
 // not necessary in React Native.
 using DOMHighResTimeStamp = double;
 
-constexpr DOMHighResTimeStamp DOM_HIGH_RES_TIME_STAMP_UNSET = -1.0;
-
 inline DOMHighResTimeStamp chronoToDOMHighResTimeStamp(
     std::chrono::steady_clock::duration duration) {
   return static_cast<std::chrono::duration<double, std::milli>>(duration)