Replace RuntimeSchedulerClock with HighResTimeClock

Summary:
# Changelog: [Internal]

Replaces `RuntimeSchedulerClock`, which was an alias for `std::chrono::steady_clock` with previously defined single timestamp abstraction.

Differential Revision: D74246459

Author: hoxyq

packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/NativeIdleCallbacks.cpp

@@ -36,7 +36,7 @@ class IdleTaskRef : public jsi::NativeState {
 jsi::Function makeTimeRemainingFunction(
     jsi::Runtime& runtime,
     std::shared_ptr<RuntimeScheduler> runtimeScheduler,
-    RuntimeSchedulerTimePoint deadline) {
+    HighResTimeStamp deadline) {
   return jsi::Function::createFromHostFunction(
       runtime,
       jsi::PropNameID::forAscii(runtime, "timeRemaining"),
@@ -57,11 +57,7 @@ jsi::Function makeTimeRemainingFunction(
             auto now = runtimeScheduler->now();
 
             remainingTime = std::max(
-                static_cast<double>(
-                    std::chrono::duration_cast<std::chrono::milliseconds>(
-                        deadline - now)
-                        .count()),
-                0.0);
+                static_cast<double>((deadline - now).toMilliseconds()), 0.0);
 
             if (remainingTime == 0) {
               expired = true;
@@ -87,7 +83,7 @@ CallbackHandle NativeIdleCallbacks::requestIdleCallback(
 
   // handle timeout parameter
   std::optional<RuntimeSchedulerTimeout> timeout;
-  std::optional<RuntimeSchedulerTimePoint> expirationTime;
+  std::optional<HighResTimeStamp> expirationTime;
 
   if (options.has_value() && options.value().timeout.has_value()) {
     auto userTimeout = (options.value().timeout.value());

packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/NativeIdleCallbacks.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <react/timing/primitives.h>
+
 #if __has_include("rncoreJSI.h") // Cmake headers on Android
 #include "rncoreJSI.h"
 #elif __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler.cpp

@@ -22,7 +22,7 @@ extern const char RuntimeSchedulerKey[] = "RuntimeScheduler";
 namespace {
 std::unique_ptr<RuntimeSchedulerBase> getRuntimeSchedulerImplementation(
     RuntimeExecutor runtimeExecutor,
-    std::function<RuntimeSchedulerTimePoint()> now,
+    std::function<HighResTimeStamp()> now,
     RuntimeSchedulerTaskErrorHandler onTaskError) {
   if (ReactNativeFeatureFlags::enableBridgelessArchitecture()) {
     return std::make_unique<RuntimeScheduler_Modern>(
@@ -37,7 +37,7 @@ std::unique_ptr<RuntimeSchedulerBase> getRuntimeSchedulerImplementation(
 
 RuntimeScheduler::RuntimeScheduler(
     RuntimeExecutor runtimeExecutor,
-    std::function<RuntimeSchedulerTimePoint()> now,
+    std::function<HighResTimeStamp()> now,
     RuntimeSchedulerTaskErrorHandler onTaskError)
     : runtimeSchedulerImpl_(getRuntimeSchedulerImplementation(
           std::move(runtimeExecutor),
@@ -90,7 +90,7 @@ SchedulerPriority RuntimeScheduler::getCurrentPriorityLevel() const noexcept {
   return runtimeSchedulerImpl_->getCurrentPriorityLevel();
 }
 
-RuntimeSchedulerTimePoint RuntimeScheduler::now() const noexcept {
+HighResTimeStamp RuntimeScheduler::now() const noexcept {
   return runtimeSchedulerImpl_->now();
 }
 

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler.h

@@ -10,9 +10,9 @@
 #include <ReactCommon/RuntimeExecutor.h>
 #include <react/performance/timeline/PerformanceEntryReporter.h>
 #include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
-#include <react/renderer/runtimescheduler/RuntimeSchedulerClock.h>
 #include <react/renderer/runtimescheduler/SchedulerPriorityUtils.h>
 #include <react/renderer/runtimescheduler/Task.h>
+#include <react/timing/primitives.h>
 #include "RuntimeSchedulerEventTimingDelegate.h"
 
 namespace facebook::react {
@@ -50,7 +50,7 @@ class RuntimeSchedulerBase {
   virtual void cancelTask(Task& task) noexcept = 0;
   virtual bool getShouldYield() noexcept = 0;
   virtual SchedulerPriority getCurrentPriorityLevel() const noexcept = 0;
-  virtual RuntimeSchedulerTimePoint now() const noexcept = 0;
+  virtual HighResTimeStamp now() const noexcept = 0;
   virtual void callExpiredTasks(jsi::Runtime& runtime) = 0;
   virtual void scheduleRenderingUpdate(
       SurfaceId surfaceId,
@@ -69,8 +69,7 @@ class RuntimeScheduler final : RuntimeSchedulerBase {
  public:
   explicit RuntimeScheduler(
       RuntimeExecutor runtimeExecutor,
-      std::function<RuntimeSchedulerTimePoint()> now =
-          RuntimeSchedulerClock::now,
+      std::function<HighResTimeStamp()> now = HighResTimeClock::now,
       RuntimeSchedulerTaskErrorHandler onTaskError = handleTaskErrorDefault);
 
   /*
@@ -149,7 +148,7 @@ class RuntimeScheduler final : RuntimeSchedulerBase {
    *
    * Thread synchronization must be enforced externally.
    */
-  RuntimeSchedulerTimePoint now() const noexcept override;
+  HighResTimeStamp now() const noexcept override;
 
   /*
    * Expired task is a task that should have been already executed. Designed to

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeSchedulerBinding.cpp

@@ -7,11 +7,11 @@
 
 #include "RuntimeSchedulerBinding.h"
 #include <ReactCommon/SchedulerPriority.h>
+#include <react/timing/primitives.h>
 #include "RuntimeScheduler.h"
 #include "SchedulerPriorityUtils.h"
 #include "primitives.h"
 
-#include <chrono>
 #include <memory>
 #include <utility>
 
@@ -144,10 +144,8 @@ jsi::Value RuntimeSchedulerBinding::get(
             const jsi::Value*,
             size_t) noexcept -> jsi::Value {
           auto now = runtimeScheduler_->now();
-          auto asDouble =
-              std::chrono::duration<double, std::milli>(now.time_since_epoch())
-                  .count();
-          return {asDouble};
+          auto domHighResTimeStamp = now.toDOMHighResTimeStamp();
+          return {domHighResTimeStamp};
         });
   }
 

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeSchedulerClock.h

@@ -18,7 +18,7 @@ namespace facebook::react {
 
 RuntimeScheduler_Legacy::RuntimeScheduler_Legacy(
     RuntimeExecutor runtimeExecutor,
-    std::function<RuntimeSchedulerTimePoint()> now,
+    std::function<HighResTimeStamp()> now,
     RuntimeSchedulerTaskErrorHandler onTaskError)
     : runtimeExecutor_(std::move(runtimeExecutor)),
       now_(std::move(now)),
@@ -113,7 +113,7 @@ SchedulerPriority RuntimeScheduler_Legacy::getCurrentPriorityLevel()
   return currentPriority_;
 }
 
-RuntimeSchedulerTimePoint RuntimeScheduler_Legacy::now() const noexcept {
+HighResTimeStamp RuntimeScheduler_Legacy::now() const noexcept {
   return now_();
 }
 

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Legacy.cpp

@@ -10,7 +10,6 @@
 #include <ReactCommon/RuntimeExecutor.h>
 #include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
 #include <react/renderer/runtimescheduler/RuntimeScheduler.h>
-#include <react/renderer/runtimescheduler/RuntimeSchedulerClock.h>
 #include <react/renderer/runtimescheduler/Task.h>
 #include <atomic>
 #include <memory>
@@ -22,7 +21,7 @@ class RuntimeScheduler_Legacy final : public RuntimeSchedulerBase {
  public:
   explicit RuntimeScheduler_Legacy(
       RuntimeExecutor runtimeExecutor,
-      std::function<RuntimeSchedulerTimePoint()> now,
+      std::function<HighResTimeStamp()> now,
       RuntimeSchedulerTaskErrorHandler onTaskError);
 
   /*
@@ -109,7 +108,7 @@ class RuntimeScheduler_Legacy final : public RuntimeSchedulerBase {
    *
    * Thread synchronization must be enforced externally.
    */
-  RuntimeSchedulerTimePoint now() const noexcept override;
+  HighResTimeStamp now() const noexcept override;
 
   /*
    * Expired task is a task that should have been already executed. Designed to
@@ -169,7 +168,7 @@ class RuntimeScheduler_Legacy final : public RuntimeSchedulerBase {
    * Returns a time point representing the current point in time. May be called
    * from multiple threads.
    */
-  std::function<RuntimeSchedulerTimePoint()> now_;
+  std::function<HighResTimeStamp()> now_;
 
   /*
    * Flag indicating if callback on JavaScript queue has been

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Legacy.h

@@ -33,7 +33,7 @@ std::chrono::milliseconds getResolvedTimeoutForIdleTask(
 
 RuntimeScheduler_Modern::RuntimeScheduler_Modern(
     RuntimeExecutor runtimeExecutor,
-    std::function<RuntimeSchedulerTimePoint()> now,
+    std::function<HighResTimeStamp()> now,
     RuntimeSchedulerTaskErrorHandler onTaskError)
     : runtimeExecutor_(std::move(runtimeExecutor)),
       now_(std::move(now)),
@@ -139,7 +139,7 @@ SchedulerPriority RuntimeScheduler_Modern::getCurrentPriorityLevel()
   return currentPriority_;
 }
 
-RuntimeSchedulerTimePoint RuntimeScheduler_Modern::now() const noexcept {
+HighResTimeStamp RuntimeScheduler_Modern::now() const noexcept {
   return now_();
 }
 
@@ -276,7 +276,7 @@ void RuntimeScheduler_Modern::runEventLoop(
 }
 
 std::shared_ptr<Task> RuntimeScheduler_Modern::selectTask(
-    RuntimeSchedulerTimePoint currentTime,
+    HighResTimeStamp currentTime,
     bool onlyExpired) {
   // We need a unique lock here because we'll also remove executed tasks from
   // the top of the queue.
@@ -305,7 +305,7 @@ std::shared_ptr<Task> RuntimeScheduler_Modern::selectTask(
 void RuntimeScheduler_Modern::runEventLoopTick(
     jsi::Runtime& runtime,
     Task& task,
-    RuntimeSchedulerTimePoint taskStartTime) {
+    HighResTimeStamp taskStartTime) {
   TraceSection s("RuntimeScheduler::runEventLoopTick");
   jsinspector_modern::tracing::EventLoopReporter performanceReporter(
       jsinspector_modern::tracing::EventLoopPhase::Task);
@@ -434,24 +434,24 @@ void RuntimeScheduler_Modern::performMicrotaskCheckpoint(
 
 void RuntimeScheduler_Modern::reportLongTasks(
     const Task& /*task*/,
-    RuntimeSchedulerTimePoint startTime,
-    RuntimeSchedulerTimePoint endTime) {
+    HighResTimeStamp startTime,
+    HighResTimeStamp endTime) {
   auto reporter = performanceEntryReporter_;
   if (reporter == nullptr) {
     return;
   }
 
   auto checkedDurationMs =
-      chronoToDOMHighResTimeStamp(longestPeriodWithoutYieldingOpportunity_);
+      longestPeriodWithoutYieldingOpportunity_.toDOMHighResTimeStamp();
   if (checkedDurationMs >= LONG_TASK_DURATION_THRESHOLD_MS) {
-    auto durationMs = chronoToDOMHighResTimeStamp(endTime - startTime);
-    auto startTimeMs = chronoToDOMHighResTimeStamp(startTime);
+    auto durationMs = (endTime - startTime).toDOMHighResTimeStamp();
+    auto startTimeMs = startTime.toDOMHighResTimeStamp();
     reporter->reportLongTask(startTimeMs, durationMs);
   }
 }
 
 void RuntimeScheduler_Modern::markYieldingOpportunity(
-    RuntimeSchedulerTimePoint currentTime) {
+    HighResTimeStamp currentTime) {
   auto currentPeriod = currentTime - lastYieldingOpportunity_;
   if (currentPeriod > longestPeriodWithoutYieldingOpportunity_) {
     longestPeriodWithoutYieldingOpportunity_ = currentPeriod;

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.cpp

@@ -10,7 +10,6 @@
 #include <ReactCommon/RuntimeExecutor.h>
 #include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
 #include <react/renderer/runtimescheduler/RuntimeScheduler.h>
-#include <react/renderer/runtimescheduler/RuntimeSchedulerClock.h>
 #include <react/renderer/runtimescheduler/Task.h>
 #include <atomic>
 #include <memory>
@@ -23,7 +22,7 @@ class RuntimeScheduler_Modern final : public RuntimeSchedulerBase {
  public:
   explicit RuntimeScheduler_Modern(
       RuntimeExecutor runtimeExecutor,
-      std::function<RuntimeSchedulerTimePoint()> now,
+      std::function<HighResTimeStamp()> now,
       RuntimeSchedulerTaskErrorHandler onTaskError);
 
   /*
@@ -118,7 +117,7 @@ class RuntimeScheduler_Modern final : public RuntimeSchedulerBase {
    *
    * Can be called from any thread.
    */
-  RuntimeSchedulerTimePoint now() const noexcept override;
+  HighResTimeStamp now() const noexcept override;
 
   /*
    * Expired task is a task that should have been already executed. Designed to
@@ -162,10 +161,10 @@ class RuntimeScheduler_Modern final : public RuntimeSchedulerBase {
       taskQueue_;
 
   Task* currentTask_{};
-  RuntimeSchedulerTimePoint lastYieldingOpportunity_;
-  RuntimeSchedulerDuration longestPeriodWithoutYieldingOpportunity_{};
+  HighResTimeStamp lastYieldingOpportunity_;
+  HighResTimeDuration longestPeriodWithoutYieldingOpportunity_{};
 
-  void markYieldingOpportunity(RuntimeSchedulerTimePoint currentTime);
+  void markYieldingOpportunity(HighResTimeStamp currentTime);
 
   /**
    * This protects the access to `taskQueue_` and `isevent loopScheduled_`.
@@ -179,7 +178,7 @@ class RuntimeScheduler_Modern final : public RuntimeSchedulerBase {
   void runEventLoop(jsi::Runtime& runtime, bool onlyExpired);
 
   std::shared_ptr<Task> selectTask(
-      RuntimeSchedulerTimePoint currentTime,
+      HighResTimeStamp currentTime,
       bool onlyExpired);
 
   void scheduleTask(std::shared_ptr<Task> task);
@@ -193,7 +192,7 @@ class RuntimeScheduler_Modern final : public RuntimeSchedulerBase {
   void runEventLoopTick(
       jsi::Runtime& runtime,
       Task& task,
-      RuntimeSchedulerTimePoint currentTime);
+      HighResTimeStamp taskStartTime);
 
   void executeTask(
       jsi::Runtime& runtime,
@@ -207,14 +206,14 @@ class RuntimeScheduler_Modern final : public RuntimeSchedulerBase {
 
   void reportLongTasks(
       const Task& task,
-      RuntimeSchedulerTimePoint startTime,
-      RuntimeSchedulerTimePoint endTime);
+      HighResTimeStamp startTime,
+      HighResTimeStamp endTime);
 
   /*
    * Returns a time point representing the current point in time. May be called
    * from multiple threads.
    */
-  std::function<RuntimeSchedulerTimePoint()> now_;
+  std::function<HighResTimeStamp()> now_;
 
   /*
    * Flag indicating if callback on JavaScript queue has been

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.h

@@ -12,15 +12,15 @@ namespace facebook::react {
 Task::Task(
     SchedulerPriority priority,
     jsi::Function&& callback,
-    std::chrono::steady_clock::time_point expirationTime)
+    HighResTimeStamp expirationTime)
     : priority(priority),
       callback(std::move(callback)),
       expirationTime(expirationTime) {}
 
 Task::Task(
     SchedulerPriority priority,
     RawCallback&& callback,
-    std::chrono::steady_clock::time_point expirationTime)
+    HighResTimeStamp expirationTime)
     : priority(priority),
       callback(std::move(callback)),
       expirationTime(expirationTime) {}