Fix differentiator emitting updates with incorrect parentTag #48055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66654293 |
javache
force-pushed
the
export-D66654293
branch
from
fb7be6f to
f0c0824
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Dec 3, 2024
…k#48055) Summary: Address the test-case identified in D66557919, where Differentiator could emit updates for views referencing an incorrect parentTag. The longer-term fix here is to avoid emitting any updates for nodes which are being reparented, but that requires bigger changes, including to the LayoutAnimation system. As a short-term patch, we're passing through an explicit `parentShadowViewForUpdate` which will be used as the current parent for update purposes. {F1971278019} Changelog: [Android][Fixed] Fix Fabric mutations sometimes triggering a `getViewState` crash when referencing an invalid parentTag. Differential Revision: D66654293
|
This pull request was exported from Phabricator. Differential Revision: D66654293 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Dec 3, 2024
…k#48055) Summary: Address the test-case identified in D66557919, where Differentiator could emit updates for views referencing an incorrect parentTag. The longer-term fix here is to avoid emitting any updates for nodes which are being reparented, but that requires bigger changes, including to the LayoutAnimation system. As a short-term patch, we're passing through an explicit `parentShadowViewForUpdate` which will be used as the current parent for update purposes. {F1971278019} Changelog: [Android][Fixed] Fix Fabric mutations sometimes triggering a `getViewState` crash when referencing an invalid parentTag. Differential Revision: D66654293
javache
added a commit
to javache/react-native
that referenced
this pull request
Dec 3, 2024
…k#48055) Summary: Address the test-case identified in D66557919, where Differentiator could emit updates for views referencing an incorrect parentTag. The longer-term fix here is to avoid emitting any updates for nodes which are being reparented, but that requires bigger changes, including to the LayoutAnimation system. As a short-term patch, we're passing through an explicit `parentShadowViewForUpdate` which will be used as the current parent for update purposes. {F1971278019} Changelog: [Android][Fixed] Fix Fabric mutations sometimes triggering a `getViewState` crash when referencing an invalid parentTag. Differential Revision: D66654293
…k#48055) Summary: Address the test-case identified in D66557919, where Differentiator could emit updates for views referencing an incorrect parentTag. The longer-term fix here is to avoid emitting any updates for nodes which are being reparented, but that requires bigger changes, including to the LayoutAnimation system. As a short-term patch, we're passing through an explicit `parentShadowViewForUpdate` which will be used as the current parent for update purposes. {F1971278019} Changelog: [Android][Fixed] Fix Fabric mutations sometimes triggering a `getViewState` crash when referencing an invalid parentTag. Reviewed By: rubennorte Differential Revision: D66654293
javache
force-pushed
the
export-D66654293
branch
from
f0c0824 to
ac84181
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66654293 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Dec 3, 2024
…k#48055) Summary: Address the test-case identified in D66557919, where Differentiator could emit updates for views referencing an incorrect parentTag. The longer-term fix here is to avoid emitting any updates for nodes which are being reparented, but that requires bigger changes, including to the LayoutAnimation system. As a short-term patch, we're passing through an explicit `parentShadowViewForUpdate` which will be used as the current parent for update purposes. {F1971278019} Changelog: [Android][Fixed] Fix Fabric mutations sometimes triggering a `getViewState` crash when referencing an invalid parentTag. Reviewed By: rubennorte Differential Revision: D66654293
|
This pull request has been merged in 34901d4. |
|
This pull request was successfully merged by @javache in 34901d4 When will my fix make it into a release? | How to file a pick request? |
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 11, 2025
Summary: We previously fixed Differentiator generating an incorrect parentTag (facebook#48055), but this can lead to crashes in Android UI due to reordering that happens in the Android mounting layer. While we have an experiment to disable this reordering (facebook#46702) this currently has a negative performance impact which needs to be addressed. As a mitigation, we can make the lookup of parentTag's ViewManager state nullable. We only require this to support `needsCustomLayoutForChildren`, which is not commonly used, and seems acceptable to drop in this scenario. Changelog: [Android][Changed] Do not crash when parent view state can't be found Differential Revision: D70966621
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 11, 2025
Summary: We previously fixed Differentiator generating an incorrect parentTag (facebook#48055), but this can lead to crashes in Android UI due to reordering that happens in the Android mounting layer. While we have an experiment to disable this reordering (facebook#46702) this currently has a negative performance impact which needs to be addressed. As a mitigation, we can make the lookup of parentTag's ViewManager state nullable. We only require this to support `needsCustomLayoutForChildren`, which is not commonly used, and seems acceptable to drop in this scenario. Changelog: [Android][Changed] Do not crash when parent view state can't be found Differential Revision: D70966621
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
Summary: Pull Request resolved: #49951 We previously fixed Differentiator generating an incorrect parentTag (#48055), but this can lead to crashes in Android UI due to reordering that happens in the Android mounting layer. While we have an experiment to disable this reordering (#46702) this currently has a negative performance impact which needs to be addressed. As a mitigation, we can make the lookup of parentTag's ViewManager state nullable. We only require this to support `needsCustomLayoutForChildren`, which is not commonly used, and seems acceptable to drop in this scenario. Changelog: [Android][Changed] Do not crash when parent view state can't be found Reviewed By: NickGerleman Differential Revision: D70966621 fbshipit-source-id: 33d0b6a90860788a4c9a8c6cea36c2c72c1392e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Address the test-case identified in D66557919, where Differentiator could emit updates for views referencing an incorrect parentTag.
The longer-term fix here is to avoid emitting any updates for nodes which are being reparented, but that requires bigger changes, including to the LayoutAnimation system. As a short-term patch, we're passing through an explicit
parentShadowViewForUpdatewhich will be used as the current parent for update purposes.Together with
disableMountItemReordering, I expect this to resolve #47960Changelog: [Android][Fixed] Fix Fabric mutations sometimes triggering a
getViewStatecrash when referencing an invalid parentTag.Differential Revision: D66654293