-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] RNTester: Fixes turbo module examples error in bridgeless mode #48362
[iOS] RNTester: Fixes turbo module examples error in bridgeless mode #48362
Conversation
@RSNara has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
packages/rn-tester/js/examples/TurboModule/NativeCxxModuleExampleExample.js
Outdated
Show resolved
Hide resolved
@mateoguzmana Amazing! Thank you for the test. 🤗 @RSNara help to review it? |
@christophpurrer @cortinico Seems #49028 try to fix turbo example in bridgeless mode. But it should throw the error in paper mode. Could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can take this on as @RSNara is currently off
This pull request was successfully merged by @zhongwuzw in 62831e7 When will my fix make it into a release? | How to file a pick request? |
@cortinico merged this pull request in 62831e7. |
…#49329) Summary: Reland #48362. ## Changelog: [IOS] [FIXED] - RNTester: Fixes turbo module examples error in bridgeless mode Pull Request resolved: #49329 Test Plan: RNTester turbomodule examples in bridgeless can work as expected. Reviewed By: christophpurrer Differential Revision: D69463612 Pulled By: cortinico fbshipit-source-id: 8613b001ebbe64ce0d505f5515bb7a4b6a64dbe7
Summary:
In #47598 , we removed
__turboModuleProxy
in bridgeless mode, it would produce error in rntester turbomodule examples, fix it by change__turboModuleProxy
tonativeModuleProxy
. @RSNara can you please help to review? :)before:

After:

Changelog:
[IOS] [FIXED] - RNTester: Fixes turbo module examples error in bridgeless mode
Test Plan:
RNTester turbomodule examples in bridgeless can work as expected.