Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] RNTester: Fixes turbo module examples error in bridgeless mode #48362

Closed
wants to merge 3 commits into from
Closed

[iOS] RNTester: Fixes turbo module examples error in bridgeless mode #48362

wants to merge 3 commits into from

Conversation

zhongwuzw
Copy link
Contributor

Summary:

In #47598 , we removed __turboModuleProxy in bridgeless mode, it would produce error in rntester turbomodule examples, fix it by change __turboModuleProxy to nativeModuleProxy. @RSNara can you please help to review? :)

before:
image

After:
image

Changelog:

[IOS] [FIXED] - RNTester: Fixes turbo module examples error in bridgeless mode

Test Plan:

RNTester turbomodule examples in bridgeless can work as expected.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Dec 23, 2024
@facebook-github-bot
Copy link
Contributor

@RSNara has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zhongwuzw zhongwuzw requested a review from RSNara January 3, 2025 02:13
@mateoguzmana
Copy link
Contributor

mateoguzmana commented Jan 17, 2025 •
edited
Loading

Btw, I just spotted this in Android and the TurboModule examples are broken there as well (not limited to iOS only). I tested these changes and works good for both now with it 🎉

@zhongwuzw
Copy link
Contributor Author

Btw, I just spotted this in Android and the TurboModule examples are broken there as well (not limited to iOS only). I tested these changes and works good for both now with it 🎉

@mateoguzmana Amazing! Thank you for the test. 🤗 @RSNara help to review it?

@zhongwuzw
Copy link
Contributor Author

@christophpurrer @cortinico Seems #49028 try to fix turbo example in bridgeless mode. But it should throw the error in paper mode. Could you please review this PR?

cortinico
cortinico approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take this on as @RSNara is currently off

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 11, 2025
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @zhongwuzw in 62831e7

When will my fix make it into a release? | How to file a pick request?

@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 62831e7.

@zhongwuzw zhongwuzw mentioned this pull request Feb 11, 2025
Closed
facebook-github-bot pushed a commit that referenced this pull request Feb 11, 2025
@zhongwuzw @facebook-github-bot
Reland RNTester: Fixes turbo module examples error in bridgeless mode (…
6a3e275 
…#49329)

Summary:
Reland #48362.

## Changelog:

[IOS] [FIXED] - RNTester: Fixes turbo module examples error in bridgeless mode

Pull Request resolved: #49329

Test Plan: RNTester turbomodule examples in bridgeless can work as expected.

Reviewed By: christophpurrer

Differential Revision: D69463612

Pulled By: cortinico

fbshipit-source-id: 8613b001ebbe64ce0d505f5515bb7a4b6a64dbe7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

@RSNara RSNara Awaiting requested review from RSNara

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhongwuzw @facebook-github-bot @mateoguzmana @react-native-bot @cortinico @RSNara