Re-enable the New Architecture by default #48755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The React-FabricComponent was importing some non-existent files when we build for iOS with cocoapods. This change fixes it. ## Changelog [Internal] - Only include ReactCommon and ios platform for TextInput Differential Revision: D68319960
Summary: [This commit](facebook@cc89ddd) introduced a dependency between RCTFabric and RCTAnimation because RCTFabric is now using `RCTInterpolateColorInRange` which is defined in `RCTAnimation`. To unblock the CI, I'm adding the dependency to the RCTFabric.podspec However, I'm not convinced that this is the proper fix. We should move the function to a common dependency between RCTFabric and RCTAnimation. Probably in `RCTUtils`. ## Changelog: [Internal] - Fix CI by making RCTFabric depend on RCTAnimation Differential Revision: D68322935
Summary: When [cleaning up the pre-alpha flags](facebook@9a4b2ce), we disabled the new architecture by default by mistake. This change fixes that. ## Changelog: [Internal] - Restore the New Arch by default Differential Revision: D68323159
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68323159 |
|
This pull request has been merged in eced906. |
kraenhansen
reviewed
Jan 21, 2025
| @@ -159,6 +159,6 @@ def self.extract_react_native_version(react_native_path, file_manager: File, jso | |||
| end | |||
|
|
|||
| def self.new_arch_enabled | |||
| return ENV["RCT_NEW_ARCH_ENABLED"] == nil || ENV["RCT_NEW_ARCH_ENABLED"] == "1" | |||
| return ENV["RCT_NEW_ARCH_ENABLED"] == 0 ? false : true | |||
There was a problem hiding this comment.
Suggested change
| return ENV["RCT_NEW_ARCH_ENABLED"] == 0 ? false : true | |
| return ENV["RCT_NEW_ARCH_ENABLED"] == "0" ? false : true |
Or perhaps even simpler
Suggested change
| return ENV["RCT_NEW_ARCH_ENABLED"] == 0 ? false : true | |
| return ENV["RCT_NEW_ARCH_ENABLED"] != "0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When cleaning up the pre-alpha flags, we disabled the new architecture by default by mistake.
This change fixes that.
Changelog:
[Internal] - Restore the New Arch by default
Differential Revision: D68323159