Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Libraries/JSInspector #49019

Closed
wants to merge 1 commit into from
Closed

Conversation

huntie
Copy link
Member

@huntie huntie commented Jan 28, 2025

Summary:
Removes the JSInspector class and its dependencies.

  • This was related to the legacy ReactCommon/inspector/ subsystem (D4021490) — which added a compat layer from JavaScriptCore to CDP for an earlier version of Chrome debugging.
  • The JS components of this system (JSInspector.js, NetworkAgent.js) were added in D4021516.

ReactCommon/inspector/ has since been deleted and these components are no longer load bearing.

  • We intend to replace this logic (at least, the archaic XHRInterceptor behaviour, which worked at one point) with native debugger Network domain support in our C++ layer.

Changes

  • Remove all modules under Libraries/JSInspector/.
  • Remove all XHRInterceptor call sites.
  • Remove the JSInspector.registerAgent() mount point in setUpDeveloperTools.js.
  • Exclude Libraries/Core/setUp* from public-api-test (these are side-effect setup files with no exported API).

Changelog:
[General][Breaking] - Remove legacy Libraries/JSInspector modules

Differential Revision: D68780147

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 28, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68780147

@huntie huntie closed this Jan 30, 2025
@huntie huntie deleted the export-D68780147 branch January 30, 2025 09:43
@huntie huntie restored the export-D68780147 branch January 30, 2025 09:45
@huntie huntie reopened this Jan 30, 2025
huntie added a commit to huntie/react-native that referenced this pull request Jan 30, 2025
Summary:

Legacy JS-based debugger implementation added in D4021516 — no longer referenced anywhere.

- Remove all modules under `Libraries/JSInspector/`.
- Remove all `XHRInterceptor` call sites.

We intend to replace this logic with native debugger `Network` domain support in our C++ layer.

Changelog:
[General][Breaking] - Remove Libraries/JSInspector modules

Reviewed By: christophpurrer

Differential Revision: D68780147
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68780147

huntie added a commit to huntie/react-native that referenced this pull request Jan 30, 2025
Summary:

Removes the `JSInspector` class and its dependencies.

- This was related to the legacy `ReactCommon/inspector/` subsystem (D4021490) — which added a compat layer from JavaScriptCore to CDP for an earlier version of Chrome debugging.
- The JS components of this system (`JSInspector.js`, `NetworkAgent.js`) were added in D4021516.

`ReactCommon/inspector/` has since been deleted and these components are no longer load bearing.

- We intend to replace this logic (at least, the archaic `XHRInterceptor` behaviour, which worked at one point) with native debugger `Network` domain support in our C++ layer.

**Changes**

- Remove all modules under `Libraries/JSInspector/`.
- Remove all `XHRInterceptor` call sites.
- Remove the `JSInspector.registerAgent()` mount point in `setUpDeveloperTools.js`.
- Exclude `Libraries/Core/setUp*` from `public-api-test` (these are side-effect setup files with no exported API).

Changelog:
[General][Breaking] - Remove legacy Libraries/JSInspector modules

Reviewed By: christophpurrer

Differential Revision: D68780147
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68780147

Summary:

Removes the `JSInspector` class and its dependencies.

- This was related to the legacy `ReactCommon/inspector/` subsystem (D4021490) — which added a compat layer from JavaScriptCore to CDP for an earlier version of Chrome debugging.
- The JS components of this system (`JSInspector.js`, `NetworkAgent.js`) were added in D4021516.

`ReactCommon/inspector/` has since been deleted and these components are no longer load bearing.

- We intend to replace this logic (at least, the archaic `XHRInterceptor` behaviour, which worked at one point) with native debugger `Network` domain support in our C++ layer.

**Changes**

- Remove all modules under `Libraries/JSInspector/`.
- Remove all `XHRInterceptor` call sites.
- Remove the `JSInspector.registerAgent()` mount point in `setUpDeveloperTools.js`.
- Exclude `Libraries/Core/setUp*` from `public-api-test` (these are side-effect setup files with no exported API).

Changelog:
[General][Breaking] - Remove legacy Libraries/JSInspector modules

Reviewed By: christophpurrer

Differential Revision: D68780147
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68780147

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @huntie in 9ba4dd8

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants