-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Libraries/JSInspector #49019
Delete Libraries/JSInspector #49019
Conversation
This pull request was exported from Phabricator. Differential Revision: D68780147 |
48283e4
to
3e3f81e
Compare
Summary: Legacy JS-based debugger implementation added in D4021516 — no longer referenced anywhere. - Remove all modules under `Libraries/JSInspector/`. - Remove all `XHRInterceptor` call sites. We intend to replace this logic with native debugger `Network` domain support in our C++ layer. Changelog: [General][Breaking] - Remove Libraries/JSInspector modules Reviewed By: christophpurrer Differential Revision: D68780147
This pull request was exported from Phabricator. Differential Revision: D68780147 |
Summary: Removes the `JSInspector` class and its dependencies. - This was related to the legacy `ReactCommon/inspector/` subsystem (D4021490) — which added a compat layer from JavaScriptCore to CDP for an earlier version of Chrome debugging. - The JS components of this system (`JSInspector.js`, `NetworkAgent.js`) were added in D4021516. `ReactCommon/inspector/` has since been deleted and these components are no longer load bearing. - We intend to replace this logic (at least, the archaic `XHRInterceptor` behaviour, which worked at one point) with native debugger `Network` domain support in our C++ layer. **Changes** - Remove all modules under `Libraries/JSInspector/`. - Remove all `XHRInterceptor` call sites. - Remove the `JSInspector.registerAgent()` mount point in `setUpDeveloperTools.js`. - Exclude `Libraries/Core/setUp*` from `public-api-test` (these are side-effect setup files with no exported API). Changelog: [General][Breaking] - Remove legacy Libraries/JSInspector modules Reviewed By: christophpurrer Differential Revision: D68780147
3e3f81e
to
8a27a9d
Compare
This pull request was exported from Phabricator. Differential Revision: D68780147 |
Summary: Removes the `JSInspector` class and its dependencies. - This was related to the legacy `ReactCommon/inspector/` subsystem (D4021490) — which added a compat layer from JavaScriptCore to CDP for an earlier version of Chrome debugging. - The JS components of this system (`JSInspector.js`, `NetworkAgent.js`) were added in D4021516. `ReactCommon/inspector/` has since been deleted and these components are no longer load bearing. - We intend to replace this logic (at least, the archaic `XHRInterceptor` behaviour, which worked at one point) with native debugger `Network` domain support in our C++ layer. **Changes** - Remove all modules under `Libraries/JSInspector/`. - Remove all `XHRInterceptor` call sites. - Remove the `JSInspector.registerAgent()` mount point in `setUpDeveloperTools.js`. - Exclude `Libraries/Core/setUp*` from `public-api-test` (these are side-effect setup files with no exported API). Changelog: [General][Breaking] - Remove legacy Libraries/JSInspector modules Reviewed By: christophpurrer Differential Revision: D68780147
8a27a9d
to
786c9dd
Compare
This pull request was exported from Phabricator. Differential Revision: D68780147 |
This pull request was successfully merged by @huntie in 9ba4dd8 When will my fix make it into a release? | How to file a pick request? |
Summary:
Removes the
JSInspector
class and its dependencies.ReactCommon/inspector/
subsystem (D4021490) — which added a compat layer from JavaScriptCore to CDP for an earlier version of Chrome debugging.JSInspector.js
,NetworkAgent.js
) were added in D4021516.ReactCommon/inspector/
has since been deleted and these components are no longer load bearing.XHRInterceptor
behaviour, which worked at one point) with native debuggerNetwork
domain support in our C++ layer.Changes
Libraries/JSInspector/
.XHRInterceptor
call sites.JSInspector.registerAgent()
mount point insetUpDeveloperTools.js
.Libraries/Core/setUp*
frompublic-api-test
(these are side-effect setup files with no exported API).Changelog:
[General][Breaking] - Remove legacy Libraries/JSInspector modules
Differential Revision: D68780147