-
Notifications
You must be signed in to change notification settings - Fork 47.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix react/dom parse style array #25548 #25549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some tests for server rendering, client rendering and hydration?
Not sure if this will accepted given that this can be implemented in userland by just merging/spreading the objects
Use |
You're changing code for rendering react-dom components though. Rendering components that target a different renderer (here: react-native) is not supported by It sounds like you have a use case for rendering React Native to a string? I would suggest filing this as a feature request against https://github.com/facebook/react-native |
Do React consider adding array style properties? I think it's very useful. |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Summary
How did you test this change?