Promote redex-staging to redex-stable

Summary:
allow-large-files

run_all_fbandroid_tests
run_all_fbandroid_tests_at_diff_time

Sync redex-stable with the contents of redex-staging at revision 5b79daa4951d.

Reviewed By: xuhdev

Differential Revision: D102097160

fbshipit-source-id: df83f191cd135158de29bc4df7662330bfac5cc7

Author: ssj933

.clang-tidy

@@ -32,3 +32,5 @@ WarningsAsErrors: 'performance-*,readability-*,misc-definitions-in-headers,moder
 CheckOptions:
   - key: modernize-use-override.IgnoreDestructors
     value: 1
+  - key: bugprone-signed-char-misuse.CharTypdefsToIgnore
+    value: "int8_t"

.github/workflows/build_and_test.yml

@@ -27,7 +27,7 @@ jobs:
       run: cat /etc/os-release
     - name: Install prerequisites for checking out the repo
       run: apt-get update && apt-get install -y --no-install-recommends ca-certificates git-core
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v6
     - uses: "./.github/actions/prepare_debian"
     - uses: ./.github/actions/setup-build-and-test-w-make
       with:
@@ -53,7 +53,7 @@ jobs:
         - 19
         - 18
     steps:
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v6
     - uses: "./.github/actions/prepare_debian"
       with:
         install_clang_llvm_org: "${{ matrix.clang_version }}"
@@ -66,5 +66,5 @@ jobs:
   build-windows:
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v6
     - uses: "./.github/actions/setup-build-and-test-windows"

.github/workflows/build_nightly.yml

@@ -11,9 +11,9 @@ jobs:
   build-windows-artifacts:
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v6
     - uses: "./.github/actions/setup-build-and-test-windows"
-    - uses: actions/upload-artifact@v4.0.0
+    - uses: actions/upload-artifact@v6
       with:
         name: redex-windows
         retention-days: 7

.github/workflows/deploy-gh-pages.yml

@@ -16,8 +16,8 @@ jobs:
       run:
         working-directory: website
     steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
+      - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
         with:
           node-version: 22
           cache: yarn
@@ -29,7 +29,7 @@ jobs:
         run: yarn build
 
       - name: Upload GitHub Pages build artifacts
-        uses: actions/upload-pages-artifact@v3
+        uses: actions/upload-pages-artifact@v4
         with:
           path: website/build
 

Makefile.am

@@ -152,7 +152,6 @@ libredex_la_SOURCES = \
 	libredex/DexUtil.cpp \
 	libredex/DexStoreUtil.cpp \
 	libredex/DuplicateClasses.cpp \
-	libredex/EditableCfgAdapter.cpp \
 	libredex/FbjniMarker.cpp \
 	libredex/FrameworkApi.cpp \
 	libredex/FrequentlyUsedPointersCache.cpp \
@@ -226,7 +225,6 @@ libredex_la_SOURCES = \
 	libredex/RefChecker.cpp \
 	libredex/RemoveUninstantiablesImpl.cpp \
 	libredex/Resolver.cpp \
-	libredex/ScopedMetrics.cpp \
 	libredex/Show.cpp \
 	libredex/SourceBlockConsistencyCheck.cpp \
 	libredex/SourceBlocks.cpp \
@@ -528,6 +526,7 @@ libopt_la_SOURCES = \
 	opt/string_concatenator/StringConcatenator.cpp \
 	opt/stringbuilder-outliner/StringBuilderOutliner.cpp \
 	opt/strip-debug-info/StripDebugInfo.cpp \
+	opt/optimize_resources/LowerResourceConstants.cpp \
 	opt/optimize_resources/MaterializeResourceConstants.cpp \
 	opt/optimize_resources/OptimizeResources.cpp \
 	opt/typedef-anno-checker/TypedefAnnoCheckerPass.cpp \

RELEASE

@@ -1 +1 @@
-2025-09-22
+2026-04-23

analysis/ip-reflection-analysis/IPReflectionAnalysis.cpp

@@ -15,8 +15,7 @@
 
 #include "CallGraph.h"
 #include "ConfigFiles.h"
-#include "MethodOverrideGraph.h"
-#include "Resolver.h"
+#include "DexUtil.h"
 #include "Show.h"
 #include "SpartaInterprocedural.h"
 
@@ -233,7 +232,7 @@ void IPReflectionAnalysisPass::run_pass(DexStoresVector& stores,
 
   Scope scope = build_class_scope(stores);
   AnalysisParameters param;
-  auto analysis = Analysis(scope, m_max_iteration, &param);
+  auto analysis = Analysis(scope, static_cast<int>(m_max_iteration), &param);
   analysis.run();
   const auto& summaries = analysis.registry.get_map();
   m_result = std::make_shared<Result>();
@@ -247,7 +246,7 @@ void IPReflectionAnalysisPass::run_pass(DexStoresVector& stores,
 
     for (const auto& entry : UnorderedIterable(*m_result)) {
       if (!entry.second.empty()) {
-        file << show(entry.first) << " -> " << entry.second << std::endl;
+        file << show(entry.first) << " -> " << entry.second << '\n';
       }
     }
   }

analysis/max-depth/MaxDepthAnalysis.cpp

@@ -11,10 +11,11 @@
 #include <sparta/ConstantAbstractDomain.h>
 #include <sparta/HashedSetAbstractDomain.h>
 
-#include "ControlFlow.h"
 #include "DexClass.h"
-#include "IRCode.h"
+#include "DexUtil.h"
+
 #include "IRInstruction.h"
+#include "Resolver.h"
 #include "SpartaInterprocedural.h"
 
 namespace {
@@ -143,7 +144,7 @@ class MaxDepthFunctionAnalyzer : public Base {
   void analyze_invoke(IRInstruction* insn) {
     auto* callee = insn->get_method();
     auto* callee_method =
-        resolve_method(callee, opcode_to_search(insn), m_method);
+        resolve_method_deprecated(callee, opcode_to_search(insn), m_method);
     if (callee_method != nullptr) {
       auto summary =
           this->get_summaries()->get(callee_method, DepthDomain::top());
@@ -186,13 +187,16 @@ using Analysis = InterproceduralAnalyzer<MaxDepthAnalysisAdaptor>;
 void MaxDepthAnalysisPass::run_pass(DexStoresVector& stores,
                                     ConfigFiles& /* conf */,
                                     PassManager& /* pm */) {
-  auto analysis = Analysis(build_class_scope(stores), m_max_iteration);
+  auto analysis =
+      Analysis(build_class_scope(stores), static_cast<int>(m_max_iteration));
   analysis.run();
   m_result = std::make_shared<UnorderedMap<const DexMethod*, int>>();
 
   for (const auto& entry : UnorderedIterable(analysis.registry.get_map())) {
     if (entry.second.is_value()) {
-      (*m_result)[entry.first] = entry.second.depth();
+      auto depth = entry.second.depth();
+      always_assert(depth <= std::numeric_limits<int>::max());
+      (*m_result)[entry.first] = static_cast<int>(depth);
     }
   }
 }

checkers/DexLimitsChecker.cpp

@@ -104,16 +104,16 @@ std::string print_new_entries(const dex_data_map_t& old_map_vec,
     // and only translate them when we find an issue.
     UnorderedSet<DexFieldRef*> fields;
     UnorderedSet<DexMethodRef*> methods;
-    UnorderedSet<DexType*> types;
+    UnorderedSet<const DexType*> types;
     // Share memory. Lifetimes are OK because confined to this function.
-    const UnorderedSet<DexType*>& pending_init_class_fields;
-    const UnorderedSet<DexType*>& pending_init_class_types;
+    const UnorderedSet<const DexType*>& pending_init_class_fields;
+    const UnorderedSet<const DexType*>& pending_init_class_types;
 
     DexDataWithSet(UnorderedSet<DexFieldRef*> f,
                    UnorderedSet<DexMethodRef*> m,
-                   UnorderedSet<DexType*> t,
-                   const UnorderedSet<DexType*>& p_f,
-                   const UnorderedSet<DexType*>& p_t)
+                   UnorderedSet<const DexType*> t,
+                   const UnorderedSet<const DexType*>& p_f,
+                   const UnorderedSet<const DexType*>& p_t)
         : fields(std::move(f)),
           methods(std::move(m)),
           types(std::move(t)),

checkers/DexLimitsChecker.h

@@ -31,10 +31,10 @@ class DexLimitsChecker : public PropertyChecker {
     // and only translate them when we find an issue.
     std::vector<DexFieldRef*> fields;
     std::vector<DexMethodRef*> methods;
-    std::vector<DexType*> types;
+    std::vector<const DexType*> types;
     // These are hopefully small and transitioning is annoying.
-    UnorderedSet<DexType*> pending_init_class_fields;
-    UnorderedSet<DexType*> pending_init_class_types;
+    UnorderedSet<const DexType*> pending_init_class_fields;
+    UnorderedSet<const DexType*> pending_init_class_types;
   };
 
   UnorderedMap<std::string, std::vector<DexData>> m_data;