Add annotations to fix future natural inference errors in xplat/js: 2/n

Reviewed By: andrewdacenko

Differential Revision: D80266000

fbshipit-source-id: 3bcaa439cfc6f24de0c75f1c0f321b1924fe076a

Author: SamChou19815

packages/react-relay/ReactRelayPaginationContainer.js

@@ -750,12 +750,12 @@ function createContainerWithFragments<
     }
 
     _fetchPage(
-      paginatingVariables: {
+      paginatingVariables: $ReadOnly<{
         count: number,
         cursor: ?string,
         totalCount: number,
         ...
-      },
+      }>,
       observer: Observer<void>,
       options: ?RefetchOptions,
     ): Subscription {

packages/react-relay/ReactRelayQueryRenderer.js

@@ -105,7 +105,7 @@ class ReactRelayQueryRenderer extends React.Component<Props, State> {
     // "leak" them before mounting (since we would be unable to clean up). For
     // that reason, we define them as null initially and fill them in after
     // mounting to avoid leaking memory.
-    const retryCallbacks = {
+    const retryCallbacks: RetryCallbacks = {
       handleDataChange: null,
       handleRetryAfterError: null,
     };

packages/react-relay/__tests__/ReactRelayTestMocker-test.js

@@ -99,7 +99,7 @@ describe('ReactRelayTestMocker', () => {
     });
 
     it('updates properly via default values', () => {
-      const testQueryDefault = {
+      const testQueryDefault: NetworkWriteConfig = {
         query: ReactRelayTestMockerTestQuery,
         payload: {data: payload},
       };

packages/react-relay/relay-hooks/__tests__/useMutation-fast-refresh-test.js

@@ -11,6 +11,8 @@
 
 'use strict';
 
+import type {useMutationFastRefreshTestCommentCreateMutation$variables} from './__generated__/useMutationFastRefreshTestCommentCreateMutation.graphql';
+
 const RelayEnvironmentProvider = require('../RelayEnvironmentProvider');
 const useMutation = require('../useMutation');
 const React = require('react');
@@ -40,7 +42,7 @@ describe('useLazyLoadQueryNode', () => {
     },
   };
 
-  const variables = {
+  const variables: useMutationFastRefreshTestCommentCreateMutation$variables = {
     input: {
       feedbackId: '<id>',
     },

packages/react-relay/relay-hooks/__tests__/usePreloadedQuery-test.js

@@ -62,7 +62,7 @@ const preloadableConcreteRequest: PreloadableConcreteRequest<usePreloadedQueryTe
     params: query.params,
   };
 
-const response = {
+const response: GraphQLResponse = {
   data: {
     node: {
       __typename: 'User',
@@ -75,7 +75,7 @@ const response = {
   },
 };
 
-const responseRefetch = {
+const responseRefetch: GraphQLResponse = {
   data: {
     node: {
       __typename: 'User',

packages/relay-runtime/mutations/__tests__/commitMutation-test.js

@@ -14,6 +14,9 @@ import type {GraphQLResponseWithoutData} from '../../network/RelayNetworkTypes';
 import type {Snapshot} from '../../store/RelayStoreTypes';
 import type {RecordSourceSelectorProxy} from '../../store/RelayStoreTypes';
 import type {DeclarativeMutationConfig} from '../RelayDeclarativeMutationConfig';
+import type {commitMutationTest1Mutation$variables} from './__generated__/commitMutationTest1Mutation.graphql';
+import type {commitMutationTest2Mutation$variables} from './__generated__/commitMutationTest2Mutation.graphql';
+import type {commitMutationTest3Mutation$variables} from './__generated__/commitMutationTest3Mutation.graphql';
 import type {
   commitMutationTest4Query$data,
   commitMutationTest4Query$variables,
@@ -63,7 +66,9 @@ describe('Configs: NODE_DELETE', () => {
     const feedbackID = 'feedback123';
     const firstCommentID = 'comment456';
     const secondCommentID = 'comment789';
-    const variables = {
+    const variables: commitMutationTest1Mutation$variables = {
+      /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
+       * commitMutation */
       input: {
         deletedCommentId: firstCommentID,
       },
@@ -150,8 +155,6 @@ describe('Configs: NODE_DELETE', () => {
       optimisticResponse,
       optimisticUpdater,
       updater,
-      /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
-       * commitMutation */
       variables,
     });
     expect(callback.mock.calls.length).toBe(1);
@@ -202,7 +205,7 @@ describe('Configs: RANGE_DELETE', () => {
       }
     `;
     const commentID = 'comment123';
-    const variables = {
+    const variables: commitMutationTest2Mutation$variables = {
       input: {
         commentId: commentID,
       },
@@ -353,7 +356,7 @@ describe('Configs: RANGE_DELETE', () => {
         pathToConnection: ['actor', 'friends'],
       },
     ];
-    const variables = {
+    const variables: commitMutationTest3Mutation$variables = {
       input: {
         friendId: '456',
       },

packages/relay-runtime/subscription/__tests__/requestSubscription-test.js

@@ -15,6 +15,7 @@ import type {GraphQLResponse} from '../../network/RelayNetworkTypes';
 import type {RecordSourceSelectorProxy} from '../../store/RelayStoreTypes';
 import type {RequestParameters} from '../../util/RelayConcreteNode';
 import type {CacheConfig, Variables} from '../../util/RelayRuntimeTypes';
+import type {requestSubscriptionTest1CommentCreateSubscription$variables} from './__generated__/requestSubscriptionTest1CommentCreateSubscription.graphql';
 
 const RelayNetwork = require('../../network/RelayNetwork');
 const RelayObservable = require('../../network/RelayObservable');
@@ -203,12 +204,13 @@ describe('requestSubscription-test', () => {
     const metadata = {
       text: 'Gave Relay',
     };
-    const variables = {
-      input: {
-        feedbackId,
-        text: secondCommentBody,
-      },
-    };
+    const variables: requestSubscriptionTest1CommentCreateSubscription$variables =
+      {
+        input: {
+          feedbackId,
+          text: secondCommentBody,
+        },
+      };
 
     beforeEach(() => {
       CommentCreateSubscription = graphql`