Report diagnostic when schema shards don't form a complete SDL document

Differential Revision: D114452812

fbshipit-source-id: cbfa55643fc32fcf206863f3aecf1e213f642ddf

Author: captbaritone

compiler/crates/relay-compiler/tests/relay_compiler_integration/fixtures/schema_incomplete_last_shard.expected

@@ -0,0 +1,37 @@
+==================================== INPUT ====================================
+//- src/App.js
+graphql`
+  query AppQuery {
+    greeting
+  }
+`
+
+//- relay.config.json
+{
+  "sources": {
+    "src": "test_project"
+  },
+  "projects": {
+    "test_project": {
+      "language": "flow",
+      "schemaDir": "./schema"
+    }
+  }
+}
+
+//- schema/0000.graphql
+type Query {
+  greeting: String
+}
+
+//- schema/0001.graphql
+type Mutation {
+  create_thing: String
+==================================== OUTPUT ===================================
+✖︎ Schema shard files did not form a complete SDL document — the last file in the sequence did not end with `}`.
+
+All files processed in order:
+  1: schema/0000.graphql
+  2: schema/0001.graphql
+
+<generated>: <missing source>

compiler/crates/relay-compiler/tests/relay_compiler_integration/fixtures/schema_incomplete_last_shard.input

@@ -0,0 +1,28 @@
+//- src/App.js
+graphql`
+  query AppQuery {
+    greeting
+  }
+`
+
+//- relay.config.json
+{
+  "sources": {
+    "src": "test_project"
+  },
+  "projects": {
+    "test_project": {
+      "language": "flow",
+      "schemaDir": "./schema"
+    }
+  }
+}
+
+//- schema/0000.graphql
+type Query {
+  greeting: String
+}
+
+//- schema/0001.graphql
+type Mutation {
+  create_thing: String

compiler/crates/relay-compiler/tests/relay_compiler_integration_test.rs

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<4fa0284246e2d17615f4a165bec3297e>>
+ * @generated SignedSource<<a04527254ed592c40836185646d8c1cc>>
  */
 
 mod relay_compiler_integration;
@@ -845,6 +845,13 @@ async fn schema_in_generated_dir() {
     test_fixture(transform_fixture, file!(), "schema_in_generated_dir.input", "relay_compiler_integration/fixtures/schema_in_generated_dir.expected", input, expected).await;
 }
 
+#[tokio::test]
+async fn schema_incomplete_last_shard() {
+    let input = include_str!("relay_compiler_integration/fixtures/schema_incomplete_last_shard.input");
+    let expected = include_str!("relay_compiler_integration/fixtures/schema_incomplete_last_shard.expected");
+    test_fixture(transform_fixture, file!(), "schema_incomplete_last_shard.input", "relay_compiler_integration/fixtures/schema_incomplete_last_shard.expected", input, expected).await;
+}
+
 #[tokio::test]
 async fn schema_outside_root_dir() {
     let input = include_str!("relay_compiler_integration/fixtures/schema_outside_root_dir.input");

compiler/crates/schema/src/errors.rs

@@ -57,4 +57,11 @@ pub enum SchemaError {
 
     #[error("The directive `@{0}` can only be used once at this location, but was used {1} times.")]
     RepeatedNonRepeatableDirective(StringKey, usize),
+
+    #[error(
+        "Schema shard files did not form a complete SDL document — the last file in the sequence \
+         did not end with `}}`.\n\n\
+         All files processed in order:\n{all_files}"
+    )]
+    IncompleteSchemaDocument { all_files: String },
 }

compiler/crates/schema/src/lib.rs

@@ -22,7 +22,9 @@ mod schema;
 pub mod suggestion_list;
 use std::borrow::Cow;
 
+use common::Diagnostic;
 use common::DiagnosticsResult;
+use common::Location;
 use common::SourceLocationKey;
 use common::sync::IntoParallelIterator;
 use common::sync::ParallelIterator;
@@ -124,7 +126,16 @@ pub fn parse_schema_with_extensions_parallel<
                 }
             }
             if !buffer.is_empty() {
-                eprintln!("Incomplete schema document:  {buffer}")
+                let all_files = server_sdls
+                    .iter()
+                    .enumerate()
+                    .map(|(i, (_, loc))| format!("  {}: {}", i + 1, loc.path()))
+                    .collect::<Vec<_>>()
+                    .join("\n");
+                return Err(vec![Diagnostic::error(
+                    errors::SchemaError::IncompleteSchemaDocument { all_files },
+                    Location::generated(),
+                )]);
             }
             chunks
         }