Fix schema cache not invalidated on base project schema changes

Reviewed By: tyao1

Differential Revision: D95480527

fbshipit-source-id: 526f039aa2fe10954dc0a44232c856d4a83a96df

Author: evanyeung

compiler/crates/relay-compiler/src/build_project/build_schema.rs

@@ -37,6 +37,9 @@ pub fn build_schema(
 ) -> DiagnosticsResult<Arc<SDLSchema>> {
     if let Some(schema) = compiler_state.schema_cache.get(&project_config.name)
         && !compiler_state.project_has_pending_schema_changes(project_config.name)
+        && !project_config
+            .base
+            .is_some_and(|base| compiler_state.project_has_pending_schema_changes(base))
     {
         return Ok(schema.clone());
     }

compiler/crates/relay-compiler/tests/relay_compiler_integration/fixtures/incremental_base_project_extension_change.expected

@@ -1,6 +1,4 @@
 ==================================== INPUT ====================================
-// expected-to-throw
-
 # Incremental extension change in a base project.
 #
 # The base project declares schemaExtensions. The derived project inherits
@@ -52,206 +50,7 @@ extend type User { greeting: String }
 
 //-++ extensions/extensions.graphql
 extend type User { greeting: Int }
-==================================== ERROR ====================================
-INCREMENTAL COMPILATION BUG DETECTED!
-
-Incremental and full results differ!
-
-Incremental:
-//-++ base_src/__generated__/baseQuery.graphql.ts
-/**
- * <auto-generated> SignedSource<<727797988d2f882d29c10e160c1d6b42>>
- * @lightSyntaxTransform
- * @nogrep
- */
-
-/* tslint:disable */
-/* eslint-disable */
-// @ts-nocheck
-
-import { ConcreteRequest } from 'relay-runtime';
-export type baseQuery$variables = Record<PropertyKey, never>;
-export type baseQuery$data = {
-  readonly me: {
-    readonly greeting: number | null | undefined;
-    readonly name: string | null | undefined;
-  } | null | undefined;
-};
-export type baseQuery = {
-  response: baseQuery$data;
-  variables: baseQuery$variables;
-};
-
-const node: ConcreteRequest = (function(){
-var v0 = [
-  {
-    "alias": null,
-    "args": null,
-    "concreteType": "User",
-    "kind": "LinkedField",
-    "name": "me",
-    "plural": false,
-    "selections": [
-      {
-        "alias": null,
-        "args": null,
-        "kind": "ScalarField",
-        "name": "name",
-        "storageKey": null
-      },
-      {
-        "kind": "ClientExtension",
-        "selections": [
-          {
-            "alias": null,
-            "args": null,
-            "kind": "ScalarField",
-            "name": "greeting",
-            "storageKey": null
-          }
-        ]
-      }
-    ],
-    "storageKey": null
-  }
-];
-return {
-  "fragment": {
-    "argumentDefinitions": [],
-    "kind": "Fragment",
-    "metadata": null,
-    "name": "baseQuery",
-    "selections": (v0/*:: as any*/),
-    "type": "Query",
-    "abstractKey": null
-  },
-  "kind": "Request",
-  "operation": {
-    "argumentDefinitions": [],
-    "kind": "Operation",
-    "name": "baseQuery",
-    "selections": (v0/*:: as any*/)
-  },
-  "params": {
-    "cacheID": "d5cea3113e4596144322cb752d654634",
-    "id": null,
-    "metadata": {},
-    "name": "baseQuery",
-    "operationKind": "query",
-    "text": "query baseQuery {\n  me {\n    name\n  }\n}\n"
-  }
-};
-})();
-
-(node as any).hash = "ecd4d927c59e2991af88dbaaf9dc1b8f";
-
-export default node;
-
-//-++ derived_src/__generated__/derivedQuery.graphql.ts
-/**
- * <auto-generated> SignedSource<<572f18ffaf2c398899f3731a7844e457>>
- * @lightSyntaxTransform
- * @nogrep
- */
-
-/* tslint:disable */
-/* eslint-disable */
-// @ts-nocheck
-
-import { ConcreteRequest } from 'relay-runtime';
-export type derivedQuery$variables = Record<PropertyKey, never>;
-export type derivedQuery$data = {
-  readonly me: {
-    readonly greeting: string | null | undefined;
-    readonly name: string | null | undefined;
-  } | null | undefined;
-};
-export type derivedQuery = {
-  response: derivedQuery$data;
-  variables: derivedQuery$variables;
-};
-
-const node: ConcreteRequest = (function(){
-var v0 = [
-  {
-    "alias": null,
-    "args": null,
-    "concreteType": "User",
-    "kind": "LinkedField",
-    "name": "me",
-    "plural": false,
-    "selections": [
-      {
-        "alias": null,
-        "args": null,
-        "kind": "ScalarField",
-        "name": "name",
-        "storageKey": null
-      },
-      {
-        "kind": "ClientExtension",
-        "selections": [
-          {
-            "alias": null,
-            "args": null,
-            "kind": "ScalarField",
-            "name": "greeting",
-            "storageKey": null
-          }
-        ]
-      }
-    ],
-    "storageKey": null
-  }
-];
-return {
-  "fragment": {
-    "argumentDefinitions": [],
-    "kind": "Fragment",
-    "metadata": null,
-    "name": "derivedQuery",
-    "selections": (v0/*:: as any*/),
-    "type": "Query",
-    "abstractKey": null
-  },
-  "kind": "Request",
-  "operation": {
-    "argumentDefinitions": [],
-    "kind": "Operation",
-    "name": "derivedQuery",
-    "selections": (v0/*:: as any*/)
-  },
-  "params": {
-    "cacheID": "90badf053dbd4901c413786a75ea0a0e",
-    "id": null,
-    "metadata": {},
-    "name": "derivedQuery",
-    "operationKind": "query",
-    "text": "query derivedQuery {\n  me {\n    name\n  }\n}\n"
-  }
-};
-})();
-
-(node as any).hash = "28b08d763d5e75fd97b936b19b19f5bb";
-
-export default node;
-
-
-
-Artifact Map:
-Project: base_project
-  Type: Mapping
-  - Source: ExecutableDefinition: baseQuery
-    Path: base_src/__generated__/baseQuery.graphql.ts
-
-Project: derived_project
-  Type: Mapping
-  - Source: ExecutableDefinition: derivedQuery
-    Path: derived_src/__generated__/derivedQuery.graphql.ts
-
-
-
-Full:
+==================================== OUTPUT ===================================
 //-++ base_src/__generated__/baseQuery.graphql.ts
 /**
  * <auto-generated> SignedSource<<727797988d2f882d29c10e160c1d6b42>>

compiler/crates/relay-compiler/tests/relay_compiler_integration/fixtures/incremental_base_project_extension_change.input

@@ -1,5 +1,3 @@
-// expected-to-throw
-
 # Incremental extension change in a base project.
 #
 # The base project declares schemaExtensions. The derived project inherits