Fix @refetchable preferFetchable boolean value being ignored

Reviewed By: tyao1

Differential Revision: D95477999

fbshipit-source-id: 8dd7e95350d8de5dc03ed71edfe09c0bc1ee999a

Author: evanyeung

compiler/crates/relay-transforms/src/refetchable_fragment/refetchable_directive.rs

@@ -125,7 +125,20 @@ impl RefetchableDirective {
                     )])
                 }?
             } else if argument.name.item == *PREFER_FETCHABLE_ARG {
-                prefer_fetchable = true
+                if let Value::Constant(ConstantValue::Boolean(val)) = argument.value.item {
+                    prefer_fetchable = val;
+                } else {
+                    return Err(vec![Diagnostic::error(
+                        ValidationMessage::ExpectPreferFetchableToBeConstantBoolean {
+                            prefer_fetchable_value: print_value(
+                                schema,
+                                &argument.value.item,
+                                PrinterOptions::default(),
+                            ),
+                        },
+                        argument.name.location,
+                    )]);
+                }
             } else {
                 // should be validated by general directive validations
                 panic!(

compiler/crates/relay-transforms/src/refetchable_fragment/validation_message.rs

@@ -122,6 +122,11 @@ pub(super) enum ValidationMessage {
     )]
     ExpectQueryNameToBeString { query_name_value: String },
 
+    #[error(
+        "Expected the 'preferFetchable' argument of @refetchable to be a literal Boolean value, got '{prefer_fetchable_value}'"
+    )]
+    ExpectPreferFetchableToBeConstantBoolean { prefer_fetchable_value: String },
+
     #[error(
         "Fragment variable `${name}` conflicts with a global variable generated by the @refetchable generated query"
     )]

compiler/crates/relay-transforms/tests/refetchable_fragment/fixtures/refetchable-prefer-fetchable-false-uses-node.expected

@@ -17,7 +17,7 @@ query RefetchableFragmentQuery(
 #     ),
 # )
  {
-  fetch__FetchableType(fetch_id: $id) {
+  node(id: $id) {
     ...RefetchableFragment
   }
 }
@@ -28,16 +28,17 @@ fragment RefetchableFragment on FetchableType @refetchable(queryName: "Refetchab
 #         "RefetchableFragmentQuery",
 #     ),
 #     path: [
-#         "fetch__FetchableType",
+#         "node",
 #     ],
 #     identifier_info: Some(
 #         RefetchableIdentifierInfo {
-#             identifier_field: "fetch_id",
+#             identifier_field: "id",
 #             identifier_query_variable_name: "id",
 #         },
 #     ),
 #     is_prefetchable_pagination: false,
 # }
  {
   fetch_id
+  id
 }

compiler/crates/relay-transforms/tests/refetchable_fragment/fixtures/refetchable-prefer-fetchable-non-constant.invalid.expected

@@ -0,0 +1,17 @@
+==================================== INPUT ====================================
+# expected-to-throw
+# The preferFetchable argument must be a literal Boolean value,
+# not a variable reference.
+fragment RefetchableFragment on FetchableType
+  @refetchable(queryName: "RefetchableFragmentQuery", preferFetchable: $preferFetchable)
+  @argumentDefinitions(preferFetchable: {type: "Boolean!"}) {
+  fetch_id
+}
+==================================== ERROR ====================================
+✖︎ Expected the 'preferFetchable' argument of @refetchable to be a literal Boolean value, got '$preferFetchable'
+
+  refetchable-prefer-fetchable-non-constant.invalid.graphql:5:55
+    4 │ fragment RefetchableFragment on FetchableType
+    5 │   @refetchable(queryName: "RefetchableFragmentQuery", preferFetchable: $preferFetchable)
+      │                                                       ^^^^^^^^^^^^^^^
+    6 │   @argumentDefinitions(preferFetchable: {type: "Boolean!"}) {

compiler/crates/relay-transforms/tests/refetchable_fragment/fixtures/refetchable-prefer-fetchable-non-constant.invalid.graphql

@@ -0,0 +1,8 @@
+# expected-to-throw
+# The preferFetchable argument must be a literal Boolean value,
+# not a variable reference.
+fragment RefetchableFragment on FetchableType
+  @refetchable(queryName: "RefetchableFragmentQuery", preferFetchable: $preferFetchable)
+  @argumentDefinitions(preferFetchable: {type: "Boolean!"}) {
+  fetch_id
+}

compiler/crates/relay-transforms/tests/refetchable_fragment_test.rs

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<174358d8fb5b8abb9eb20e7994daa41e>>
+ * @generated SignedSource<<4f2114418f17cd3a52a3694c396d65f6>>
  */
 
 mod refetchable_fragment;
@@ -235,3 +235,10 @@ async fn refetchable_prefer_fetchable_false_uses_node() {
     let expected = include_str!("refetchable_fragment/fixtures/refetchable-prefer-fetchable-false-uses-node.expected");
     test_fixture(transform_fixture, file!(), "refetchable-prefer-fetchable-false-uses-node.graphql", "refetchable_fragment/fixtures/refetchable-prefer-fetchable-false-uses-node.expected", input, expected).await;
 }
+
+#[tokio::test]
+async fn refetchable_prefer_fetchable_non_constant_invalid() {
+    let input = include_str!("refetchable_fragment/fixtures/refetchable-prefer-fetchable-non-constant.invalid.graphql");
+    let expected = include_str!("refetchable_fragment/fixtures/refetchable-prefer-fetchable-non-constant.invalid.expected");
+    test_fixture(transform_fixture, file!(), "refetchable-prefer-fetchable-non-constant.invalid.graphql", "refetchable_fragment/fixtures/refetchable-prefer-fetchable-non-constant.invalid.expected", input, expected).await;
+}