Fix infinite loop when extracting bare graphql token

Reviewed By: evanyeung

Differential Revision: D94980372

fbshipit-source-id: db76c03d279d957df21f6ba3daaa429b9e860288

Author: captbaritone

compiler/crates/extract-graphql/src/lib.rs

@@ -152,6 +152,9 @@ pub fn extract(input: &str) -> Vec<JavaScriptSourceFeature> {
                                 continue 'code;
                             }
                         }
+                    } else {
+                        // EOF reached without finding a backtick
+                        continue 'code;
                     }
                 }
                 let start = i;

compiler/crates/extract-graphql/tests/extract/fixtures/bare_graphql_token.expected

@@ -0,0 +1,12 @@
+==================================== INPUT ====================================
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+// A bare `graphql` token at the end of a file without a template literal
+// should not cause the extractor to loop infinitely.
+graphql
+==================================== OUTPUT ===================================

compiler/crates/extract-graphql/tests/extract/fixtures/bare_graphql_token.js

@@ -0,0 +1,10 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+// A bare `graphql` token at the end of a file without a template literal
+// should not cause the extractor to loop infinitely.
+graphql

compiler/crates/extract-graphql/tests/extract_test.rs

@@ -4,14 +4,21 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<a6880296f247ee9d9d2e312d6c26b4a2>>
+ * @generated SignedSource<<3c2cb388d73f2904eee16c3b407de258>>
  */
 
 mod extract;
 
 use extract::transform_fixture;
 use fixture_tests::test_fixture;
 
+#[tokio::test]
+async fn bare_graphql_token() {
+    let input = include_str!("extract/fixtures/bare_graphql_token.js");
+    let expected = include_str!("extract/fixtures/bare_graphql_token.expected");
+    test_fixture(transform_fixture, file!(), "bare_graphql_token.js", "extract/fixtures/bare_graphql_token.expected", input, expected).await;
+}
+
 #[tokio::test]
 async fn comments() {
     let input = include_str!("extract/fixtures/comments.js");

compiler/crates/relay-compiler/tests/relay_compiler_integration/fixtures/bare_graphql_token_does_not_loop.expected

@@ -0,0 +1,24 @@
+==================================== INPUT ====================================
+//- App.tsx
+graphql
+
+//- relay.config.json
+{
+   "language": "typescript",
+   "schema": "./schema.graphql",
+   "src": "./"
+}
+
+//- schema.graphql
+type User {
+   name: String
+}
+type Query {
+   me: User
+}
+==================================== OUTPUT ===================================
+
+
+Artifact Map:
+Project: default
+  Type: Mapping

compiler/crates/relay-compiler/tests/relay_compiler_integration/fixtures/bare_graphql_token_does_not_loop.input

@@ -0,0 +1,17 @@
+//- App.tsx
+graphql
+
+//- relay.config.json
+{
+   "language": "typescript",
+   "schema": "./schema.graphql",
+   "src": "./"
+}
+
+//- schema.graphql
+type User {
+   name: String
+}
+type Query {
+   me: User
+}

compiler/crates/relay-compiler/tests/relay_compiler_integration_test.rs

@@ -4,14 +4,21 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<7afb51e0fa901e3bfae2f4df45a4d022>>
+ * @generated SignedSource<<de4d2cb51732e8d59dea7363b863fc33>>
  */
 
 mod relay_compiler_integration;
 
 use relay_compiler_integration::transform_fixture;
 use fixture_tests::test_fixture;
 
+#[tokio::test]
+async fn bare_graphql_token_does_not_loop() {
+    let input = include_str!("relay_compiler_integration/fixtures/bare_graphql_token_does_not_loop.input");
+    let expected = include_str!("relay_compiler_integration/fixtures/bare_graphql_token_does_not_loop.expected");
+    test_fixture(transform_fixture, file!(), "bare_graphql_token_does_not_loop.input", "relay_compiler_integration/fixtures/bare_graphql_token_does_not_loop.expected", input, expected).await;
+}
+
 #[tokio::test]
 async fn client_extension_interface_backed_by_resolvers_in_throw_on_field_error() {
     let input = include_str!("relay_compiler_integration/fixtures/client_extension_interface_backed_by_resolvers_in_throw_on_field_error.input");