Add actionable guidance to plugin-socket dependency and field argument conflict error messages

Reviewed By: mjmahone

Differential Revision: D94953872

fbshipit-source-id: 656d7d490d7346c294d7bf63cde9a57fd860d96d

Author: janettec

compiler/crates/graphql-ir-validations/src/validate_selection_conflict.rs

@@ -642,7 +642,8 @@ enum ValidationMessage {
     },
 
     #[error(
-        "Expected all fields on the same parent with the name or alias `{field_name}` to have the same argument values after applying fragment arguments. This field has the applied argument values: {arguments_a}"
+        "Expected all fields on the same parent with the name or alias `{field_name}` to have the same argument values after applying fragment arguments. This field has the applied argument values: {arguments_a}. \
+        If the same field appears with different arguments, use an alias to distinguish them, e.g. `myAlias: {field_name}(...)`."
     )]
     InvalidSameFieldWithDifferentArguments {
         field_name: StringKey,

compiler/crates/relay-compiler/tests/compile_relay_artifacts/fixtures/client-fields-overlapping-error.invalid.expected

@@ -12,7 +12,7 @@ extend type Query {
   client_field(arg: String): String
 }
 ==================================== ERROR ====================================
-✖︎ Expected all fields on the same parent with the name or alias `client_field` to have the same argument values after applying fragment arguments. This field has the applied argument values: (arg: "Value1")
+✖︎ Expected all fields on the same parent with the name or alias `client_field` to have the same argument values after applying fragment arguments. This field has the applied argument values: (arg: "Value1"). If the same field appears with different arguments, use an alias to distinguish them, e.g. `myAlias: client_field(...)`.
 
   client-fields-overlapping-error.invalid.graphql:4:3
     3 │ query clientFieldsOverlappingErrorQuery {

compiler/crates/relay-compiler/tests/compile_relay_artifacts/fixtures/conflicting-selections-with-actor-change.invalid.expected

@@ -22,7 +22,7 @@ fragment conflictingSelectionsWithActorChange3_fragment on Query {
   }
 }
 ==================================== ERROR ====================================
-✖︎ Expected all fields on the same parent with the name or alias `username` to have the same argument values after applying fragment arguments. This field has the applied argument values: (name: "Alice")
+✖︎ Expected all fields on the same parent with the name or alias `username` to have the same argument values after applying fragment arguments. This field has the applied argument values: (name: "Alice"). If the same field appears with different arguments, use an alias to distinguish them, e.g. `myAlias: username(...)`.
 
   conflicting-selections-with-actor-change.invalid.graphql:13:3
    12 │ fragment conflictingSelectionsWithActorChange2_fragment on Query {

compiler/crates/relay-compiler/tests/compile_relay_artifacts/fixtures/conflicting-selections-with-defer.invalid.expected

@@ -22,7 +22,7 @@ query conflictingSelectionsWithDeferQuery {
   ...conflictingSelectionsWithDefer2_fragment @defer
 }
 ==================================== ERROR ====================================
-✖︎ Expected all fields on the same parent with the name or alias `node` to have the same argument values after applying fragment arguments. This field has the applied argument values: (id: 4)
+✖︎ Expected all fields on the same parent with the name or alias `node` to have the same argument values after applying fragment arguments. This field has the applied argument values: (id: 4). If the same field appears with different arguments, use an alias to distinguish them, e.g. `myAlias: node(...)`.
 
   conflicting-selections-with-defer.invalid.graphql:4:3
     3 │ fragment conflictingSelectionsWithDefer1_fragment on Query {

compiler/crates/relay-compiler/tests/compile_relay_artifacts/fixtures/conflicting-selections-with-no-inline.invalid.expected

@@ -19,7 +19,7 @@ query conflictingSelectionsWithNoInlineQuery {
   }
 }
 ==================================== ERROR ====================================
-✖︎ Expected all fields on the same parent with the name or alias `node` to have the same argument values after applying fragment arguments. This field has the applied argument values: (id: 4)
+✖︎ Expected all fields on the same parent with the name or alias `node` to have the same argument values after applying fragment arguments. This field has the applied argument values: (id: 4). If the same field appears with different arguments, use an alias to distinguish them, e.g. `myAlias: node(...)`.
 
   conflicting-selections-with-no-inline.invalid.graphql:4:3
     3 │ fragment conflictingSelectionsWithNoInline_fragment on Query @no_inline {

compiler/crates/relay-compiler/tests/compile_relay_artifacts/fixtures/fragment-with-defer-arguments-without-label.expected

@@ -23,7 +23,7 @@ fragment fragmentWithDeferArgumentsWithoutLabel_DeferredFragment on User @argume
   }
 }
 ==================================== ERROR ====================================
-✖︎ Expected all fields on the same parent with the name or alias `profile_picture` to have the same argument values after applying fragment arguments. This field has the applied argument values: (scale: 1.5)
+✖︎ Expected all fields on the same parent with the name or alias `profile_picture` to have the same argument values after applying fragment arguments. This field has the applied argument values: (scale: 1.5). If the same field appears with different arguments, use an alias to distinguish them, e.g. `myAlias: profile_picture(...)`.
 
   fragment-with-defer-arguments-without-label.graphql:20:3
    19 │   name

compiler/crates/relay-compiler/tests/compile_relay_artifacts/fixtures/relay-resolver-with-args-and-alias.expected

@@ -23,7 +23,7 @@ extend type User {
   pop_star_name(scale: Float!): String @relay_resolver(fragment_name: "relayResolverWithArgsAndAlias_PopStarNameResolverFragment_name", import_path: "./path/to/PopStarNameResolver.js")
 }
 ==================================== ERROR ====================================
-✖︎ Expected all fields on the same parent with the name or alias `profile_picture` to have the same argument values after applying fragment arguments. This field has the applied argument values: (scale: 1.5)
+✖︎ Expected all fields on the same parent with the name or alias `profile_picture` to have the same argument values after applying fragment arguments. This field has the applied argument values: (scale: 1.5). If the same field appears with different arguments, use an alias to distinguish them, e.g. `myAlias: profile_picture(...)`.
 
   relay-resolver-with-args-and-alias.graphql:5:3
     4 │   name

compiler/crates/relay-compiler/tests/compile_relay_artifacts/fixtures/same-fields-with-different-args.invalid.expected

@@ -19,7 +19,7 @@ fragment sameFieldsWithDifferentArgs_NestedFragment2 on User {
   firstName(if: false, unless: false)
 }
 ==================================== ERROR ====================================
-✖︎ Expected all fields on the same parent with the name or alias `firstName` to have the same argument values after applying fragment arguments. This field has the applied argument values: (if: false, unless: true)
+✖︎ Expected all fields on the same parent with the name or alias `firstName` to have the same argument values after applying fragment arguments. This field has the applied argument values: (if: false, unless: true). If the same field appears with different arguments, use an alias to distinguish them, e.g. `myAlias: firstName(...)`.
 
   same-fields-with-different-args.invalid.graphql:14:3
    13 │ fragment sameFieldsWithDifferentArgs_NestedFragment on User {

compiler/crates/relay-compiler/tests/compile_relay_artifacts/fixtures/same_fields_with_different_args_variables.invalid.expected

@@ -15,7 +15,7 @@ fragment sameFieldsWithDifferentArgsVariablesFragment on User @argumentDefinitio
   url(site: $arg)
 }
 ==================================== ERROR ====================================
-✖︎ Expected all fields on the same parent with the name or alias `url` to have the same argument values after applying fragment arguments. This field has the applied argument values: (site: "A")
+✖︎ Expected all fields on the same parent with the name or alias `url` to have the same argument values after applying fragment arguments. This field has the applied argument values: (site: "A"). If the same field appears with different arguments, use an alias to distinguish them, e.g. `myAlias: url(...)`.
 
   same_fields_with_different_args_variables.invalid.graphql:14:3
    13 │ ) {

compiler/crates/relay-compiler/tests/compile_relay_artifacts/fixtures/selection_set_conflict_added_argument.expected

@@ -11,7 +11,7 @@ query selectionSetConflictAddedArgumentQuery {
   }
 }
 ==================================== ERROR ====================================
-✖︎ Expected all fields on the same parent with the name or alias `profile_picture` to have the same argument values after applying fragment arguments. This field has the applied argument values: (scale: 1.5)
+✖︎ Expected all fields on the same parent with the name or alias `profile_picture` to have the same argument values after applying fragment arguments. This field has the applied argument values: (scale: 1.5). If the same field appears with different arguments, use an alias to distinguish them, e.g. `myAlias: profile_picture(...)`.
 
   selection_set_conflict_added_argument.graphql:4:5
     3 │   me {