Do not run continuous verification interval unless we explicitly set FLAGS_continuous_verification_interval

Author: archang19

db_stress_tool/no_batched_ops_stress.cc

@@ -373,7 +373,15 @@ class NonBatchedOpsStressTest : public StressTest {
   }
 
   void ContinuouslyVerifyDb(ThreadState* thread) const override {
-    if (!secondary_db_) {
+    // Currently this method gets calleds even when
+    // FLAGS_continuous_verification_interval == 0 as long as
+    // FLAGS_verify_db_one_in > 0. Previously, this was not causing a problem in
+    // the crash tests since test_secondary was always equal to 0, and thus we
+    // returned early from this method. When test_secondary is set and we have a
+    // secondary_db_, the crash test fails during this iterator scan. The stack
+    // trace mentions BlobReader/BlobSource but it may not necessarily be
+    // related to BlobDB
+    if (!secondary_db_ || !FLAGS_continuous_verification_interval) {
       return;
     }
     assert(secondary_db_);

tools/db_crashtest.py

@@ -1023,6 +1023,9 @@ def finalize_and_sanitize(src_params):
     if dest_params.get("track_and_verify_wals", 0) == 1:
         dest_params["metadata_write_fault_one_in"] = 0
         dest_params["write_fault_one_in"] = 0
+    # Continuous verification fails with secondaries inside NonBatchedOpsStressTest
+    if dest_params.get("test_secondary") == 1:
+        dest_params["continuous_verification_interval"] = 0
     return dest_params