Skip to content

Commit

Permalink
Update enum values
Browse files Browse the repository at this point in the history
  • Loading branch information
archang19 committed Jan 21, 2025
1 parent 0b84e89 commit 221529a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
4 changes: 2 additions & 2 deletions db/db_impl/db_impl_compaction_flush.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3739,8 +3739,8 @@ Status DBImpl::BackgroundCompaction(bool* made_progress,
// 1) When flush or compaction finish. This case is covered by
// InstallSuperVersionAndScheduleWork
// 2) When MutableCFOptions changes. This case is also covered by
// InstallSuperVersionAndScheduleWork, because this is when the
// new options take effect.
// InstallSuperVersionAndScheduleWork, because this is when the new
// options take effect.
// 3) When we Pick a new compaction, we "remove" those files being
// compacted from the calculation, which then influences compaction
// score. Here we check if we need the new compaction even without the
Expand Down
5 changes: 1 addition & 4 deletions java/rocksjni/portal.h
Original file line number Diff line number Diff line change
Expand Up @@ -5892,7 +5892,6 @@ class HistogramTypeJni {
case ROCKSDB_NAMESPACE::Histograms::NUM_COMPACTION_INPUT_ITERATORS:
return 0x3E;
case ROCKSDB_NAMESPACE::Histograms::HISTOGRAM_ENUM_MAX:
// 0x3F for backwards compatibility on current minor version.
return 0x3F;
default:
// undefined/default
Expand Down Expand Up @@ -6037,10 +6036,8 @@ class HistogramTypeJni {
TABLE_OPEN_PREFETCH_TAIL_READ_BYTES;
case 0x3E:
return ROCKSDB_NAMESPACE::Histograms::NUM_COMPACTION_INPUT_ITERATORS;
case 0x40:
// 0x40 for backwards compatibility on current minor version.
case 0x3F:
return ROCKSDB_NAMESPACE::Histograms::HISTOGRAM_ENUM_MAX;

default:
// undefined/default
return ROCKSDB_NAMESPACE::Histograms::DB_GET;
Expand Down
1 change: 0 additions & 1 deletion java/src/main/java/org/rocksdb/HistogramType.java
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ public enum HistogramType {
*/
NUM_COMPACTION_INPUT_ITERATORS((byte) 0x3E),

// 0x3F for backwards compatibility on current minor version.
HISTOGRAM_ENUM_MAX((byte) 0x3F);

private final byte value;
Expand Down

0 comments on commit 221529a

Please sign in to comment.