Skip to content

Commit 23b9dfc

Browse files
Hui Xiaometa-codesync[bot]
authored andcommitted
db_crashtest: re-enable track_and_verify_wals with disabled fault injection
Summary: See title. This is to harvest the coverage of the feature before we fix the tricky compatibility issue (see #13871) **Test plan:** Will only land after intensive rehersal stress test passes Differential Revision: D108797734
1 parent e292aa9 commit 23b9dfc

1 file changed

Lines changed: 17 additions & 2 deletions

File tree

tools/db_crashtest.py

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -497,8 +497,7 @@ def apply_random_seed_per_iteration():
497497
"memtable_verify_per_key_checksum_on_seek": lambda: random.choice([0] * 7 + [1]),
498498
"memtable_batch_lookup_optimization": lambda: random.randint(0, 1),
499499
"allow_unprepared_value": lambda: random.choice([0, 1]),
500-
# TODO(hx235): enable `track_and_verify_wals` after stabalizing the stress test
501-
"track_and_verify_wals": lambda: random.choice([0]),
500+
"track_and_verify_wals": lambda: random.choice([0, 1]),
502501
"remote_compaction_worker_threads": lambda: random.choice([0, 8]),
503502
"allow_resumption_one_in": lambda: random.choice([0, 1, 2, 20]),
504503
# TODO(jaykorean): Change to lambda: random.choice([0, 1]) after addressing all remote compaction failures
@@ -1571,6 +1570,22 @@ def finalize_and_sanitize(src_params):
15711570
dest_params["clear_column_family_one_in"] = 0
15721571
dest_params["test_multi_ops_txns"] = 0
15731572

1573+
if dest_params.get("track_and_verify_wals", 0) == 1:
1574+
# Disable fault injection while track_and_verify_wals is on. These fault
1575+
# injections trigger auto recovery, which flushes the memtable and
1576+
# rotates the WAL; that is currently incompatible with WAL tracking and
1577+
# verification and surfaces as spurious WAL verification failures.
1578+
# TODO: re-enable once the auto-recovery vs. track_and_verify_wals
1579+
# compatibility issue is fixed.
1580+
dest_params["write_fault_one_in"] = 0
1581+
dest_params["metadata_write_fault_one_in"] = 0
1582+
dest_params["read_fault_one_in"] = 0
1583+
dest_params["metadata_read_fault_one_in"] = 0
1584+
dest_params["open_metadata_write_fault_one_in"] = 0
1585+
dest_params["open_metadata_read_fault_one_in"] = 0
1586+
dest_params["open_write_fault_one_in"] = 0
1587+
dest_params["open_read_fault_one_in"] = 0
1588+
15741589
return dest_params
15751590

15761591

0 commit comments

Comments
 (0)